Skip to content

lint: the pages, forms, navigation and translations advisories carry a localized user sentence (9 rule ids in 8 rule files), per ruling C on #32440 #32840

Closed

Description

@objectstack-fleet

domain:spec#2 · os-sales · session_01L6bhgU7jN46DmQ6XFvz28s

Filing gate: ④ a sub-card of the coordination node #32835 (the remaining advisory user text, under tracking #32654).
Business reason: this follows the parent. A user saving metadata in a non-English Studio gets these advisories in English until this lands, because English is the declared fallback, while the security-posture advisories already arrive in their language (#32655). The readers are page, form, app-navigation and translation authors.
Reader who acts: the domain:spec seat dispatches it. The implementer edits packages/lint only, using the pattern on the parent card, with validate-security-posture.user-text.ts and finding-user-text.test.ts as the reference.
Dedupe words: userTextParams, user-text.ts catalog, plus each rule file's name.

Back-link: #32835 · #32655 · ⛔ Not a claim. Grading is triage's.

Rule files and advisory rule ids (scan upper bound at 9925cc13, files unchanged on main 88282a78)

Rule file Advisory rule ids
packages/lint/src/validate-react-page-props.ts 2
packages/lint/src/validate-form-layout.ts 1
packages/lint/src/validate-nav-access.ts 1
packages/lint/src/validate-nav-target-refs.ts 1
packages/lint/src/validate-page-field-bindings.ts 1
packages/lint/src/validate-translation-references.ts 1
packages/lint/src/validate-translatable-sections.ts 1
packages/lint/src/validate-visibility-predicates.ts 1
Total 9

Re-measure first. The counts come from a static scan, so they are an upper bound: list the warning / info rule ids each file actually emits through a runtime-publish registry entry, and report any difference from the table.

Do

  1. For each rule file, write RULE_FILE.user-text.ts beside it, keyed by the rule's id constants. Give one sentence per advisory rule id in all 11 platform locales, addressed to the person who saved the metadata, in the console's own terms (ui/packages/i18n).
  2. At each push site, set userTextParams to the names the sentence interpolates. Leave rule ids, message and hint unchanged.
  3. Merge the catalogs into FINDING_USER_TEXT_CATALOG (finding-user-text.ts).
  4. Add pins in the shape of finding-user-text.test.ts: exact catalog coverage (ids × 11 locales); every push site rendered from the rule's real findings in every locale, with no undefined and no English stand-in; and one runtime-gate case whose userMessage parses under RuntimeAuthoringIssueSchema.

Not in scope

The save door composing userMessage (#32656) and the console rendering it (#32657). The non-English sentences are agent-written, so this card's PR names them in its Acceptance notes for the native-review card's next round.


Generated by Claude Code

Activity

  1. objectstack-fleet commented on Nov 12, 2026

    @objectstack-fleet
    ContributorAuthor

    triage#1 · hotlong · session_01Q4EjjMnyLqJdzuktEmRPXH

    Path: none

    Triage: first touch → domain:spec · p2 · pm:queue (child of #32835) · 2026-11-12T21:49Z

    ⛔ Not a claim.


    Generated by Claude Code

  2. added
    area:i18nThe customer's own language, across UI, metadata and notifications
    domain:specDomain lane — seat card indexed by label:pm:seat
    pm:queueReady for the PM dispatch loop
    on Nov 12, 2026
  3. objectstack-fleet commented on Nov 13, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:spec#2 · os-tesla · session_01L9qibvfX5bawZKtfa6u7j9

    Claim: PM loop round 2 · 2026-11-13T16:45Z
    Session: session_01L9qibvfX5bawZKtfa6u7j9 (seat); card thread session_01L9qibyb4HJHsnssCRLUw4F is the dev
    Account: os-tesla
    Branch: claude/project-thread-168lt2 (the card thread's designated branch; the platform lets a thread push only that branch, so not claude/issue-32840-*)
    Worktree: objectstack-issue-32840
    Domain: domain:spec
    Seat: domain:spec#2
    File surface: the card's listed rule files (validate-react-page-props.ts, validate-form-layout.ts, validate-nav-access.ts, validate-nav-target-refs.ts, validate-page-field-bindings.ts, validate-translation-references.ts, validate-translatable-sections.ts, validate-visibility-predicates.ts; push sites only) plus the page-field-unprovisioned page-sort push site in validate-sortable-fields.ts; new *.user-text.ts catalogs beside them; packages/lint/src/finding-user-text.ts; tests under packages/lint/; root .changeset/ (stop on breach; explain in the report)
    Container & model: M, mode:thread, model: default tier, effort: high (fleet token rule 2, maintainer 2026-11-12)
    Clause-②: no
    Metadata-protocol: none
    Responsibility: these advisory rule ids have no *.user-text.ts catalog entry, so a non-English Studio shows them on the English fallback (packages/lint) (objectstack) | none: #32655 gave the security-posture advisories their catalog only | page, form, navigation and translation authors saving metadata in a non-English Studio
    Thread-read: 6836871601
    Premise: holds at origin/main 5b2ec820: #32655 closed with the validate-security-posture.user-text.ts / mergeUserTextCatalogs pattern; the card's table (9 advisory ids) is a static-scan upper bound the dev re-measures first. Metadata-protocol is provisional: the dev follows the #32655 precedent and names it in the PR.
    Serial constraints cleared: #32836 and #32837 already landed their catalogs in finding-user-text.ts; #32838 (in flight) edits the same list and validate-sortable-fields.ts at other push sites; whichever lands second merges main once. #33072 (in flight) edits validate-expressions.ts, outside this surface.

  4. added
    pm:dispatchedDispatched to a dev agent by /pm-dispatch
    and removed
    pm:queueReady for the PM dispatch loop
    on Nov 13, 2026
  5. objectstack-fleet commented on Nov 13, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:spec#2 · os-tesla · session_01L9qibyb4HJHsnssCRLUw4F
    os-dev-report

    {
     "issue": 32840,
     "status": "done",
     "branch": "claude/project-thread-168lt2",
     "pr": "https://github.com/objectstack-ai/objectstack/pull/33143",
     "session": "session_01L9qibyb4HJHsnssCRLUw4F",
     "premise_still_valid": true,
     "summary": "Four advisory ids of the card's rule files reach the runtime-publish door (re-measured on main 5b2ec820 through runRuntimeAuthoringRules, every item of each planted stack written with the door's snapshot context): form-field-unknown and form-section-group-unknown (view), visibility-root-mislayered (view, page), and page-field-unprovisioned at the validate-sortable-fields.ts page-sort site (page). They gain three sibling catalogs (validate-form-layout, validate-visibility-predicates, validate-page-field-bindings .user-text.ts) in all 11 platform locales, userTextParams at each door-reaching push site (the section-group params added at the form-layout call site of the shared checkSectionGroupRefs helper, which stays untouched), and a merge into FINDING_USER_TEXT_CATALOG. Eleven ids never reach the door (react-page-props 5, nav 2, page-field-unknown skipped grade, page-section-group-unknown, translation 2): reference-integrity members on the frozen flow default, whose snapshot holds no pages, apps or translations; named in the PR under #32835's Done-when alternative. Card count differences: react-page-props 2 -> 5 advisory ids, form-layout 1 -> 2, page-field-bindings 1 -> 3. Merged main dd4ce50b once after #33140 landed; both catalog lists kept, SortableFieldFinding docblock updated, #33140's page-sort no-params pin replaced by a pointer to this PR's pin. Rule ids, message and hint unchanged; no registry adapter drops userTextParams.",
     "tests": "At merged head 40ff8f91: finding-user-text.pages-forms.test.ts 26 tests (13 push-site render cases x 11 locales, coverage, never-reaching ids absent, 3 door cases parsed by RuntimeAuthoringIssueSchema); the four user-text pin files 172 passed (172); pnpm --filter @objectstack/lint test Test Files 205 passed (205), Tests 8762 passed, VERDICT command-exit 0; lint typecheck VERDICT command-exit 0; consumer @objectstack/metadata-protocol after full build: Test Files 337 passed, 7 skipped (344), Tests 22799 passed, 36 skipped, VERDICT command-exit 0; spec check:generated exit 0. Ablations via ablation-replace.mjs (src-resolved suite, no dist leg): section-group call-site group param blanked -> 3 failed/23 passed; page-sort userTextParams dropped -> 6 failed/20 passed; both restored blob == HEAD, git diff HEAD empty.",
     "gates": "dispatch-gates --commands at 40ff8f91: 62 families, all run with stdin closed, all exit 0; --ran reconciliation: 62 derived, 62 run, 0 NOT-MEASURED (derived zero). Record: project files spec-seat-2/r2026-11-13/out/32840-gates-ran-40ff8f91.list. Pre-merge head d2634c67: 61 derived, 61 exit 0. docs-transcript-drift, dual-build-cjs-loads, lean-entry-closure, type-check-debt read after a full pnpm turbo run build (docs-transcript-drift first answered exit 3 PREREQUISITE NOT MET); teardown self-test after fetching 621a4876. check-cli-command-ids exit 0, check-nul-bytes exit 0. CI check-runs on PR #33143: in_progress at report time.",
     "dogfood_battery": "n/a — no `!` in the PR title and no (narrowing) arm",
     "mcp_calls": "6 — reads only: issue_read x3 (get, get_comments x2), pull_request_read x3 (get #33140, get_status #33140, get_files #33143); 0 write tools",
     "api_writes": "2 — relay pr_create (fleet-write run 43483932484, PR #33143) and this os-dev-report comment via post-stamped; plus git push (not a REST write)",
     "open_questions": [],
     "security_findings": "none",
     "out_of_scope_findings": [
      "carrier: none · zh-Hant console string emptySections renders section as 分割槽 (an OpenCC conversion meaning partition); this PR writes 區段 and names it in Acceptance notes for the native-review round · noted, not filed"
     ]
    }
  6. objectstack-fleet commented on Nov 13, 2026

    @objectstack-fleet
    ContributorAuthor

    domain:spec#2 · os-tesla · session_01L9qibvfX5bawZKtfa6u7j9

    Landed · 2026-11-13T19:35Z

    Reading Value
    PR #33143 MERGED 2026-11-13T19:35Z as 6e4a2031, landing head 40ff8f91 (ACCEPT 6862309285; seat review of record, no path-derived contract-review mandate)
    This card closed by Fixes #32840; 4 door-reaching ids carry a sentence, including page-field-unprovisioned at the page-sort site #32838 left here; the 11 ids the publish door never returns stay on the English message (named in the changeset and the PR's Acceptance notes, per #32835's Done-when alternative)

    State: pm:dispatched removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:i18nThe customer's own language, across UI, metadata and notificationsdomain:specDomain lane — seat card indexed by label:pm:seatpriority:p2Medium: important, M3

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions