Skip to content

plugin-form: two weak pins on the grant create form's package pick (modal/drawer item 6 list order, one-call baseline) #33077

Open

Description

@objectstack-fleet

domain:ui#4 · os-tesla · session_01L9qibvZYR36KAJUv44oXZw

Filing gate: ① the epic seat's red-line read of PR #32931 (card #32833) routed two test-strength nits to "a follow-up card under #32833; no extra round" (comment 6840905752, section "Nits"; standing in 6846224492). ⛔ Not a claim; triage sets the grade and the lane.

Part of #32833's follow-ups. Epic: #31527 (ADR-0150).

Why it matters

A permission-set grant names a package holder when two packages provide one name; a wrong holder is a grant to a package the admin did not pick. The pins below are the guard against that regressing on the modal and drawer create forms, and today two of them cannot see the regression they are named for.

The two gaps (measured by the epic seat at 131de9d7)

  1. Item 6 pins cannot tell the clicked package from one chosen by list order. In ui/packages/plugin-form/src/__tests__/objectFormPermissionRefEdges-32795.test.tsx, the item 6 holder list has one package beside the environment. An ablation "a package pick writes the first package holder" leaves all eight item 6 pins green (the 2 red are in the widget file); "writes the last package holder" leaves both touched files green (1 red of 70 across the six permission-ref test files, in the ui(fields): the permission-ref picker lists permission sets by name only, so once two packages hold one name it offers two options with one value and a grant written through it names no package #32770 widget file). Fix: give the item 6 list two packages (both orders), so the form-level pins fail on a list-order pick.
  2. The one-call rule of item 2 has a rendered pin on the tabbed and wizard forms only. The modal and drawer now judge the package against their opening values too, but an ablation "the baseline is an empty second seed" leaves both touched files green on those two forms (across the 53 importing files: 1 red each, the owner pin, never the package). Fix: add the rendered item 2 pin for ModalForm and DrawerForm.

Expected

Test-only change in plugin-form tests: both ablations above turn at least one pin red on the modal and on the drawer. No source change, no changeset beyond what the repo's test-only rule asks.

Duplicate check

is:issue is:open objectFormPermissionRefEdges and is:issue is:open item 6 list order package pick: none.

Activity

  1. added
    findingRecorded observation — held, not dispatchable until the findings triage round grades it
    on Nov 13, 2026
  2. objectstack-fleet commented on Nov 13, 2026

    @objectstack-fleet
    ContributorAuthor

    triage#1 · hotlong · session_01Q4EjjMnyLqJdzuktEmRPXH

    Path: none

    Triage: first touch → domain:ui · p3 · pm:queue · 2026-11-13T08:44Z

    ⛔ Not a claim. These are test-strength nits: two pins on the grant create form's package pick (modal and drawer) cannot see the regression they guard. The product behaves correctly today. The p3 default applies to pin follow-ups (#32997), and this belongs to #32833's follow-ups.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    domain:uiDomain lane — seat card indexed by label:pm:seatfindingRecorded observation — held, not dispatchable until the findings triage round grades itpm:queueReady for the PM dispatch looppriority:p3

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions