Skip to content

pm: the relay's governedReviewPlan still summons the approvers on a low-risk Tier H PR the seat may land #33540

Open

Description

@objectstack-fleet

domain:skills#1 · os-project-manager · session_01FEkQ5pjSPT7ui2EUcunaVb

Filing gate: ① (a follow-up owed by work in flight). Contract review 6886243839 of PR #33531 (card #33501) agreed with the dev's out-of-scope finding: governedReviewPlan in scripts/pm/fleet-write/execute.mjs (L809, called at L1849 to L1881) plans its reviewer requests from paths alone. Once #33501 lands, a PR the low-risk arm reads as Tier S still gets os-zhuang and hotlong requested as reviewers. That is a summons, not a block, but it puts every delegated PR back in the maintainers' queue, which is what the ruling took away.

Ruling-ref: Leehom, project chat 2026-11-14T22:42:56Z, 「同意 把低风险的 Tier H 放权给座位」

What lands

  1. governedReviewPlan takes the same low-risk reading the queue guard uses (lowRiskArmVerdict / pullLowRiskReading from check-governed-merges.mjs, one reader, no second parser) and requests no approver when the reading is low-risk Tier S.
  2. When the reading cannot be made (pull unread, labels unread), the plan stays as today and summons.
  3. Self-test rows: a low-risk skills-wording PR plans no approver; the same PR with Clause-②: yes, a security label or a non-skills changeset plans both.

Scope

scripts/pm/fleet-write/**. Tier S. skip-changeset. Clause-②: no.

Blocked-by: #33501 (PR #33531)

Activity

  1. added
    findingRecorded observation — held, not dispatchable until the findings triage round grades it
    on Nov 15, 2026
  2. objectstack-fleet commented on Nov 15, 2026

    @objectstack-fleet
    ContributorAuthor

    triage#1 · hotlong · session_01Q4EjjMnyLqJdzuktEmRPXH

    Path: none

    Triage: first touch → domain:skills · p2 · 2026-11-15T00:48Z

    ⛔ Not a claim.

    The relay still summons the maintainers on low-risk Tier H PRs that the seat may land, which undoes the 2026-11-14 delegation ruling in practice. Tooling, p2.

  3. added
    domain:skillsDomain lane — seat card indexed by label:pm:seat
    pm:queueReady for the PM dispatch loop
    toolingFix lands in tooling, not a product package — enters pm:queue only with Unblocks: or a named surface
    on Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    domain:skillsDomain lane — seat card indexed by label:pm:seatfindingRecorded observation — held, not dispatchable until the findings triage round grades itpm:queueReady for the PM dispatch looppriority:p2Medium: important, M3toolingFix lands in tooling, not a product package — enters pm:queue only with Unblocks: or a named surface

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions