Skip to content

governance: the guard scripts join the governed register, .claude/** lands by declared rule-change, and a narrowed spec change lands only by the maintainer #35321

Open

Description

@os-warren

review-split thread · os-warren · session_01JQwxbYzM6act7DgRZuPrxu

Source: maintainer — Warren, 2026-11-19, review-split discussion thread: 03:16Z 「以上都同意」; 03:17Z 「北极星、AGENTS.md、改车队规则的技能条文(谁能做什么、怎么定级、怎么合并)也需要fable 吧」; 03:17Z 「spec:收紧作者能写的东西(会让现有应用报错),也需要fable 吧?」; 04:24Z 「1+2+4」 (point 1: fleet rule text goes back to the maintainer, overriding the 2026-09-18 ruling that handed all of .claude/** to seats on a contract review); 04:30Z 「「已裁定的照抄只核对、不再审」 同意」. Scope of "rule text the maintainer decides" (04:28–04:30Z): what an agent may do without him (merge, bypass checks, change repo settings); what gets done and in what order (grading, dispatch, scope); what must go to him (decisions, maintainer actions). Process steps, scripts, wording, slimming and file moves stay with the reviewer.

Filing gate: ③ a task the maintainer dispatched. Child of epic #35205. Read-only findings behind it: the guard scripts are not governed today (node scripts/pm/check-governed-merges.mjs --test scripts/pm/check-governed-queue-guard.mjs scripts/pm/check-governed-merges.mjs scripts/pm/dispatch-gates.mjs answers 0 of 3 hits on 00cfb78f), and the queue leg runs the guard from the merge group's own tree, so a PR that edits the guard is judged by its own copy. CODEOWNERS routes those files but the ruleset requires no code-owner review.

Grade: p2 · area:fleet · Task · fleet machinery, no product surface

维护者速读

  • 改了什么:守门脚本本身改动要你批;.claude/** 里改「agent 不经你能做什么、先做什么、什么必须找你」的要你批,只改措辞的评审核实后落地;让现有应用报错的协议收紧要你批。
  • 为什么:你 11-19 的「1+2+4」与 04:30Z 两条;今天改守门脚本可以绕开所有拦截。
  • 最坏:判错一类 PR 会多来找你或少来找你;改动可整 PR 回滚。
  • 需要你做的:无(PR 到时请你批)。

What changes

  1. The guard instruments join GOVERNED_SURFACES, Tier H, scoped to objectstack: scripts/pm/check-governed-merges.mjs, scripts/pm/check-governed-queue-guard.mjs, scripts/pm/record-recognisers.mjs, scripts/pm/dispatch-gates.mjs (it holds CONTRACT_REVIEW_TIER). If the workflow split (readWorkflowDiff) can read an edit to .github/workflows/governed-surface-guard.yml as Tier S, that file joins the always-H list too.
  2. .claude/** splits by declaration. The row stays governed; its Tier S holds only when the PR body carries a line-start Rule-change: none (or Rule-change: ruled with a line-start Ruling-ref: quoting the maintainer's words, source and time) AND the PASS ## Contract review record for the current head carries Rule-change-verified: none (or ruled). A missing line, Rule-change: yes, or a record that does not verify ⇒ Tier H. .claude/settings*.json and .claude/hooks/** are always Tier H (they are the agents' own permissions and guardrails). ui/.claude/** stays Tier H as today.
  3. A narrowed spec change lands like Tier H. A PR whose body or a changeset declares Metadata-protocol: narrowed, or a Clause-② line with the (narrowing) arm, is refused by the queue guard until an authorized APPROVED review and a PASS contract review for the head are on record. added, semantic and none are unchanged (reviewer only).
  4. The workflows row adds hotcrm (audit mirror; hotcrm's own AGENTS.md lists .github/workflows/** as governed in its own PR).
  5. Prose: AGENTS.md Prime Directive feat: Comprehensive CRM example demonstrating all ObjectStack protocol features #14 says the new rows and the .claude/** declaration split in one or two sentences; the pm-dispatch path-fork region names the new surfaces (pnpm check:pm-governed-prose); references/contract-review.md gains the Rule-change-verified: record line in its template.

Done when

Activity

  1. self-assigned this
    on Nov 19, 2026
  2. added theissue type on Nov 19, 2026
  3. added
    toolingFix lands in tooling, not a product package — enters pm:queue only with Unblocks: or a named surface
    on Nov 19, 2026
  4. os-warren commented on Nov 19, 2026

    @os-warren
    CollaboratorAuthor

    Claim: review-split order 2026-11-19
    Session: session_01JQwxbYzM6act7DgRZuPrxu
    Account: os-warren
    Branch: claude/issue-35321-governed-guard-and-rule-change
    Worktree: objectstack-issue-35321
    Domain: domain:skills
    File surface: scripts/pm/check-governed-merges.mjs, scripts/pm/check-governed-queue-guard.mjs, scripts/pm/record-recognisers.mjs, scripts/pm/check-governed-prose.mjs (self-test only if needed), .github/CODEOWNERS, AGENTS.md, .claude/skills/pm-dispatch/SKILL.md (path-fork region only), .claude/skills/pm-dispatch/references/contract-review.md
    Container & model: M, mode:subagent, effort: xhigh
    Clause-②: no
    Metadata-protocol: none
    Responsibility: n/a — not a defect card
    Thread-read: none
    Premise: holds (register read on 00cfb78f)
    Serial constraints cleared: #35259 (pm-dispatch SKILL.md) — this PR opens after that PR merges


    Generated by Claude Code

  5. objectstack-fleet commented on Nov 19, 2026

    @objectstack-fleet
    Contributor

    triage#1 · hotlong · session_01Q4EjjMnyLqJdzuktEmRPXH

    Release: #35321 · holder os-warren is out of tokens (seat-offline, brief 7005006297 on #32588) · back to pm:queue for an online sibling seat
    Resume-from: none

    2026-11-19T09:25Z · No fleet-lane seat is online; it waits in the queue for the next seat that takes area:fleet tooling.

  6. added
    pm:queueReady for the PM dispatch loop
    and removed
    pm:dispatchedDispatched to a dev agent by /pm-dispatch
    on Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:fleetdomain:skillsDomain lane — seat card indexed by label:pm:seatpm:queueReady for the PM dispatch looppriority:p2Medium: important, M3toolingFix lands in tooling, not a product package — enters pm:queue only with Unblocks: or a named surface

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions