Repository navigation
fix(spec): try_catch nodeId and errorVariable describes say what the engine binds - #24694
Conversation
…engine binds Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D6F9axfoPzR7t8G1J7Ytzz
…describes Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D6F9axfoPzR7t8G1J7Ytzz
📓 Docs Drift CheckThis PR changes 1 package(s): 1 hand-written doc(s) NAME something this change touched and may need an implementation-accuracy re-verification:
What this run could not see
Coarse fallback — 143 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): Which tree this was computed onThis run read A worktree cut from an older # while this PR is open — GitHub drops the merge commit once it closes
git fetch origin a24e738df0b77e8758c0bce680bde4dd8bca949f && git checkout a24e738df0b77e8758c0bce680bde4dd8bca949f
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 0431002104679f10523a8c7bb1433dd2d327fa7f 9112cb75db659db6974b94da2ae49995a9427c8b && git checkout -B drift-repro 0431002104679f10523a8c7bb1433dd2d327fa7f && git merge --no-ff 9112cb75db659db6974b94da2ae49995a9427c8b
node scripts/docs-audit/affected-docs.mjs --json 0431002104679f10523a8c7bb1433dd2d327fa7f
|
Closes #24659
What
Two
.describe()sentences inpackages/spec/src/automation/control-flow.zod.tsnow say what the engine actually binds. No schema shape, default or runtime path changes.TryCatchErrorValue.nodeId: was "Node the failure is attributed to". The engine (packages/services/service-automation/src/builtin/try-catch-node.ts, theerrorValueliteral) bindsnodeId: node.id, the Try / Catch node's own id; the failing inner step only appears insidemessage. New text: "Id of this Try / Catch node, not of the step that failed inside its try region; that step is normally named insidemessage".TryCatchConfig.errorVariable: drops "The value is aTryCatchErrorValue: ..." and says in words what the value carries, aligned with the node descriptor text that PR fix(service-automation): try_catch Error Variable help describes the caught error in words #24655 landed ("the id of this Try / Catch node (nodeId), the failure message, which normally names the step that failed (message) ..."). The ADR-0112$error.codebranching hint is kept.Regenerated with repo tooling (
gen:schema,gen:docs):content/docs/references/automation/control-flow.mdx(the two table rows). The shippedjson-schema/automation/TryCatchConfig.jsonandTryCatchErrorValue.jsonare gitignored build output and carry the new text after the build (grep count 1 each, measured on the built tree). No test pinned either sentence (git grepof both old sentences outside the generated page: zero hits besides the source).Changeset:
.changeset/24659-try-catch-describes.md,@objectstack/specpatch.Verification (head 9112cb7)
pnpm --filter @objectstack/spec build && gen:schema && gen:docs: exit 0 ("Generated 227 files").pnpm --filter @objectstack/spec check:generated: "All 14 generated artifacts are up to date", exit 0.pnpm --filter @objectstack/spec typecheck: exit 0.pnpm --filter @objectstack/spec exec vitest run --maxWorkers=2 src/automation: 37 files, 1576 tests passed.node scripts/pm/dispatch-gates.mjs --commands: 104 derived commands run; 103 exit 0 (five of them after building@objectstack/formula,@objectstack/lint,@objectstack/client,@objectstack/client-react, which they read). NOT MEASURED:pnpm check:dual-build-cjs-loads, reason: PREREQUISITE NOT MET (it reads every package dist/, and a full workspace build was not run locally); declared to CI.--ranreconciliation: 104 derived, 104 run, 0 UNRUN.Acceptance notes
control-flow.zod.tswere checked before opening (all 15 open PRs' file lists): none.origin/main3a931fc and holds.Generated by Claude Code