Repository navigation
fix(spec, runtime): endpoint refusal, hint and describes no longer name 17.x as the running major - #24699
Conversation
…me 17.x The publish refusal for script/proxy endpoints, the runtime's unsupported hint and the endpoint schema describes said "in 17.x" while 18.x is the running major. State what the runtime does without naming a version. No behaviour change. Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D6F9axfoPzR7t8G1J7Ytzz
Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D6F9axfoPzR7t8G1J7Ytzz
…dpoint-text-version-free
📓 Docs Drift CheckThis PR changes 2 package(s): 3 hand-written doc(s) NAME something this change touched and may need an implementation-accuracy re-verification:
What this run could not see
Coarse fallback — 148 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): Which tree this was computed onThis run read A worktree cut from an older # while this PR is open — GitHub drops the merge commit once it closes
git fetch origin c007cd839dce15a7d754cc47f07c7b00d9767a20 && git checkout c007cd839dce15a7d754cc47f07c7b00d9767a20
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 9e2722a923d29d3367ab38d2dee6023b696af8ea f8e3a95abf11534a5e051db5193fbb6afb905cf3 && git checkout -B drift-repro 9e2722a923d29d3367ab38d2dee6023b696af8ea && git merge --no-ff f8e3a95abf11534a5e051db5193fbb6afb905cf3
node scripts/docs-audit/affected-docs.mjs --json 9e2722a923d29d3367ab38d2dee6023b696af8ea
|
Closes #24654
Clause-②: no
What changed
Four customer-facing sentences said "in 17.x", but 18.x is the running major and the behaviour they describe has not changed. Each one now says what the runtime does without naming a version, so it cannot go stale again at 19.0. ⛔ No behaviour change, no new gate.
packages/spec/src/api/endpoint-publish-gate.tsos build/os validaterefusal for ascript/proxyendpointscriptis refused because ..."packages/runtime/src/endpoint-executor.ts(hint)unsupportedanswerpackages/spec/src/api/endpoint.zod.tstypedescribepackages/spec/src/api/endpoint.zod.tsApiMapping.transformdescribeSame PR, maintainer-facing JSDoc:
packages/runtime/src/api-mapping.ts(the mirroredtransformdescribe row) andpackages/runtime/src/endpoint-executor.ts(theparams"always{}" notes and theplanEndpointTargetdoc).Bounded in-place fix, named here:
packages/spec/src/api/endpoint.zod.ts,ApiEndpoint.targetdescribe, said the Script Name / Proxy URL spellings "stay unreachable in 17.x". It is the same defect class, in the same file, on the same schema, and the same gate family covers it (check:docs). It now reads "stay unreachable on this runtime". Evidence: the regeneratedcontent/docs/references/api/endpoint.mdxrow fortarget.Pins: no test asserted the old text (
git grep -nE "execute in 17|EXECUTED in 17|EXECUTE in 17"over*.test.tsreturns 0 hits). Two test TITLES inpackages/runtime/src/endpoint-executor.test.tsrepeated "in 17.x". They were reworded and their assertions are unchanged.Regenerated with repo tooling:
pnpm --filter @objectstack/spec check:generated --fixfoundcheck:docsstale (1 of 14), regeneratedcontent/docs/references/api/endpoint.mdxand re-checked it green. Changeset:.changeset/24654-endpoint-text-version-free.md,patchfor@objectstack/specand@objectstack/runtime.Verification (head
f8e3a95abf, which includes a merge oforigin/main0431002104)pnpm --filter @objectstack/spec build && pnpm --filter @objectstack/spec check:generated, post-merge: "All 14 generated artifacts are up to date", lock VERDICT command-exit 0.pnpm --filter @objectstack/spec testatf8e3a95abf: 701 files passed, 1 skipped; 21347 tests passed.pnpm --filter @objectstack/spec typecheck: exit 0.pnpm --filter @objectstack/runtime test && pnpm --filter @objectstack/runtime typecheckat018b472bd5(the change itself, before the merge): 425 files passed; 6678 tests passed, 19 skipped; typecheck exit 0. The merge brought no change to the files this PR edits. The runtime suite was not re-run on the merge head; CI runs it there.node scripts/pm/dispatch-gates.mjs --commandsderived 110 commands atf8e3a95abf. All of them were run, and--ranreconciles: "110 derived famil(ies) accounted for — 109 run, 1 NOT-MEASURED".check:dual-build-cjs-loads. Reason: PREREQUISITE NOT MET (exit 3). It needs a full workspace build, and this worktree only built the runtime dependency closure.check:lean-entry-closurefirst exited 1 because@objectstack/specdist was missing: a spec rebuild was running at the same time. Re-run after the build finished: exit 0.Acceptance notes
Other "in 17.x" sites outside this card's file surface. None of them was edited here:
packages/rest/src/openapi-endpoints.ts:218:unsupportedReasonsays "which this runtime does not execute in 17.x". This is customer-facing OpenAPI output for the same endpoint family. It is reported to the seat as a finding.skills/objectstack-api/SKILL.md:163: "script/proxydo not execute in 17.x". This is the published skill text, a Tier H surface. It is reported to the seat.packages/spec/src/stack.zod.ts:845(JSDoc),packages/spec/src/contracts/metadata-service.ts:210(JSDoc, with the test titlemetadata-service.test.ts:485),packages/spec/src/automation/flow-node-expression-paths.ts:126(JSDoc),packages/spec/liveness/api.json:15(ledger note): maintainer-facing only.Generated by Claude Code