Skip to content

fix(cli): retire the five stale scaffold peerDependencyRules entries - #25239

Merged
objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-25123-scaffold-peer-ledger
Oct 22, 2026
Merged

objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-25123-scaffold-peer-ledger

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Requested by Sales · project thread

Fixes #25123

Clause-②: no
Metadata-protocol: none

What

On the better-auth 1.7.12 pin, all five SCAFFOLD_ALLOWED_PEER_VERSIONS entries suppress peer mismatches that no longer exist, so they retire at once (a ledger entry states a fact that holds; no staged grace):

Entry Reading on origin/main 123ff6f
better-auth>better-sqlite3 (13) better-auth@1.7.12 declares no better-sqlite3 peer (lockfile peerDependencies block and npm view). Control leg: npm view better-auth@1.7.3 peerDependencies still names better-sqlite3: ^12.0.0.
@better-auth/core, /oauth-provider, /scim, /sso each >@better-auth/utils (0.5.0) All four at 1.7.12 peer ^0.4.2 || ^0.5.0; the tree resolves 0.5.0.

The map is now empty, so both scaffold paths (objectstack init and npx create-objectstack) stop emitting a peerDependencyRules block; renderPnpmWorkspaceYaml already omitted it for an empty map. The docblock's better-call reading is corrected to what holds: stable scim peers better-call exactly at 1.4.4, the resolved copy (it read 1.4.0 on the 1.7.3 pin).

allowedVersions only silences a report, so the resolution a scaffold gets is unchanged.

Files

  • packages/cli/src/commands/init.ts: map emptied; its docblock rewritten as the retired-entries record; the renderPnpmWorkspaceYaml docblock line about the peer block updated.
  • packages/cli/test/init.test.ts: presence pins flipped to per-key absence pins, a set pin (toEqual({})), a no-block pin, and a fixture-map pin for the render path; the top-level key list loses peerDependencyRules.
  • packages/cli/test/better-sqlite3-peer-declaration.pin.test.ts: the widening-equals-declared-major limb becomes an absence pin; the CLI's own 13.x declaration pins stay.
  • packages/cli/test/scaffold-workspace-consistency.test.ts: drops the non-vacuity guard that required a non-empty peer map (two empty maps are now the intended state; the byte-equality limb still holds both files).
  • packages/create-objectstack/src/templates/blank/pnpm-workspace.yaml + src/template-consistency.test.ts: same retirement in the bundled template, which is held byte-equal to the cli renderer.
  • pnpm-workspace.yaml (root): one comment sentence that called these entries' retirement conditions unmet.
  • .changeset/25123-scaffold-peer-ledger-retired.md: patch for @objectstack/cli and create-objectstack (the template ships in dist/templates).

Verification (head 3737254)

  • Closure build under the verify lock: pnpm --filter '@objectstack/cli^...' --filter 'create-objectstack^...' --filter @objectstack/cli --filter create-objectstack build → VERDICT command-exit 0.
  • Targeted: cli test/init.test.ts, test/better-sqlite3-peer-declaration.pin.test.ts, test/scaffold-workspace-consistency.test.ts → 3 files, 63/63; create-objectstack src/template-consistency.test.ts → 1 file, 39/39.
  • cli unit layer (vitest run --project unit) → 324 files, 4775/4775; create-objectstack pnpm test → 18 files, 278/278; pnpm --filter @objectstack/cli typecheck and pnpm --filter create-objectstack typecheck → exit 0. The integration layer is left to CI (no spawn entry or integration file touched).
  • Mutation leg (one-shot, via scripts/ablation-replace.mjs, restored by git checkout HEAD, blob re-verified as 73c71be9f): re-adding 'better-auth>better-sqlite3': '13' to the map turns 7 tests red across the three cli files. Tests import src/, so no dist leg applies.
  • pnpm lint → exit 0.
  • dispatch-gates --commands: 81 derived; 79 exit 0; check:dual-build-cjs-loads and check:i18n-coverage exit 3 PREREQUISITE NOT MET (they need dist for packages outside this closure) → NOT MEASURED locally, CI runs them.

Acceptance notes

  • The dispatch named packages/cli/src/commands/init.test.ts; the pins actually live at packages/cli/test/init.test.ts.
  • The bundled template's package is named create-objectstack (unscoped), so the changeset names it that way.

Generated by Claude Code

On the better-auth 1.7.12 pin, better-auth declares no better-sqlite3
peer and @better-auth/core, oauth-provider, scim and sso peer
@better-auth/utils as ^0.4.2 || ^0.5.0, so all five allowedVersions
entries suppress nothing. SCAFFOLD_ALLOWED_PEER_VERSIONS is now empty,
both scaffold paths drop the block, and the pins flip to absence.

Claude-Session: https://claude.ai/code/session_01CxBKycaiUpA1yGx1XyoGqX
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 2 package(s): @objectstack/cli, objectstack-blank, touching 2 documentable anchor(s). ⚠️ 1 changed file(s) yielded no anchor (packages/create-objectstack/src/templates/blank/pnpm-workspace.yaml), so the pages documenting them are NOT COVERED by this run — this is not a clean bill of health for those files.

6 hand-written doc(s) NAME something this change touched and may need an implementation-accuracy re-verification:

  • content/docs/deployment/cli.mdx (via os init (command, read off packages/cli/src/commands/init.ts))
  • content/docs/deployment/troubleshooting.mdx (via os init (command, read off packages/cli/src/commands/init.ts))
  • content/docs/getting-started/examples.mdx (via os init (command, read off packages/cli/src/commands/init.ts))
  • content/docs/getting-started/your-first-project.mdx (via os init (command, read off packages/cli/src/commands/init.ts))
  • content/docs/plugins/index.mdx (via os init (command, read off packages/cli/src/commands/init.ts))
  • content/docs/protocol/kernel/index.mdx (via os init (command, read off packages/cli/src/commands/init.ts))

⛔ 4 release-owned page(s) also name something this change touched. These are read-only:

  • content/docs/releases/v17/17-1.mdx (via os init (command, read off packages/cli/src/commands/init.ts))
  • content/docs/releases/v17/17-4.mdx (via os init (command, read off packages/cli/src/commands/init.ts))
  • content/docs/releases/v17/17-5.mdx (via os init (command, read off packages/cli/src/commands/init.ts))
  • content/docs/releases/v17/17-7.mdx (via os init (command, read off packages/cli/src/commands/init.ts))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • 1 changed file(s) yielded no anchor (packages/create-objectstack/src/templates/blank/pnpm-workspace.yaml) — pages documenting those are invisible to this run
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.
  • a key NAME is not a key, so the hand re-read the line above prescribes can land on the wrong schema. The same spelling is authorable on one governed type and a [REMOVED] tombstone on another for each of active, aria, joins, objects, template, tools and version (censused on [finding] tools is a key on BOTH AgentSchema (tombstoned, dead) and SkillSchema (live, cloud-attested), so a name-based search attributes skill examples to the agent key — it produced a false stop-the-line alarm on PR #19059 #19093 over the liveness ledger's governed types, top-level keys); nothing in a search result distinguishes the two, so a grep hit on a LIVE example reads as evidence about the DEAD key. Measured on fix(spec): the agent.tools liveness row says dead — it claimed live on a key the schema tombstoned #19059: content/docs/ai/agents.mdx was reported as contradicting the agent.tools tombstone over its tools: example at :161, which is inside the defineSkill({ block opened at :155 — the page was already correct. Settle ownership by PARSING the value against both schemas, never by the name: that literal PASSES SkillSchema, and as an AgentSchema it FAILS at tools with the tombstone prescription. ⛔ These names are not the whole class — a key retired through a .strict() guidance map leaves no tombstone in the walked shape and none of them here (tool.category, live as AIToolDefinition.category).

Coarse fallback — 30 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json f2ade4afb0efb5af694eec0c4f956ee7dd59d18a → packageMentionDocs.

Which tree this was computed on

This run read content/docs from 6d10ecf86c45836b43e1a0e63b64e19c41effd28 — the merge of head 3737254383df0ce1600acb8656922c5a2146c996 into base f2ade4afb0efb5af694eec0c4f956ee7dd59d18a, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin 6d10ecf86c45836b43e1a0e63b64e19c41effd28 && git checkout 6d10ecf86c45836b43e1a0e63b64e19c41effd28
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin f2ade4afb0efb5af694eec0c4f956ee7dd59d18a 3737254383df0ce1600acb8656922c5a2146c996 && git checkout -B drift-repro f2ade4afb0efb5af694eec0c4f956ee7dd59d18a && git merge --no-ff 3737254383df0ce1600acb8656922c5a2146c996

node scripts/docs-audit/affected-docs.mjs --json f2ade4afb0efb5af694eec0c4f956ee7dd59d18a

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs f2ade4afb0efb5af694eec0c4f956ee7dd59d18a → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@github-actions github-actions Bot added documentation Improvements or additions to documentation tests tooling labels Oct 22, 2026
@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

席位核对

ACCEPT · domain:cli seat 1 (seat post #6024) · os-sales · session session_01CxBKycaiUpA1yGx1XyoGqX · 2026-10-22T14:55Z · head 3737254383

item reading
Shape 8 files, +150 / −338 (diff read by the seat). SCAFFOLD_ALLOWED_PEER_VERSIONS becomes {}; the create-objectstack blank template drops its peerDependencyRules block in step (the byte-equality pin holds both); pins flip from presence to absence. Inside the widened claim 6341685199.
Premise, measured pnpm-lock.yaml resolves better-auth@1.7.12, @better-auth/utils@0.5.0, better-call@1.4.4 (seat read); the dev read better-auth@1.7.12 with no better-sqlite3 peer (control: 1.7.3 still declares ^12.0.0) and the four @better-auth/* packages peering utils ^0.4.2 || ^0.5.0.
Gates (check-runs on this head) 46 runs: 38 success, 8 skipped (opt-in harnesses, Dogfood push-only batteries, Console Pin Gate, Temporal, Build Docs), 0 failed. Locally: lint 0, cli unit 324/324 files, create-objectstack 18/18, both typechecks 0; a mutation leg re-adding the sqlite entry turns 7 cli tests red.
Changeset, read per sentence @objectstack/cli + create-objectstack patch. "no longer carries a peerDependencyRules.allowedVersions block" matches the template and renderer diff; "resolves the same lockfile" matches allowedVersions suppressing reports only; both objectstack init (a declared bin) and npx create-objectstack paths are named.
Accepted deviations Commit trailers follow AGENTS.md's model-free pair. The dispatch order named packages/cli/src/commands/init.test.ts; the real file is packages/cli/test/init.test.ts (the seat's error, corrected in the widened claim).
Out of scope The root pnpm-workspace.yaml comment the dev found stale is folded into this PR (widened claim). Nothing filed.
Landing Not governed: check-governed-merges.mjs --pr 25239 reads 0 of 8 paths on the register, 488 changed lines, under the threshold. Ready + auto-merge through the relay in this act.

Generated by Claude Code

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 22, 2026 15:01
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit 80ec71d Oct 22, 2026
47 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-25123-scaffold-peer-ledger branch October 22, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/m tests tooling

Projects

None yet

2 participants