Skip to content

chore(changeset): put the summary line first in six changesets - #26508

Closed
os-steve wants to merge 1 commit into
mainfrom
claude/project-thread-c4jd1i
Closed

os-steve wants to merge 1 commit into
mainfrom
claude/project-thread-c4jd1i

Conversation

@os-steve

Copy link
Copy Markdown
Collaborator

Requested by Steve · 18.2.0 release prep · project thread

Refs #26429

维护者速读

  • 改了什么:6 个 changeset 的正文把 Clause-②: / Metadata-protocol: 两行写在了最前面。这次把这两行挪到第一段之后,和 .changeset/ 里其余文件的写法一致。一个字都没改,只是调整顺序。
  • 为什么改:changesets 拿正文第一行当 CHANGELOG 的标题,所以这 6 条在 18.2.0 的 CHANGELOG 和 GitHub Release 里标题会显示成 "Clause-②: no"。另外,classifyReleaseBullet 不读标题行上的声明,所以 spec-form-object-name-shared 的 Clause-②: yes (widening) 被分到了「其他修复」,本该在「新增能力」。
  • 风险:只改 .changeset/,不改代码。
  • 回滚:revert 即可。

What changes

These six files have the declaration block moved below the first paragraph:

  • 25495-org-default-currency
  • 25576-admin-rescue-comment-i18n
  • 25611-inline-transform-null-sentinel
  • 25639-lockstep-exact-internal-deps
  • default-org-owner-currency
  • spec-form-object-name-shared

Each file keeps the same lines, and none is reworded.

Found by #26429's writer (see the os-dev-report on #26429, out_of_scope_findings).

Verification

Every .changeset/*.md on this head was parsed with @changesets/parse, and each summary was fed to classifyReleaseBullet as a CHANGELOG bullet:

  • Changesets whose summary line is a declaration: 6 on main (exactly the six above), 0 on this head.
  • spec-form-object-name-shared was other on main and is added on this head. The other five stay other, which their Clause-②: no / Metadata-protocol: none calls for.
  • Every file parses.

Check Changeset will be red here: this PR edits changesets that other PRs added (the foreign-changeset rule, #17712). That is deliberate. Check Changeset is not a required check, and the same thing happened on #26458. This PR is not labelled skip-changeset because it edits existing changesets.

Follow-up for #26494: spec-form-object-name-shared moves from 其他修复 to 新增能力 on the 18-2 page.

Clause-②: no
Metadata-protocol: none

Human Minimum

  • 1. Schemas start as Zod; packages/spec holds no runtime logic. (not touched)
  • 2. Every name I added uses the casing for its kind. (none)
  • 3. No formatter ran.
  • 4. One issue, one branch off an up-to-date main, one pull request.
  • 5. A change that publishes carries a changeset. This PR only edits existing changesets.
  • 6. packages/spec touched: n/a.
  • 7. No hand edits to content/docs/references/, packages/*/CHANGELOG.md or content/docs/releases/.
  • 8. Title, body and comments are in English (the 速读 block excepted, as on chore(deps): exempt GHSA-xcx6-jx8p-x3h5 (@azure/msal-node via tedious) until 2026-11-26 #26486).
  • The Before Submitting list in CONTRIBUTING.md is done.

Generated by Claude Code

Six changesets opened their body with the Clause-②/Metadata-protocol
declaration lines, so changesets used `Clause-②: no` as the CHANGELOG
headline and the 18.2.0 Release body inherited it. The release renderer
does not read a declaration on the summary line, so
spec-form-object-name-shared's `Clause-②: yes (widening)` also landed
under 其他修复 instead of 新增能力. The declarations now follow the
first paragraph, the way the rest of .changeset/ is written; no wording
changed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ADHkmPhbmyqwyDkSjg13F7
@github-actions github-actions Bot added size/s documentation Improvements or additions to documentation tooling labels Oct 27, 2026

Copy link
Copy Markdown
Collaborator Author

Check Changeset is red on purpose (#18375): this PR corrects pending release notes that other PRs added. Every .changeset row in the diff is CHANGED, none is added, so it carries no skip-changeset label and this check stays red. Check Changeset is not a required context.

The notes it corrects, and what changes under each:

  • 25495-org-default-currency, 25576-admin-rescue-comment-i18n, 25611-inline-transform-null-sentinel, 25639-lockstep-exact-internal-deps, default-org-owner-currency: the Clause-②: no / Metadata-protocol: none lines move below the first paragraph. Their CHANGELOG headline becomes that paragraph instead of Clause-②: no. They stay in 其他修复.
  • spec-form-object-name-shared: the same move. Its headline becomes the anonymousFormObjectName sentence, and its Clause-②: yes (widening) is now read, so it moves from 其他修复 to 新增能力.

Frontmatter (packages and levels) and wording are unchanged in all six. The rest of this job is green: no major bump, ADR-0087 registration sees 6 non-breaking changesets, and the level axis matches.


Generated by Claude Code

Copy link
Copy Markdown
Collaborator Author

Closing as moot. The Version Packages PR #25640 merged first (version commit 27f38ad), so it consumed all six changesets. Their Clause-②: no headlines are now in the 18.2.0 CHANGELOGs, and those are release-owned. The 18.2.0 publish runs from that version commit, so nothing on main can change those notes now.

What stops this from recurring is a check that refuses a changeset whose summary line is a declaration. That will be filed separately.


Generated by Claude Code

@os-steve os-steve closed this Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/s tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants