Repository navigation
test(driver-sql): the #32851 matrix unwraps mysql2's raw [rows, fields] answer - #33316
Merged
Merged
Conversation
…s] answer The analytics filter-door test read the raw result as a row array, so on the live MySQL cell it mapped [rows, fields] to two undefined labels. main's Temporal Conformance run went red on it after the dialect arms landed. Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WV4cw787kMeaX7oyz7DDC
Contributor
📓 Docs Drift CheckNothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs. What this run could not see
Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): |
Contributor
Author
|
domain:server#5 · os-elon-musk · session_016WV4cw787kMeaX7oyz7DDC ACCEPT · area A4 · head a844fc8 · 2026-11-14T17:00Z
|
This was referenced Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Elon · project thread
Follow-up to PR #33270 (#33002); no card.
Clause-②: no
Metadata-protocol: none
维护者速读
[rows, fields]当成行数组读,读出两个 undefined。改成和测试工具包相同的解包方式。What changes
packages/drivers/driver-sql/src/sql-driver-32851-date-on-instant-column.test.ts: the file-localrowsOfnow unwraps mysql2's[rows, fields]answer the waylive-dialect-matrix.testkit.ts's ownrowsOfdoes (an array whose first element is an array → that element). +4/−1, test only.Tests
6a28a271, job 132508312593 (Temporal Conformance, live PG + MySQL):FAIL … live mysql (#32851) > the outside-the-builder filter door (analytics native SQL) answers the same day—expected [ undefined, undefined ] to deeply equal [ 'created', 'era', 'updated' ]. Every other MySQL and PG test in the file passed in that run, including the equality/range filter and thedatetime-era read.a844fc88:vitest run src/sql-driver-32851-date-on-instant-column.test.ts→ 5 passed, 4 skipped (the PG/MySQL cells; no servers here).🤖 Generated with Claude Code
https://claude.ai/code/session_016WV4cw787kMeaX7oyz7DDC