Skip to content

test(driver-sql): the #32851 matrix unwraps mysql2's raw [rows, fields] answer - #33316

Merged
objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/area-A4-32851-mysql-rows
Nov 14, 2026
Merged

objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/area-A4-32851-mysql-rows

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Requested by Elon · project thread

Follow-up to PR #33270 (#33002); no card.

Clause-②: no
Metadata-protocol: none

维护者速读

What changes

packages/drivers/driver-sql/src/sql-driver-32851-date-on-instant-column.test.ts: the file-local rowsOf now unwraps mysql2's [rows, fields] answer the way live-dialect-matrix.testkit.ts's own rowsOf does (an array whose first element is an array → that element). +4/−1, test only.

Tests

  • main push run on 6a28a271, job 132508312593 (Temporal Conformance, live PG + MySQL): FAIL … live mysql (#32851) > the outside-the-builder filter door (analytics native SQL) answers the same day — expected [ undefined, undefined ] to deeply equal [ 'created', 'era', 'updated' ]. Every other MySQL and PG test in the file passed in that run, including the equality/range filter and the datetime-era read.
  • Local (SQLite cell) at a844fc88: vitest run src/sql-driver-32851-date-on-instant-column.test.ts → 5 passed, 4 skipped (the PG/MySQL cells; no servers here).
  • NOT MEASURED before merge: the MySQL cell. Temporal Conformance runs on push to main only, so the post-merge main run is the reading; I will check it.

🤖 Generated with Claude Code

https://claude.ai/code/session_016WV4cw787kMeaX7oyz7DDC

…s] answer

The analytics filter-door test read the raw result as a row array, so on
the live MySQL cell it mapped [rows, fields] to two undefined labels.
main's Temporal Conformance run went red on it after the dialect arms
landed.

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016WV4cw787kMeaX7oyz7DDC
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

Nothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs.

What this run could not see

Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 24f2f4014d0c9bbd43ec6928942fa44b21c1dff6 → packageMentionDocs.

@objectstack-fleet objectstack-fleet Bot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Nov 14, 2026
@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

domain:server#5 · os-elon-musk · session_016WV4cw787kMeaX7oyz7DDC

ACCEPT · area A4 · head a844fc8 · 2026-11-14T17:00Z

  • Self-review: PASS · test-only, +4/−1, Clause-② no. The file-local rowsOf now unwraps mysql2's [rows, fields] exactly as live-dialect-matrix.testkit.ts's rowsOf does; that shape is what main's Temporal Conformance run (job 132508312593) showed ([ undefined, undefined ]). SQLite cell green locally.
  • check-governed-merges --pr 33316: NOT governed. skip-changeset: the diff publishes nothing (test file only).
  • Checks green at this head (the earlier Check Changeset failure predates the label; its re-run after labeled is the current one).
  • The MySQL cell itself is read on main's next push run after this lands.
  • Ready + auto-merge under the maintainer's 15:21Z go for area A4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs skip-changeset PR has no user-facing published change; bypasses the changeset gate tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants