Skip to content

test(dogfood): take the admin search terms from rows the stock admin is served #33449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
objectstack-fleet merged 1 commit into from
Nov 14, 2026
+13 −3
Merged

test(dogfood): take the admin search terms from rows the stock admin is served #33449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions packages/qa/dogfood/test/audit-log-admin-search.dogfood.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,14 @@ describe('[#21154] the stock admin searches the ledger and the activity stream w
let stack: VerifyStack;
let ql: any;
let adminToken = '';
/** A term each table's own rows contain, read at rest under the system context. */
/**
* A term each table's own rows contain, read from a row the stock admin is
* served through the same data door, newest first (#33429). Read at rest
* under the system context, an unsorted first row varied between boots, and
* one boot row (the MCP endpoint's `sys_oauth_resource` registration) is
* about an object the data API does not expose, so the activity read gate
* serves it to no one: a term taken from it matched nothing the admin reads.
*/
const term: Record<'sys_audit_log' | 'sys_activity', string> = { sys_audit_log: '', sys_activity: '' };

const list = async (path: string): Promise<Answer> => {
Expand All @@ -61,14 +68,17 @@ describe('[#21154] the stock admin searches the ledger and the activity stream w
});
adminToken = await stack.signIn();
ql = await stack.kernel.getServiceAsync('objectql');
const newest = { sys_audit_log: 'created_at desc', sys_activity: 'timestamp desc' } as const;
for (const table of Object.keys(term) as Array<keyof typeof term>) {
const rows: Row[] = await ql.find(table, { limit: 1, context: SYS.context });
const res = await stack.apiAs(adminToken, 'GET', `/data/${table}?$orderby=${encodeURIComponent(newest[table])}&$top=1`);
const json: any = await res.json().catch(() => undefined);
const rows: Row[] = json?.records ?? json?.data ?? [];
term[table] = String(rows[0]?.object_name ?? '');
}

await assertArmed([
armedWhen({
control: 'the boot wrote ledger and activity rows, and each carries a term its own search can match',
control: 'the boot wrote ledger and activity rows the stock admin is served, and each carries a term its own search can match',
disarmedBy: 'an empty table would answer every search with no rows, and an answered search would prove nothing',
observe: async () => ({ ledger: term.sys_audit_log, activity: term.sys_activity }),
armed: (o) => o.ledger.length > 0 && o.activity.length > 0,
Expand Down
Loading