Repository navigation
fix(objectql): the security-catalog name-conflict refusals say a permission set holds one name per namespace - #33463
objectstack-fleet[bot] wants to merge 1 commit into
Conversation
…ission set holds one name per namespace The hot-install and cold-boot texts of SecurityCatalogNameConflictError said positions, permission sets and capabilities each hold one name per deployment. Since ADR-0150 D2/D9 a permission set holds one name per namespace; both texts now state that rule in the words of the permission set name describe. Text only: the doors and permissionSetHoldersMeet are unchanged. Claude-Session: https://claude.ai/code/session_016WV4cyrFFk86Jqf7Mp5Rzw Co-authored-by: Claude <noreply@anthropic.com>
📓 Docs Drift Check3 anchor(s) derived from 1 changed package(s); no hand-written page names any of them, so this run has nothing to list — not a clean bill of health. This check sees only pages that NAME a derived anchor: one that documents this change in prose, or enumerates it in an authoring dialect, names none and stays invisible to it on every run. What this run could not see
Coarse fallback — 21 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): Which tree this was computed onThis run read A worktree cut from an older # while this PR is open — GitHub drops the merge commit once it closes
git fetch origin 88339c9efa26f679734de0de02d41a2b7f1c90aa && git checkout 88339c9efa26f679734de0de02d41a2b7f1c90aa
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 0c2aeb9643b91ff7d53c6e745371cfe59a5e0a26 2a6c935f7e18190b2dfadc580419952df0893af9 && git checkout -B drift-repro 0c2aeb9643b91ff7d53c6e745371cfe59a5e0a26 && git merge --no-ff 2a6c935f7e18190b2dfadc580419952df0893af9
node scripts/docs-audit/affected-docs.mjs --json 0c2aeb9643b91ff7d53c6e745371cfe59a5e0a26 |
|
domain:server#5 · os-elon-musk · session_016WV4cyrFFk86Jqf7Mp5Rzw |
Requested by Elon · project thread
Fixes #33389
Clause-②: no
Metadata-protocol: none
维护者速读
SecurityCatalogNameConflictError的两段报错文字(热安装与冷启动)不再说「岗位、权限集、能力每个部署一个名字」,改成「岗位和能力每个部署一个名字,权限集每个命名空间一个持有者」,并列出仍只有一个持有者的情形;措辞与 docs(spec): the permission set name describe and the permission sets page say one holder per namespace #33384 落地的 describe 一致。permissionSetHoldersMeet判定相遇时触发,没有错。NAMESPACE_CONFLICT)或状态码(422);@objectstack/objectqlpatch changeset。回滚即 revert。packages/objectql/src/registry.ts新增的SECURITY_CATALOG_NAME_RULE常量,以及它在coldBootConflictMessage与SecurityCatalogNameConflictError构造函数里的两处引用。grep -n "A permission set holds one name per" packages/objectql/src/registry.ts,预期恰命中常量一行;grep -n "Positions, permission sets and capabilities each" packages/objectql/src/registry.ts预期零命中。What changes
packages/objectql/src/registry.ts:SECURITY_CATALOG_NAME_RULE, the one rule sentence both wordings ofSecurityCatalogNameConflictErrorstate: "Positions and capabilities each hold one name per deployment. A permission set holds one name per namespace: packages of two namespaces may each hold a set of one name, while two packages of one namespace, a package with no namespace, a platform package (base,system,sys), the environment and the platform-requestedguest_portalshare one set of it." This is the holder list of the permission setnamedescribe that docs(spec): the permission set name describe and the permission sets page say one holder per namespace #33384 landed (packages/spec/src/security/permission.zod.ts), in the same words.coldBootConflictMessage(the cold-boot refusal): FROM "Positions, permission sets and capabilities each hold one name per deployment: an assignment names a position or a permission set by its bare name, so with two holders the environment's stored item would be served in place of the package's definition." TO the rule sentence, then "Under that rule the environment's item and the package's share one definition of the name, so with two holders the environment's stored item would be served in place of the package's definition."SecurityCatalogNameConflictErrorconstructor: FROM "Positions, permission sets and capabilities each hold one name per deployment: an assignment names a position or a permission set by its bare name, with no package to tell two definitions apart, so with two holders which definition grants would depend on registration order." TO the rule sentence, then "Under that rule PACKAGE and each holder named here share one definition of the name, with nothing to tell two definitions of it apart, so with two holders which definition grants would depend on registration order."SchemaRegistry.registerItemthat explains why the three security catalog types are refused ("an assignment names a position or a permission set with no package context") now says a position or a capability is named with no package context and a permission set's name has one holder per namespace (ADR-0150 D2/D9,permissionSetHoldersMeet)..changeset/33389-security-catalog-conflict-text.md:@objectstack/objectqlpatch.No rule changes. The doors,
permissionSetHoldersMeetand the envelope (NAMESPACE_CONFLICT,422) are untouched; the head and the remedy of each message are unchanged.Tests
No test pinned the old sentence:
git grepon0c2aeb9643for "Positions, permission sets and capabilities", "assignment names a", "no package to tell" and "served in place of the package" found onlyregistry.tsitself, a docs page, an ADR, a migration entry and comments (listed under Acceptance notes); no assertion in objectql, runtime, plugin-security, cloud-connection, metadata-protocol or dogfood reads either sentence. No new pin is added: the refusal prose has no consumer that parses it, and the existing suites already assert the envelope (codeandstatus) and the holders. Local readings at2a6c935f7e, underos-verify-lock:vitest runonregistry-security-catalog-namespace,protocol-permission-set-name-registry-reading,registry-security-catalog-names-held-by,manifest-service-residual-security-sealandenvironment-overlay-five-types: 5 files, 103 tests passed. objectql typecheck, includingcheck:test-typecheck: OK.protocol-boot-hydration-scoped,package-scoped-exact-qualifierandregistry-namespace-install-gate: 3 files, 314 tests passed.--no-inline-configonregistry.ts: exit 0.Acceptance notes
Other places that say a permission set holds one name per deployment, read on
0c2aeb9643and left alone, each for the reason given:packages/metadata-protocol/src/protocol-save-door-refusals.ts(the save door'sSecurity catalog name conflictrefusal): already says "A permission set holds one name per namespace" with the same holder list. Nothing to change.packages/spec/src/migrations/entries/semantic/18.security-catalog-environment-overlay-refused.ts(reason: "Positions, permission sets and capabilities hold one name per deployment"): an ADR-0087 migration entry describing a v18 change, inpackages/spec, outside this lane. docs(spec): the permission set name describe and the permission sets page say one holder per namespace #33384 raised it as an open question.packages/spec/src/kernel/customization-package.ts:252(theadr_0146_d6_security_catalogbasis): describes ADR-0146 D6 as written.packages/objectql/src/security-catalog-namespace.tsmodule header: its first section states the original rule and its own "The narrowing: a permission set is one name per namespace" section already states the ADR-0150 narrowing.packages/objectql/src/protocol-boot-hydration-scoped.test.ts:217,packages/qa/dogfood/test/showcase-security.ts:32,packages/qa/dogfood/test/showcase-d7-default-profile.dogfood.test.ts:65.content/docs/permissions/delegated-administration.mdx:69("an assignment names a position or set, and the gate resolves the name in the security catalog"): a description of the delegated-admin gate, not of the holder rule.Verification
Derived gates at
2a6c935f7e:dispatch-gates --commandsgave 65 families. 64 exited 0.check:dual-build-cjs-loadsexited 3, a prerequisite not met because only the objectql closure was built, so it is NOT MEASURED; CI Build Core covers it.dispatch-gates --ranreconciles 65 of 65. The CI check-runs on this pull are the authority for every gate family.Generated by Claude Code