Repository navigation
Conversation
…the budget file Claude-Session: https://claude.ai/code/session_01JQwxbYzM6act7DgRZuPrxu Co-authored-by: Claude <noreply@anthropic.com>
… AGENTS.md budget sentence Claude-Session: https://claude.ai/code/session_01JQwxbYzM6act7DgRZuPrxu Co-authored-by: Claude <noreply@anthropic.com>
…name the wait column precisely Claude-Session: https://claude.ai/code/session_01JQwxbYzM6act7DgRZuPrxu Co-authored-by: Claude <noreply@anthropic.com>
… AGENTS.md sentence to two lines Claude-Session: https://claude.ai/code/session_01JQwxbYzM6act7DgRZuPrxu Co-authored-by: Claude <noreply@anthropic.com>
…h is also its discovered check family Claude-Session: https://claude.ai/code/session_01JQwxbYzM6act7DgRZuPrxu Co-authored-by: Claude <noreply@anthropic.com>
…e budget Claude-Session: https://claude.ai/code/session_01JQwxbYzM6act7DgRZuPrxu Co-authored-by: Claude <noreply@anthropic.com>
…docs/agents/build-and-test.md AGENTS.md returns byte-identical to the merge base; the explanation lives on the Build & Test companion page. Claude-Session: https://claude.ai/code/session_01JQwxbYzM6act7DgRZuPrxu Co-authored-by: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Warren · project thread
Fixes #35322
Clause-②: no
Metadata-protocol: none
Rule-change: ruled
Ruling-ref: Source: maintainer — Warren, 2026-11-19, review-split discussion thread: 03:16Z 「以上都同意」 (CI speed budget for objectstack; 「变慢两成非常大了」 rejected a 20% allowance); 04:24Z 「1+2+4」, point 2 as amended by the review: budget = median 22 min, alarm = p90 32 min, measured weekly by a script that files a speed-up card when over; a PR's own before/after reading is advisory and never blocks a merge.
维护者速读
What changes
scripts/ci/queue-duration.mjs(new, read-only against GitHub). Lists everymerge_grouprun created in the window (--since 7d|24h|ISO,--until), groups by head SHA, and for each SHA whose every queue-workflow run concluded green measures the first run'screated_atto the last run'supdated_at(waiting for runners and re-runs included). Prints p50 / p90 / max (nearest rank), the SHA counts (green, red, cancelled, still running), the queue failure rate (SHAs with a red run over completed SHAs), which workflow finished last, and the five slowest jobs of that critical run over an evenly spaced sample of 40 green SHAs.--repo,--json,--render FILE,--via gh(a seat whose egress onlyghreaches). Exit 2 = NOT MEASURED: a window that cannot be listed whole is split in halves down to one hour and then refused, never truncated; a sample under the budget's floor is not judged.scripts/ci/queue-budget.json(new):budgetMedianMinutes: 22,alarmP90Minutes: 32,minSample: 20, the baseline with its window, and the five queue workflows (CI,Governed Surface Guard,Lint & Type Check,PR-Body Guards,Spec Liveness Check, the five files with amerge_group:trigger). Itsnoteand the script header say changing a number is the maintainer's call. Amerge_groupworkflow not on the list is warned about in the reading, never silently folded in..github/workflows/queue-duration-budget.yml(new). Weekly, Monday 07:09 UTC, plusworkflow_dispatch, plus apull_requesttrigger paths-filtered to its own three files. Jobmeasure(actions: read,contents: read, 20 min): self-tests the module, reads objectstack, reads hotcrm report-only (continue-on-error, no card), writes both readings to the run summary, keeps them as an artifact, and reds only on NOT MEASURED (the patrol reporting its own death). Jobfile(contents: read,issues: write, 10 min) runs only when the verdict isover, the event is notpull_requestand the ref ismain; it callsfileQueueCard: one card, fixed titlemerge queue over its speed budgetplus the plain-text body markeros-queue-duration-budget, a bounded open-issue scan that refuses rather than files when it cannot establish absence, the oldest match refreshed in place, labelstooling,area:fleet,domain:devx,priority:p2,pm:queueand issue type Task on create only (the type is its own write, so a refused type costs the type, never the card).fleet-patrols.yml: that file'spull_request:paths list is frozen as a set byscripts/check-platform-checklist-watchdog.mjs, and apull_requestrun there exercises every job. Exercising this reading on its own PRs would mean widening the frozen list and editing the pin and its self-test, and every PR touching a sibling patrol's input would then also spend a live queue reading. A separate file leaves the pin untouched and scopes the PR run to this reading. Nomerge_group:and nopull_request_target:trigger; not a required context..github/workflows/lint.yml: onerun_self_testline in the existing "Moved workflow step bodies self-test" collector, soLint & Repo Gatesruns the new self-test on every PR.AGENTS.mdBuild & Test: two lines stating the budget file, the weekly read, the one speed-up card, and that a CI-changing PR reports its job's before/after median as advisory.Why
The maintainer set a CI speed budget for objectstack (Ruling-ref above). Nothing watched the queue's duration trend, so a slower queue was noticed by nobody. A PR's own before/after reading stays advisory: a gate grading a duration reports and never reds a required job (AGENTS.md Build & Test).
Verification
All readings below are against
objectstack-ai/objectstack; script at branch commitsfe60502e..1397a8ab(the measuring code unchanged across them),origin/mainata998964dwhen the readings were taken.Self-test: 53 assertions, 8 floored batteries
node scripts/ci/queue-duration.mjs --self-teston head1397a8ab:Batteries: percentile and window parsing (6) · grouping by head SHA (9) · verdict, each threshold alone, sample floor, report-only (6) · listing: the adaptive split, cross-slice de-dup, a failed page fails the listing (5) · critical-run jobs (4) · budget file, the tracked file plus six malformed shapes (7) · the card (10, including the de-dup proof: a second run sees the first run's card, refreshes it and never files a second) · rendering (6). Roster, battery floor and verdict handshake per AGENTS.md "Writing a --self-test".
Live dry run, last 7 days: p50 21.9 · p90 31.9 · max 55.6 min, WITHIN
node scripts/ci/queue-duration.mjs --via gh --since 7d, window2026-11-12T04:42:36Z .. 2026-11-19T04:42:36Z, 165 API reads:Against the card's baseline window (
--since 2026-11-17T00:00:00Z, to 2026-11-19T04:39Z): p50 21.6 · p90 31.5 · max 51.3 min over 456 all-green SHAs, against the baseline's 21.7 / 31.9 / 34.5 over 176. The percentiles land within half a minute. The sample size and the max differ, and the baseline's record does not say why its count is 176; this reading counts every all-green SHA in the window, re-runs included by design, and its max is a single SHA.hotcrm, report-only
--repo objectstack-ai/hotcrm --since 7d: 46 runs (CI only) · 45 all-green · 1 red · p50 24.1 · p90 40 · max 41.8 min; slowest jobCI / Build and Test (22.x)24.1 min. Printed to the run summary only; no card, never judged against the budget.Local gates
Derived with
node scripts/pm/dispatch-gates.mjs --commands(59 commands; treeobjectstack-ai/objectstack). On the final head1397a8ab: 57 of the 59 run directly, 56 exit 0, 1 exit 1 (below);pnpm check:pm-dispatch-gatesis the 58th;pnpm check:type-check-debtis NOT MEASURED.dispatch-gates --ranwith every exit code recorded:59 derived famil(ies) accounted for — 58 run, 1 NOT-MEASURED.pnpm check:pm-dispatch-gates(fast tier, 2249 cases) green on5b3f27f4. Its first run, on an earlier head, caught two things this PR then fixed: the new paths-filtered workflow discovered no check family (now themeasurejob's self-test step is its family), and ano-check-familiesmarker would have broken the marker census.pnpm check:workflow-status-functionscaught thefilejob'sif:readingneeds.*.outputs.*with no status function; it is now!cancelled() && ....pnpm check:pm-skill-ratchet—AGENTS.md is 1052 lines; the ratchet ceiling is 1050. The two lines are the card's item 4. Raising theCEILINGSrow needs the ruling comment id that orders the text, and this card's ruling lives in a discussion thread with no GitHub comment id, so the row is left at 1050. Both lines fit the 120-byte line budget.pnpm check:type-check-debt: NOT MEASURED locally (timed out at 300 s on the shared box); the diff touches no package. CI runs it.pnpm lint,test:repo, the type-check lanes.workflow_dispatch: NOT MEASURED — a dispatch only runs a workflow that is on the default branch. This PR's ownpull_requestrun exercises themeasurejob live and writes nothing.Acceptance notes
files[](scripts/ci/**,.github/workflows/**,AGENTS.md), so the PR wants theskip-changesetlabel, which this session could not write.overweek. A week back within budget writes nothing, so an open speed-up card is closed by the seat that lands the speed-up, not by this workflow.created_attostarted_at) reads 0 minutes across the sample, so that column does not capture runner waiting on this repository; the waiting is inside each SHA's first-start-to-last-end span, which is what the budget grades.Human Minimum
packages/specholds no runtime logic. (not touched)pnpm lintpasses. (no formatter ran;pnpm lintleft to CI)main, one pull request.skip-changeset)packages/spectouched: its generated artifacts are regenerated and committed. (not touched)content/docs/references/,packages/*/CHANGELOG.mdorcontent/docs/releases/.Generated by Claude Code