Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/dev/openfeature/sdk/Value.java
Original file line number Diff line number Diff line change
Expand Up @@ -295,8 +295,8 @@ protected Value clone() {
return new Value(new ImmutableStructure(this.asStructure().asUnmodifiableMap()));
}
if (this.isInstant()) {
Instant copy = Instant.ofEpochMilli(this.asInstant().toEpochMilli());
return new Value(copy);
// Instant is immutable, so the same instance is safe to share and keeps its full precision.
return new Value(this.asInstant());
}
return new Value(this.asObject());
}
Expand Down
13 changes: 13 additions & 0 deletions src/test/java/dev/openfeature/sdk/ImmutableStructureTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,22 @@
assertEquals(now, structure.getValue(KEY).asInstant());
}

@Test
void getValueShouldPreserveInstantPrecision() {
String KEY = "key";
Instant instant = Instant.ofEpochSecond(1_700_000_000L, 123_456_789L);
Map<String, Value> map = new HashMap<>();
map.put(KEY, new Value(instant));
ImmutableStructure structure = new ImmutableStructure(map);

assertEquals(instant, structure.getValue(KEY).asInstant());
assertEquals(instant, structure.asMap().get(KEY).asInstant());
assertEquals(instant, structure.asObjectMap().get(KEY));
}

@Test
void MutatingGetStructureValueShouldNotChangeOriginalValue() {
String KEY = "key";

Check warning on line 91 in src/test/java/dev/openfeature/sdk/ImmutableStructureTest.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'.

See more on https://sonarcloud.io/project/issues?id=open-feature_java-sdk&issues=AaGlRlAz-Lu4Ca1P_AkL&open=AaGlRlAz-Lu4Ca1P_AkL&pullRequest=2071
List<Value> lists = new ArrayList<>();
lists.add(new Value("dummy_list_1"));
MutableStructure mutableStructure =
Expand Down
Loading