Repository navigation
opentelemetry-sdk: preserve metric instrument name casing - #5881
Open
mertefesensoy wants to merge 3 commits into
Open
mertefesensoy wants to merge 3 commits into
mertefesensoy wants to merge 3 commits into
Conversation
Fixes open-telemetry#3207. Preserve the first registered spelling while keeping registration, View selection, and conflict detection case-insensitive. Assisted-by: Codex (GPT-6) Signed-off-by: MERT EFE ŞENSOY <sensoymertefe@gmail.com>
|
|
Pull request dashboard statusWaiting on reviewers · refreshed 2026-11-03 17:35 UTC Review the latest changes. Status above doesn't look right?
|
The changelog check requires .changelog/<PR_NUMBER>.<type>; the fragment was named after issue open-telemetry#3207. Assisted-by: Claude Code (claude-opus-5-5) Signed-off-by: MERT EFE ŞENSOY <sensoymertefe@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preserves names such as
RequestCountin collected and OTLP-encoded metrics. On main, the same input becomesrequestcountfor all seven instrument kinds; the local before/after probe verifies the original spelling after this change.Fixes #3207, following the agreed direction to stop lowercasing names.
Registration still treats names case-insensitively and returns the first spelling. View selection and conflict detection compare names case-insensitively too. Registering another spelling emits the warning required by the SDK name-conflict rule.
Existing queries that depend on lowercase metric names may need updating. The changelog filename is a placeholder for now until this draft PR receives its number.
Type of change
Validation
Codex ran the new tests on unchanged main: 22 failed, 5 passed.
I ran these on Windows (Python 3.13.14) with this change:
Checklist:
tox -e precommittox -e typecheckAI-assisted with Codex. Validation commands and results are recorded above.