Repository navigation
fix(mobile): restore mobile architecture check and HarmonyOS test harness - #3881
Merged
Merged
Conversation
…ness - pnpm run mobile:architecture failed on main: the shared JVM client build contract test reached into the HarmonyOS tree, and RemoteSession exposed public default arguments. Move the cross-platform build contract to scripts/mobile-client-build.contract.test.mjs and replace the defaults with explicit constructors. - Update HarmonyOS harness tests for MessageQueueStore and the sidebar footer, drop the removed derivePasswordHash call from the ohosTest target, and stop the local unit test from swallowing unexpected errors or touching HUKS.
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore
pnpm run mobile:architectureand the HarmonyOS test harness, both failing onmain.mobile:architecturefailed two rules: the shared JVMClientBuildContractTest.ktreached into the HarmonyOS tree (sharedReachesPlatformTrees), andRemoteSessionincore-domainexposed public default arguments (defaultArgsInFeatureApi). The cross-platform build contract moves toscripts/mobile-client-build.contract.test.mjs(run bymobile:architecture), andRemoteSessiongets explicit overload constructors.MessageQueueStore/supportsMessageQueueand the sidebar footer move: onmain,session-recordfails 14,session-model-hydration5,interaction-mailbox2,workspace-editor1.NativeCryptoLoad.test.etscalled the removedCloudAccountCrypto.derivePasswordHash, so the ohosTest target did not compile;TransportAndGeneralChatUnit.test.etsreached HUKS through watch provisioning and swallowed unexpected errors.Type and Areas
Type: bug fix (tests / checks)
Areas: mobile shared KMP, HarmonyOS tests, repository scripts
Motivation / Impact
No direct user-facing change. Restores the mobile architecture gate and HarmonyOS test signal.
Verification
pnpm run mobile:architecture: exits 1 onmain, passes with this changenode --test scripts/mobile-client-build.contract.test.mjs(2 passed)node --test src/apps/mobile/harmonyos/tools/tests/{session-record,session-model-hydration,interaction-mailbox,workspace-editor}.test.cjs: all pass (27/5/14/16)./gradlew :core-domain:jvmTest :core-feature:jvmTest :core-transport:jvmTest:SessionListPolicyTest,RemoteResponseMapperTestpass.etschanges were not compiled locally (no DevEco toolchain here).Reviewer Notes
AI-assisted change, lightly tested as listed above.
Checklist