[dpiet-oai]

Changes being requested

Remove three tests in TestAsyncOpenAI that use the synchronous OpenAI fixture and repeat the corresponding TestOpenAI assertions for extra JSON, headers, and query parameters. Correct the standard and custom HTTP client inputs in both no-trailing-slash tests so they actually exercise base URLs without a trailing slash.

Additional context & links

• Full changed file: 292 passed, 2 skipped; Ruff lint and format checks passed.
• Focused selection: 14 cases before, 11 after. Three sequential local runs per revision on Python 3.10 with one pytest process had median wall time of 2.96 s before and 3.05 s after; the timing does not demonstrate a speedup.

[github-actions]

Castiron custom code

Evaluated main: a93b62c2638d41031a661d3ed9c2155860ccb9b3.

Trusted main policy: a93b62c2638d41031a661d3ed9c2155860ccb9b3.

✅ No new custom-code files detected.

0 mixed files remain; 0 existing customizations changed.

Compared 43045fcaf91a → d92a22cb2272. Generated baselines verified.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 40371849316 --repo openai/openai-python \
  --name castiron-custom-code-40371849316-1 --dir /tmp/castiron-custom-code-40371849316-1
git apply --stat /tmp/castiron-custom-code-40371849316-1/custom-code.patch
cat /tmp/castiron-custom-code-40371849316-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin a93b62c2638d41031a661d3ed9c2155860ccb9b3 d92a22cb2272d4aac80a0d6cfa41ac7152e08d74
python3 scripts/castiron/custom_code_report.py report \
  --base a93b62c2638d41031a661d3ed9c2155860ccb9b3 \
  --head d92a22cb2272d4aac80a0d6cfa41ac7152e08d74 --target-branch main --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-d92a22cb2272
cat /tmp/castiron-custom-code-d92a22cb2272/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

[marcuswood-oai]

LGTM 👍 No changes requested.

---

Reviewed: d92a22c · Base: 43045fc · sdk-pr-review

[markstuart-oai]

Reviewed d92a22cb2272d4aac80a0d6cfa41ac7152e08d74. No blocking findings. The three removed tests duplicate retained synchronous client coverage. The corrected inputs now exercise base URLs without a trailing slash for both synchronous and asynchronous clients, including custom HTTP clients.

Source-only review; I did not run candidate code or tests. Hosted checks: 22 successful and 13 skipped.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-26T17:47:07.992797Z	d92a22c	Draft marked ready
🔒 Security Review	✅ Completed 2026-10-26T17:48:29.490696Z	d92a22c	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.