Repository navigation
Conversation
Castiron custom codeEvaluated main: Trusted main policy: ✅ No new custom-code files detected. 0 mixed files remain; 0 existing customizations changed. Compared A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 40029439510 --repo openai/openai-python \
--name castiron-custom-code-40029439510-1 --dir /tmp/castiron-custom-code-40029439510-1
git apply --stat /tmp/castiron-custom-code-40029439510-1/custom-code.patch
cat /tmp/castiron-custom-code-40029439510-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 43045fcaf91aec08571e54c57706597cefd32d45 8844c138e045a490cec5277a31444912d16a6fd4
python3 scripts/castiron/custom_code_report.py report \
--base 43045fcaf91aec08571e54c57706597cefd32d45 \
--head 8844c138e045a490cec5277a31444912d16a6fd4 --target-branch main --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-8844c138e045
cat /tmp/castiron-custom-code-8844c138e045/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed 8844c138e045a490cec5277a31444912d16a6fd4. No blocking findings. All six sync/async scenarios keep their segment and closure assertions. Each scenario gets a fresh transcript and event loop, failures remain visible, and the parent still bounds a hung child.
Source-only review; I did not run candidate code or tests. Hosted checks: 13 skipped, 22 success.
Changes being requested
Run the three fractional source-deadline regressions in one child interpreter per sync/async mode, reducing interpreter launches from six to two. Each scenario gets a fresh transcript and event loop; scenario labels and tracebacks remain visible, and the parent retains a five-second timeout.
Additional context & links
DEFER_PYDANTIC_BUILD=false, serial pytest, three runs per revision: median process wall 10.72s → 6.62s; median summed test-call time 8.63s → 3.89s. Local cache conditions do not measure CI gate latency or billed runner time.PYTHONPATHbecause this host setsPYTHONSAFEPATH=1. Injected failure continued through later scenarios; injected hang reported the scenario and stopped after 5.02s.