Repository navigation
fix(html): keep a generic font family a keyword - #1271
Merged
Merged
Conversation
translate_font_family quoted a bare name and added its kind, so the monospace that Markdown names its code with became the font 'monospace',sans-serif, which no one has: every code span and block of a Markdown file showed in the text font. A generic family is now written as it is. Found in the website with the core of main: sample.md showed its code in the proportional font. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017QtawyvLP2SCnoBtnVfFed
andiwand
force-pushed
the
fix/generic-font-family
branch
from
October 25, 2026 10:08
708a065 to
df33763
Compare
This was referenced Oct 25, 2026
andiwand
added a commit
that referenced
this pull request
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
translate_font_familyquotes a bare font name and adds its kind, as the unreleased CHANGELOG says. It did that to a generic family too. So themonospacethat Markdown names its code with became'monospace',sans-serif, a font no one has. Every code span and code block of a Markdown file showed in the text font.A generic family (
serif,sans-serif,monospace, …) is now written as it is.Found while testing the website with the core of
mainplus #1270:sample.mdshowedinline codeand its fenced block in the proportional font. 7.5.2 showed them monospace.Reference output. Three pages change, each only in that
font-family:md/feature-matrix.md:'monospace',sans-serifbecomesmonospace.odt/style-java+paste-1.odt(private):'Monospace',sans-serifbecomesMonospace. That pasted Java code is monospace again too.odt/style+charset-wikipedia-1.odt(private):'sans-serif',sans-serifbecomessans-serif.I regenerate the references once, after this and #1270 land.
Tests. gtest
font_family_keeps_a_generic_family_a_keyword. The full suite passes (2542).Review fixes
is_generic_font_familyignores case, as the CSS generic keywords do, so the unquotedMonospaceof the private odt is the keyword too. A list that ends in a generic family still takes the list path.md/feature-matrix.md: its 7 code rules statefont-family:monospace.