Repository navigation
Search with the page's own search - #734
Merged
Merged
Conversation
andiwand
force-pushed
the
fix/732-page-search
branch
from
October 25, 2026 13:05
a0a4241 to
f7f789d
Compare
Core 7.6 turns on lazy layout. The browser does not lay out a line, a page, a row or a slide far from the viewport, and the find of the WebView does not search them. So find missed hits in a long document, and its count was too low. - FindActionModeCallback calls odr.search, odr.searchNext and odr.searchPrevious through PageView. The page searches every chunk. - PageView forwards the searchChange message of the host bridge to a SearchListener. The find bar shows its count and its current hit. - LargeTextTests counts the needles with the page search too. Fixes #732 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JuNa2W75khbpynkiG9iDqF
andiwand
force-pushed
the
fix/732-page-search
branch
from
October 25, 2026 13:22
f7f789d to
1ab6bb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Fixes #732. Stacked on #733.
Core 7.6 turns on lazy layout. The browser does not lay out a line, a page, a row or a slide far from the viewport, and the find of the WebView does not search them. So find missed hits in a long document, and its count was too low.
Changes
FindActionModeCallbackcallsodr.search,odr.searchNextandodr.searchPreviousthroughPageView. The page searches every chunk, and folds case and diacritics (cafefindsCafé).PageViewforwards thesearchChangemessage of the host bridge to aSearchListener. The find bar showscurrent + 1/countfrom it.odr.resetSearch.LargeTextTestscounts the needles with the page search.Testing (Pixel_6_Pro emulator, Android 12, WebView Chrome 91)
LargeTextTestspasses (1 MB of text).Zébrafinchon line 29,991. On Chrome 91, the screen does not move to that hit, because a hidden chunk is 0 px tall. Core #1277 (7.6.1) fixes this. I checked that fix in this WebView: the hit is then on screen.karimakifinds 8 hits (1/8), and a step back to 8/8 shows the hit on page 208.odr.searchruns out of memory in the renderer on this emulator. Core #1277 fixes it (+218 MB and 7 s on the emulator, measured with its search.js).