Repository navigation
Say why an encrypted file that the core cannot decrypt does not open - #737
Merged
Merged
Conversation
andiwand
force-pushed
the
fix/724-undecryptable-message
branch
from
October 25, 2026 13:05
b1de672 to
fde77f0
Compare
andiwand
force-pushed
the
fix/724-undecryptable-message
branch
from
October 25, 2026 13:23
fde77f0 to
89036a0
Compare
If the core cannot decrypt a file, the app showed only "This document is password-protected". The app shows no password field for such a file, because no password opens it. A user looked for the field and reported it as missing (#724). The bar now says that the app cannot open this protection, and tells the user to open the file in another app. The OK button of the bar already hands the file to another app. The password dialog keeps the old title. A new device test opens the encrypted .doc fixture and checks the message. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JuNa2W75khbpynkiG9iDqF
andiwand
force-pushed
the
fix/724-undecryptable-message
branch
from
October 25, 2026 13:36
89036a0 to
6c6ee86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Fixes #724. Stacked on #733.
If the core cannot decrypt a file (
UndecryptableFile), the app showed "This document is password-protected" with no password field. The snackbar already offers to open the file in another app.Changes
toast_error_cannot_decrypt: "This document is protected in a way that this app cannot open. Try opening it in another app." The password dialog keepstoast_error_password_protected.MainActivityTests.testUndecryptableDocOffersAnotherAppopensencrypted.docand checks the message.Testing
spotlessCheck assembleProDebug assembleLiteDebug testProDebugUnitTest lintProDebugpass (against core 7.6.0 locally, because 7.6.1 is not on Maven Central yet).MainActivityTests#testUndecryptableDocOffersAnotherApppasses on the emulator (Android 12), and fails without the fix.🤖 Generated with Claude Code
Fixes #724. Stacked on #733.
If the core cannot decrypt a file (
UndecryptableFile), the app showed "This document is password-protected" with no password field. The snackbar already offers to open the file in another app.Changes
toast_error_cannot_decrypt: "This document is protected in a way that this app cannot open. Try opening it in another app." The password dialog keepstoast_error_password_protected.MainActivityTests.testUndecryptableDocOffersAnotherAppopensencrypted.docand checks the message.Testing
spotlessApply assembleProDebug assembleLiteDebug testProDebugUnitTest lintProDebug compileProDebugAndroidTestKotlinpass.