Repository navigation
Always show the yearly pass, with shorter texts - #747
Merged
Merged
Conversation
The pass dialog hid its subscribe button until Play gave a price. So without Play, it offered only the Pro app. The button now shows from the start and takes the price when Play gives one. A tap without loaded details asks Play again, and tells the user if Play is not available. The gate and pass texts are shorter and state facts. The changed gate texts lose their translations. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FW6WZZn7M3KF61bkS7BinV
The Pro app was a text link under the subscribe button, so it did not look like a second offer. It is now an outlined button with a shorter label. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FW6WZZn7M3KF61bkS7BinV
"Without tracking" was not true for the free version, because its ads can track. The text now says that the app does not track, and that the purchase removes the ads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FW6WZZn7M3KF61bkS7BinV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lite hid the subscribe button of the pass dialog until Play gave a price. Without Play (no Google account, an old Play, a setup error), the dialog offered only the Pro app. The texts of the dialog and of the Pro gate were also long.
Changes
dialog_pass.xml: the subscribe button and the renewal terms always show. The button reads "Subscribe", and then "Subscribe for per year" when Play gives a price.buyPass(activity, onUnavailable)inBillingManagerand in bothPlayBillingflavors. If the details are not loaded,PlayBillingasks Play again. If Play still has no pass, orlaunchBillingFlowfails,MainActivityshows "Google Play is not available. Sign in to Google Play and try again."pro_offer_title: "Pro feature"pro_offer_formatting: "Bold, italic, colors, text size, and new or joined paragraphs are Pro features. The highlighter is free."pro_offer_sheet: "Bold, italic, colors, text size, alignment, formulas, and inserting or deleting rows and columns are Pro features. The fill is free."pro_offer_markup: "Underline, strikethrough and drawing on a PDF are Pro features. The highlighter is free."pass_why: "A small team makes OpenDocument Reader. The app does not track you, but the ads in the free version can. Your purchase removes the ads and pays for updates and new features."pass_terms: "No ads and all Pro features for 1 year. Renews every year. Cancel any time in Google Play."pass_get_pro: "Pay once: get the Pro app"pro_offer_*strings lose their translations. Thepass_*strings had none yet.Testing
spotlessCheck assembleLiteDebug assembleProDebug assembleFossDebug testProDebugUnitTest lintLiteDebug compileLiteDebugAndroidTestKotlinpass.🤖 Generated with Claude Code