Skip to content

Make OIDAuthorizationService a protocol - #997

Merged
w-goog merged 2 commits into
masterfrom
codegen/ocmock-appauth-3b-service-protocol
Nov 17, 2026
Merged

w-goog merged 2 commits into
masterfrom
codegen/ocmock-appauth-3b-service-protocol

Conversation

@w-goog

@w-goog w-goog commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

I moved the instance methods from #990 and #991 into OIDAuthorizationServiceProtocol (and platform-specific ones). The extant plan of having the fake in #993 inherit the real class methods was goofy, and would've required a nastier refactoring. (Ack that the naming is bad, it follows GTMSessionFetcherServiceProtocol; I'll make them better in 4.0 when breaking changes are OK)

@w-goog w-goog changed the title Declare OIDAuthorizationService's instance methods in protocols Make OIDAuthorizationService a protocol Nov 17, 2026
@w-goog
w-goog force-pushed the codegen/ocmock-appauth-3b-service-protocol branch from a764c0d to 25b4d35 Compare November 17, 2026 21:20
@w-goog
w-goog changed the base branch from codegen/ocmock-appauth-3-fake-session to master November 17, 2026 21:20
@w-goog
w-goog requested a review from ch40w31 November 17, 2026 21:22
@w-goog
w-goog marked this pull request as ready for review November 17, 2026 21:42
@w-goog
w-goog merged commit 197ca68 into master Nov 17, 2026
16 checks passed
@w-goog
w-goog deleted the codegen/ocmock-appauth-3b-service-protocol branch November 17, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants