Repository navigation
Make OIDAuthorizationService a protocol - #997
Merged
Merged
Conversation
OIDAuthorizationService's instance methods in protocolsOIDAuthorizationService a protocol
w-goog
force-pushed
the
codegen/ocmock-appauth-3b-service-protocol
branch
from
November 17, 2026 21:20
a764c0d to
25b4d35
Compare
w-goog
changed the base branch from
codegen/ocmock-appauth-3-fake-session
to
master
November 17, 2026 21:20
ch40w31
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved the instance methods from #990 and #991 into
OIDAuthorizationServiceProtocol(and platform-specific ones). The extant plan of having the fake in #993 inherit the real class methods was goofy, and would've required a nastier refactoring. (Ack that the naming is bad, it followsGTMSessionFetcherServiceProtocol; I'll make them better in 4.0 when breaking changes are OK)