Repository navigation
fix: raise a clear ValueError when create_dataset gets an empty array - #1779
Open
mayuriphad wants to merge 1 commit into
Open
mayuriphad wants to merge 1 commit into
mayuriphad wants to merge 1 commit into
Conversation
create_dataset read data[0] to detect the data format, so an empty list or numpy array raised IndexError instead of a descriptive ValueError. Signed-off-by: mayuriphad <mayuriphad656@gmail.com>
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata
create_dataset()raisingIndexErrorinstead ofValueErrorfor an empty list or arrayDetails
create_dataset()readdata[0]to detect the data format, so a zero-row list ornumpy.ndarraycrashed withIndexError: index 0 is out of bounds. It now raisesValueError: 'data' must contain at least one row, but it is empty.test_create_invalid_datasetgains an empty-array case. It fails withIndexErrorbefore the change and passes after.