Skip to content

[MAINT] Run fewer services in CI #1782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PGijsbers merged 3 commits into from
Nov 3, 2026
Merged

[MAINT] Run fewer services in CI #1782

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
20cde2f
Run fewer services
PGijsbers Oct 23, 2026
106bfac
Simplify up/down with dedicated profile
PGijsbers Nov 3, 2026
fb90c71
Merge branch 'main' into maint/leaner-ci
PGijsbers Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,14 +122,7 @@ jobs:
run: |
chmod -R a+rw ./data
chmod -R a+rw ./logs
docker compose --profile rest-api --profile minio --profile evaluation-engine up -d

echo "Waiting for PHP API to boot..."
timeout 60s bash -c 'until [ "$(docker inspect -f {{.State.Health.Status}} openml-php-rest-api)" == "healthy" ]; do sleep 5; done'

echo "Final Verification: Gateway Connectivity..."
curl -sSfL http://localhost:8000/api/v1/xml/data/1 | head -n 15

Comment on lines -127 to -132

@PGijsbers PGijsbers Nov 3, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker compose would take a long time to start with the old setup since elastic search indexing needed to happen. I think this required a workaround to properly wait for services to be up. Either that or at some point a container which is supposed to exit gracefully during startup (e.g., database-setup) was included and this conflicts with --wait. Either way, with the new profile definition we don't have this issue and --wait works as expected.

docker compose --profile "client-ci" up --quiet-pull --wait
docker container ls

- name: Show installed dependencies
Expand Down Expand Up @@ -197,7 +190,7 @@ jobs:
if: always() && steps.clone-services.outcome == 'success'
working-directory: ./services
run: |
docker compose --profile rest-api --profile minio --profile evaluation-engine down -v
docker compose --profile "client-ci" down -v
cd ..
sudo rm -rf services

Expand Down
Loading