[csviri]

Summary

Fixes in how the desired state aspects are applied, found while reviewing the virtual thread support PR (#3664) and extracted from it.

1. No more Recursive update when an aspect looks up the actual resource

DefaultContext#getOrComputeDesiredStateFor applied the aspects inside ConcurrentHashMap.computeIfAbsent. A DesiredStateAspect that looks up the actual resource of its dependent asks for the desired state that is being computed, which re-entered the map on the same key. Looking up the actual resource of another dependent could do the same when its key landed in the same bin. Both failed with IllegalStateException: Recursive update.

The desired state is now computed outside of the map:

• a lock per dependent makes sure it is computed once, also when several threads ask for it
• the thread that is computing a desired state is handed the state as it is so far when it asks for it again, instead of re-entering the computation

2. Aspects of a bulk dependent receive the dependent the user configured

For a bulk dependent resource the framework creates a stand-in dependent per resource, and that stand-in was handed to the aspects. The aspects now receive the bulk dependent the user configured, through a new getOrComputeDesiredStateFor(dependentResource, aspectTarget, desiredStateComputer) overload used by BulkDependentResourceReconciler.

3. A missing controller configuration is tolerated

The aspects are skipped when the context has no controller configuration, instead of failing with a NullPointerException, which is the case for contexts created outside of a controller, for example in unit tests.

Tests

• DesiredStateAspectReentrancyTest: an aspect looking up the actual resource of its own dependent and of another dependent, and the desired state being computed once.
• DesiredStateAspectAuditTest: the bulk dependent receiving the user's bulk dependent resource, the lookup of the actual resource, and computing the desired state without an aspect configuration.

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}