[tmshort]

Summary

Fix the experimental E2E progress deadline timing assertion by measuring the ClusterExtension condition transition from ClusterObjectSet creation. The ClusterObjectSet creation timestamp is when the controller starts the rollout deadline. The existing one-to-two-minute assertion window remains unchanged.

Context

The prior assertion measured from ClusterExtension creation, including the variable time needed to resolve the bundle and create the ClusterObjectSet. This caused timing failures on unrelated PRs even when the deadline behavior was correct.

Validation

• go test ./test/e2e/steps
• go test -c -o /tmp/operator-controller-e2e.test ./test/e2e
• git diff --check

The cluster E2E suite was not run locally.

Summary by CodeRabbit

• Tests
  • Updated installation timing checks to measure the Progressing condition’s transition time from the associated object set’s creation timestamp, rather than the extension’s creation timestamp. The checks continue to verify that the transition occurs within the specified one-to-two-minute window. The timing step now identifies the object set used as the reference point.

[netlify]

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	74bf623
🔍 Latest deploy log	https://app.netlify.com/projects/olmv1/deploys/6adf83e9cde3671b3ea292e4
😎 Deploy Preview	https://deploy-preview-3070--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Enterprise
• Run ID: e3f9df19-7479-4fb5-8193-a9df8c37ffdc

Commits

Reviewing files that changed from the base of the PR and between 606d6b8 and 74bf623.

Files selected for processing: 1

• test/e2e/steps/steps.go

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

The E2E progress-deadline step now measures the ClusterExtension Progressing transition from the named ClusterObjectSet’s creation time. Two scenarios use this baseline, and the step checks that elapsed time falls within the inclusive minute bounds.

Changes: Progress transition timing

Layer / File(s)	Summary
Measure transition time from ClusterObjectSet creation test/e2e/steps/steps.go, test/e2e/features/install.feature	The step accepts a ClusterObjectSet name and compares its creation time with the ClusterExtension condition transition time. Two progress-deadline scenarios use the ClusterObjectSet creation time as their baseline.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: perdasilva, fgiudici

Merge Risk: Minimal · up to 74bf6

The timing assertion uses the intended rollout baseline. No actionable merge risk was found; the cluster E2E suite remains to be run in the normal validation workflow.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description check		The description clearly explains the timing assertion fix, its motivation, and the validation performed. It does not include the reviewer checklist from the template, but the required change summary a…
Title check		The title is concise, uses the required bug-fix icon, and clearly identifies the experimental E2E progress deadline timing assertion as the main change.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description clearly explains the timing assertion fix, its motivation, and the validation performed. It does not include the reviewer checklist from the template, but the required change summary and testing information are complete.

Finishing Touches: 💡 1

🧪 Generate unit tests (beta)

• Create a new PR

🛠️ Fix failing CI checks: 💡

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[perdasilva]

apidiff is failing on the e2e step changes - overriding