Repository navigation
fix(web): the reader's line stays put when the chat changes width - #224
Merged
Merged
Conversation
|
This PR changes the test suite by +15 test cases (browser +14, unit +1, server 0). New browser test files: Keep tests that would fail for a real reason, and test logic below the UI where it can be. See Testing. |
Thread transfer impact
This comment will update automatically after the next completed run. |
orbitingflea
force-pushed
the
fix/resize-reader-line
branch
from
November 19, 2026 15:00
9421c2f to
c2e9c41
Compare
Narrowing or widening the chat after a scroll moves the line the reader sees: the partly visible top row grows upward, and text rewraps inside a single tall row. The cases cover both, plus a selection drag, streaming text, a press, a work group, a minimap glide, widening near the end, and staying at the end while following. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
LegendList keeps one row's top in place, so when the chat narrows or widens, text that rewraps above or inside that row moves the line the reader sees, by up to about 70 px in Chat mode. The timeline now remembers one character near its top while the reader reads, and when that row changes width it scrolls the character back to where it was, after LegendList's own pass. It steps aside while the end is followed, while another scroll is running, and during find, citation jumps and restores, and its scrolls do not count as the reader's. A disclosure reveal measured while it holds skips its scroll, because the layout is still settling from the width change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
orbitingflea
force-pushed
the
fix/resize-reader-line
branch
from
November 19, 2026 15:42
c2e9c41 to
15e3773
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request keeps the line a reader is on at the same place on screen when the chat gets narrower or wider after they scroll up.
改了什么行为
Behaviour change: yes, a reader who has scrolled up in the chat keeps the line they see at the same place on screen when the chat gets narrower or wider (window, panel, sidebar, chat width), in Chat mode and Normal mode. Before, that line moved by up to about 70 px. At the end, and while following, nothing changes.
Why
The list keeps one row's top still, so text that rewraps in the row above it, or inside it, moves the reader's line. The timeline now remembers one character near its top and, when its row changes width, scrolls it back. It steps aside while the end is followed, while another scroll runs, and during find, citation jumps and restores. A disclosure reveal measured while it holds skips its scroll, because the layout is still settling.
Checks
How to undo
Revert both commits. No stored data changes.