Repository navigation
fix: refresh share badges when folder etag is unchanged - #5013
Merged
jesmrec merged 6 commits intoNov 3, 2026
Merged
Conversation
joragua
requested changes
Oct 20, 2026
Member
There was a problem hiding this comment.
Thanks for the contribution @mvanhorn! Some comments about this PR
NOTE: Do not forget to split the changes into three commits: one for the fix, one for test (using the test: prefix) and another one for the calens file (chore: add calens file)
mvanhorn
force-pushed
the
fix/4938-oc10-sharing-badges-refresh
branch
from
October 22, 2026 06:05
b3b7759 to
72c0a3c
Compare
Contributor
Author
|
Thanks for the review, @joragua. I've addressed everything:
The OCFileRepositoryTest suite and the full owncloudData unit tests pass locally, and detekt is clean. |
joragua
requested changes
Oct 26, 2026
joragua
left a comment
joragua
left a comment
Member
There was a problem hiding this comment.
The second CR round is here @mvanhorn! Just check the comments below and it should be ready for QA 😄
NOTE: It's not necessary to create new commits for the changes. You can rebase the branch and include the changes in the existing commits. Let us know if you have any doubts!
Contributor
Author
|
Pushed two small follow-ups for the second round: 2cd2b3b drops the redundant comment in OCFileRepository, and 946f942 renames the test to match the naming convention. I added them as separate commits so the diff is easy to check. Glad to squash them into the existing commits if you prefer. The extra unit tests for the |
Member
|
Some QA checks:
|
Member
|
@mvanhorn your contribution is also QA-approved, congrats!! Please, rebase the branch against Thanks a lot for your engagement! 🚀 |
When the etag still matches but sharedByLink, permissions, or the boolean sharedWithSharee value differ (null and false count as equal), the child is now handled by the existing update branch in refreshFolder, so its share fields are saved while local properties and the local etag are kept. Fixes owncloud#4938 Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019jP1NBrfG9D7pKJLkd5yre
Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019jP1NBrfG9D7pKJLkd5yre
Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019jP1NBrfG9D7pKJLkd5yre
Signed-off-by: Matt Van Horn <mvanhorn@gmail.com>
Contributor
Author
mvanhorn
force-pushed
the
fix/4938-oc10-sharing-badges-refresh
branch
from
November 3, 2026 21:31
7112e1c to
f296359
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
App:
Not claimed: this diff changes no changelog or release-note file.
ReleaseNotesViewModel.ktcreating a newReleaseNote()with String resources (if required)Not claimed:
ReleaseNotesViewModel.ktwas not run locally either.QA
When the etag still matches but sharedByLink, permissions, or the boolean sharedWithSharee value differ (null and false count as equal), that child is added to the files saved for the folder. The saved row keeps local properties, the existing etag, and the thumbnail-update flag, keeps the remote share fields, and is marked available offline through the parent when the parent is available offline. A unit test covers refreshFolder persisting a folder child in that case, and the unreleased changelog notes the badge refresh.
Pull to refresh on ownCloud 10 leaves folder share badges unchanged after a folder is shared or unshared in the web UI. The badges update only after that folder is opened and the user navigates back. Folder refresh writes a child back only when its etag differs from the local row. ownCloud 10 leaves the etag unchanged when only share metadata changes, so a new sharedByLink value, sharedWithSharee value, or permissions value is dropped.
Fixes #4938
AI was used for assistance.