Repository navigation
fix(filter): read the zone of a date and time value only after the fraction - #165
Merged
Merged
Conversation
This was referenced Oct 1, 2026
pdevito3
force-pushed
the
fm/qk-breaking-zone-after-fraction
branch
from
October 1, 2026 21:43
47f8e8f to
4d9a1b7
Compare
…action
The date parser accepted the zone before the fraction, which is not an ISO 8601 format. The parser now reads the date, the time, the fraction, and then the zone.
Behavior change: an unquoted date and time value with the zone before the fraction throws ParsingException. Write the zone after the fraction.
Examples:
SpecificDateTime == 2024-01-15T08:00:00Z.5
before: parses
after: ParsingException
SpecificDate == 2024-01-15T10:00:00+02:00.500
before: parses
after: ParsingException
SpecificDateTime == 2024-01-15T08:00:00.5Z
before and after: parses
pdevito3
force-pushed
the
fm/qk-breaking-zone-after-fraction
branch
from
October 9, 2026 20:49
4d9a1b7 to
7c20557
Compare
pdevito3
changed the title
pdevito3
added a commit
that referenced
this pull request
Oct 9, 2026
…action (#165) The date parser accepted the zone before the fraction, which is not an ISO 8601 format. The parser now reads the date, the time, the fraction, and then the zone. Behavior change: an unquoted date and time value with the zone before the fraction throws ParsingException. Write the zone after the fraction. Examples: SpecificDateTime == 2024-01-15T08:00:00Z.5 before: parses after: ParsingException SpecificDate == 2024-01-15T10:00:00+02:00.500 before: parses after: ParsingException SpecificDateTime == 2024-01-15T08:00:00.5Z before and after: parses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For later consideration in a major version. Do not merge now. This PR is one of two PRs that replace #144. Each PR has one breaking change. The captain decides on each PR separately.
#134 restored the v1.14.2 rule (restore commit
b49ad2b). This PR re-applies this part of5c84ef6.What breaks
An unquoted date and time value with the zone before the fraction throws
ParsingException. On v1.14.2 and main, the value parses.Example
SpecificDateTime == 2024-01-15T08:00:00Z.5ParsingExceptionSpecificDate == 2024-01-15T10:00:00+02:00.500ParsingExceptionSpecificDateTime == 2024-01-15T08:00:00.5ZJustification
A zone before the fraction is not an ISO 8601 format. The README shows only ISO 8601 values. The date parser now reads the date, the time, the fraction, and then the zone.
Migration
Write the zone after the fraction:
2024-01-15T08:00:00.5Z.README
The date and time format list says that the zone comes after the fraction. It also says that an unquoted value with the zone before the fraction throws a
ParsingException.Tests
zone_before_the_fraction_throws(2 cases).Z.5and+02:00.500are removed from the date tests.dotnet teston this branch: 470 unit tests and 296 Postgres integration tests (Testcontainers) pass, 0 failures.