Repository navigation
fix(filter): keep a short fraction of a quoted time - #183
Merged
Merged
Conversation
A quoted time dropped a fraction with fewer than 3 digits, so Time == "08:30:00.5" compared with 08:30:00. Keep every fraction digit of a quoted time, like an unquoted time. The rightIsQuotedLiteral argument of CreateRightExpr is removed, because the time conversion was its only user.
Behavior change: Time == "08:30:00.5" now matches 08:30:00.500, not 08:30:00. Remove the fraction to match the whole second.
Examples:
Time == "08:30:00.5"
before: matches 08:30:00
after: matches 08:30:00.500
Time == "08:30:00.50"
before: matches 08:30:00
after: matches 08:30:00.500
Time == "08:30:00.500"
before and after: matches 08:30:00.500
From #166 on v2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quoted time dropped a fraction with fewer than 3 digits, so Time == "08:30:00.5" compared with 08:30:00. Keep every fraction digit of a quoted time, like an unquoted time. The rightIsQuotedLiteral argument of CreateRightExpr is removed, because the time conversion was its only user.
Behavior change: Time == "08:30:00.5" now matches 08:30:00.500, not 08:30:00. Remove the fraction to match the whole second.
Examples:
Time == "08:30:00.5"
before: matches 08:30:00
after: matches 08:30:00.500
Time == "08:30:00.50"
before: matches 08:30:00
after: matches 08:30:00.500
Time == "08:30:00.500"
before and after: matches 08:30:00.500
From #166 on v2.