Repository navigation
Keep comments written before an empty comment line - #314
Open
jayhemnani9910 wants to merge 1 commit into
Open
jayhemnani9910 wants to merge 1 commit into
jayhemnani9910 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PoLoaderloses every comment that comes before a bare#line. In a standard .po header (as written bymsginit/xgettext, and byPoGeneratoritself) that is the whole description:getDescription()returnsnull, and loading then saving the file withPoGeneratordrops the copyright, license and translator lines. A translator comment followed by a#line is lost the same way.Since #296 a bare
#is read as an empty line, which ends the current entry; an entry with only comments is empty and is discarded. Now a bare#only ends an entry once the entry has a msgid or translation (the msgcat case from #296). Before that it is skipped, and the comments carry on to the entry that follows.Added
testCommentsBeforeEmptyCommenttoPoLoaderTest(header description,fuzzyflag, and a translator comment between#lines); it fails without the change.StrictPoLoaderkeeps these comments already, so the test is only forPoLoader.phpunit106 tests OK,phpcsandphpstanclean. Loading and generating the file above now keeps the four header lines; on master they are gone.