Repository navigation
Find comments of wrapping nodes and on the previous line - #20
Open
swissspidy wants to merge 1 commit into
Open
swissspidy wants to merge 1 commit into
swissspidy wants to merge 1 commit into
Conversation
A comment in front of a function call belongs to the outermost node
that starts there. Only a few statement types were looked at, so the
comment was lost when the call was an argument of another call, the
value of an array item or part of a concatenation:
printf(
/* translators: %s: Name */
__('Hello %s'),
$name
);
Comments on the line before the call are now found as well, which is
common in templates:
<?php /* translators: Label */ ?>
<p><?php _e('Label'); ?></p>
swissspidy
force-pushed
the
fix/comment-association
branch
from
November 18, 2026 12:59
d904da8 to
5d6b751
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A comment in front of a function call belongs to the outermost node that starts there. Only a few statement types were looked at, so the comment was lost when the call was an argument of another call, the value of an array item or part of a concatenation:
Comments on the line before the call are now found as well, which is common in templates:
Claude-Session: https://claude.ai/code/session_01UWTd5qmztfFv37ybV4xsjV