Repository navigation
Support PHP 7.2 and nikic/php-parser 4 - #21
Open
swissspidy wants to merge 1 commit into
Open
swissspidy wants to merge 1 commit into
swissspidy wants to merge 1 commit into
Conversation
swissspidy
marked this pull request as ready for review
November 17, 2026 16:15
`gettext/gettext` 5 supports PHP 7.2, but the scanner needed PHP 7.4 because of typed properties and nikic/php-parser 5. * Allow nikic/php-parser ^4.18 next to ^5 and create the parser and traverser in a way that works with both. * Handle the scalar node names of nikic/php-parser 4. * Skip duplicate comments. nikic/php-parser 4 assigns a comment to every node starting after it, not only to the outermost one. * Replace typed properties with docblocks. * Allow PHPUnit 8.5 and run the tests on PHP 7.2 and 7.3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gettext/gettext5 supports PHP 7.2, but the scanner needed PHP 7.4 because of typed properties and nikic/php-parser 5.This will be helpful for the migration to v5 in WP-CLI.
Claude-Session: https://claude.ai/code/session_01UWTd5qmztfFv37ybV4xsjV