Repository navigation
PhpDocParser: read a quoted key of a Doctrine annotation argument - #338
Merged
ondrejmirtes merged 1 commit intoOct 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doctrine reads only a name as the key of an annotation argument:
@Foo(key="value"). Some code has a key in quotes:@Foo("key"="value"). Before, the parser returnedInvalidTagValueNodefor all of the tag.Now the parser reads a quoted key as the name of the argument.
DoctrineArgument::$keyisIdentifierTypeNode('key'), so the type of the property does not change. The format-preserving printer keeps the quotes.The grammar in
doc/grammars/phpdoc-block.pp3has the same change.Rector needs this to keep its existing fixtures, for example
@ORM\OneToMany(..., "indexBy"="id").