Repository navigation
Do not keep the results of literal array keys and values - #6781
Open
ondrejmirtes wants to merge 2 commits into
Open
ondrejmirtes wants to merge 2 commits into
ondrejmirtes wants to merge 2 commits into
Conversation
A statement keeps every ExpressionResult it produced in the storage until it ends, and ArrayHandler keeps its items' results until the array's own type is resolved. In a large array literal that is two results per item, although a literal's type is lexical. ArrayHandler now keeps only the types of its literal keys and values and drops their results once the item's callback has fired. Asks about a literal from then on are priced directly by MutatingScope::resolveType(), which also spares them the on-demand processing a missing result would otherwise cost. AssignHandler reads the keys' results of an assigned array to alias its by-ref items, so an array with a by-ref item anywhere keeps them, and the aliasing walk now skips arrays without one - it had nothing to do in them anyway. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017pydsEaJ8dAiZ22Nt1Yqf4
ondrejmirtes
force-pushed
the
literal-array-memory
branch
from
October 22, 2026 20:31
4aaaa1c to
ea566aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #6778 for the memory side of phpstan/phpstan#15452.
A statement keeps every
ExpressionResultit produced in the storage until it ends, andArrayHandlerkeeps its items' results until the array's own type is resolved. In a large array literal that is two results per item, although a literal's type is lexical.ArrayHandlerkeeps only the types of its literal (String_/Int_/Float_) keys and values, and drops their results once the item's callback has fired.getCallableDependencies()andcollectAbsorbedItems()read the kept types.MutatingScope::resolveType()prices a literal directly. Without that, every later ask about a dropped literal (e.g.DuplicateKeysInLiteralArraysRuleasking about each key) went through on-demand processing, costing ~15% time on the reproducer.AssignHandlerreads the keys' results of an assigned array to alias its by-ref items, so an array with a by-ref item anywhere keeps them, and the aliasing walk now skips arrays without one (it had nothing to do there).hasArrayReference()moved toArrayHandler::hasByRefItem()so both sides share one definition.nsrt/array-literal-by-ref-literal-keys.phpmixes plain nested arrays with by-ref items and fails with an internal error if either side of that rule is removed.ArrayHandler,AssignHandler,ExpressionResultStorage,MutatingScope).Reporter's reproducer (https://github.com/alfredbez/phpstan-literal-array-memory-reproducer):
Of the remaining 87 MB at 20,000 entries, 53 MB is php-parser's AST of the 700 KB file.
No time change on ordinary code:
src/Typeself-analysis, interleaved A/B pairs on user CPU: +0.28% turbo off (n=4, sd 0.85), +0.42% turbo on (n=10, t=0.38).Verified: full suite with and without turbo, walk-trace identical, smoke, side-by-side, signature parity, clang-tidy on the changed sources.
🤖 Generated with Claude Code
https://claude.ai/code/session_017pydsEaJ8dAiZ22Nt1Yqf4