Skip to content

owners: remove develop docs aliases (#24543) - #24544

Merged
ti-chi-bot[bot] merged 2 commits into
pingcap:release-8.5from
ti-chi-bot:cherry-pick-24543-to-release-8.5
Oct 23, 2026
Merged

ti-chi-bot[bot] merged 2 commits into
pingcap:release-8.5from
ti-chi-bot:cherry-pick-24543-to-release-8.5

Conversation

@ti-chi-bot

@ti-chi-bot ti-chi-bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

This is an automated cherry-pick of #24543

What is changed, added, or deleted? (Required)

Remove the obsolete sig-develop-docs-approvers and sig-develop-docs-reviewers configuration from develop/OWNERS and OWNERS_ALIASES. Keep the area/develop automatic label configuration.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

  • Related code change PR links (if applicable):
  • This PR is translated from:
  • Other reference link(s):

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Chores
    • Updated repository review and approval assignments, including adding community review and approval listings and revising development documentation assignments.
    • No user-facing functionality changes are included in this update.

Signed-off-by: ti-chi-bot <ci@pingcap.com>
@ti-chi-bot ti-chi-bot added area/develop This PR relates to the area of TiDB App development. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. ONCALL Relates to documentation oncall. labels Oct 23, 2026
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 23, 2026
4 of 12 tasks
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Oct 23, 2026
@ti-chi-bot

Copy link
Copy Markdown
Member Author

@lilin90 This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot

ti-chi-bot Bot commented Oct 23, 2026

Copy link
Copy Markdown

@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot

ti-chi-bot Bot commented Oct 23, 2026

Copy link
Copy Markdown

The content of OWNERS_ALIASES is invalid.

@ti-chi-bot ti-chi-bot Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 23, 2026
@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

📝 Walkthrough

The changes update the develop documentation reviewer and approver aliases, add community reviewer and approver aliases, and remove trailing whitespace from the develop label entry.

Changes: OWNERS configuration

Layer / File(s) Summary
Alias and label updates
OWNERS_ALIASES, develop/OWNERS
The develop documentation reviewer and approver aliases now list seominjea1942. The new community aliases list their reviewers and approvers. The area/develop label entry loses trailing whitespace.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related PRs

  • pingcap/docs#24543: Both changes modify develop/OWNERS and OWNERS_ALIASES for develop documentation ownership configuration.
Merge Risk: 🟡 Moderate · up to 5bbb4

Develop documentation review and approval routing still uses configuration this change was meant to remove. Complete the alias and ownership cleanup before merging.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title "owners: remove develop docs aliases (#24543)" matches the main change. The PR removes the obsolete sig-develop-docs-approvers and sig-develop-docs-reviewers aliases from develop/OWNERS and …
Description check Passed The description follows the template. It states what changed and why: it removes the sig-develop-docs-approvers and sig-develop-docs-reviewers configuration and keeps the area/develop label configurat…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "owners: remove develop docs aliases (#24543)" matches the main change. The PR removes the obsolete sig-develop-docs-approvers and sig-develop-docs-reviewers aliases from develop/OWNERS and OWNERS_ALIASES. The title names the change and the scope. The PR number suffix is minor noise but does not affect the assessment.

Full details: Description check

Explanation

The description follows the template. It states what changed and why: it removes the sig-develop-docs-approvers and sig-develop-docs-reviewers configuration and keeps the area/develop label configuration. It lists target versions (master and v8.5). It marks the AI agent involvement and the Change aliases option. The contributor checklist and related PR links are left blank. The Contributor License Agreement box is unchecked, but this box applies to first-time contributors only, so the blank entries do not block the check. The 'Delete files' option is unchecked, which is correct because no files are deleted.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3


ℹ️ Review info
⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between 139d983 and e7828b3.

📒 Files selected for processing: 2
  • OWNERS_ALIASES
  • develop/OWNERS

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Comment thread develop/OWNERS
Comment thread OWNERS_ALIASES
Comment thread OWNERS_ALIASES Outdated
@lilin90 lilin90 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2026

@lilin90 lilin90 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ti-chi-bot

ti-chi-bot Bot commented Oct 23, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Oct 23, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to GitHub limitations.

⚠️ Outside diff range comments (1)

🟡 Minor · Remove the sig-develop-docs-reviewers alias definition instead of replacing… · OWNERS_ALIASES:5

OWNERS_ALIASES:5
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Remove the sig-develop-docs-reviewers alias definition instead of replacing its member.

The PR removes the obsolete sig-develop-docs-reviewers configuration. At the reviewed head, this alias is still defined and maps to seominjea1942. This keeps a reviewer group that the PR is meant to remove, so the review routing for develop/ changes can still include that account. Delete the definition. The develop/OWNERS reviewers reference is a separate correction and is not covered here.

Suggested fix
 aliases:
   sig-develop-docs-approvers:
     - seominjea1942
-  sig-develop-docs-reviewers:
-    - seominjea1942
   sig-community-reviewers:

ℹ️ Review info
⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between e7828b3 and 5bbb437.

📒 Files selected for processing: 1
  • OWNERS_ALIASES
💤 Files with no reviewable changes: 1
  • OWNERS_ALIASES

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.

@ti-chi-bot
ti-chi-bot Bot merged commit f7b9e59 into pingcap:release-8.5 Oct 23, 2026
12 checks passed
@ti-chi-bot
ti-chi-bot Bot deleted the cherry-pick-24543-to-release-8.5 branch October 23, 2026 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/develop This PR relates to the area of TiDB App development. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. ONCALL Relates to documentation oncall. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants