Repository navigation
fix(android): menu icons take taps - #20802
Merged
Merged
Conversation
Menu row icons are React Native views hosted inside the Compose row, and the host consumes every touch over the glyph, so tapping a submenu's Back arrow, a chevron, or a check glyph did nothing. The icon now runs its row's action itself and stays hidden from accessibility, so the row remains the accessible element. Co-authored-by: Pixel Perfect <me@pixp.cc> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a narrowly scoped Android UI bug fix that routes icon taps to the menu actions already used by the surrounding rows while preserving disabled and accessibility behavior. It introduces no new capability, schema, deployment, security, billing, or static-analysis changes. Notes:
You can add or adjust custom eligibility rules. Learn more. |
macroscopeapp
Bot
dismissed
their stale review
October 17, 2026 06:58
Dismissing prior approval to re-evaluate 61458aa
commented
Oct 17, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Android, tapping the icon in a menu row did nothing. That includes a submenu's Back arrow, a row's chevron, and the check mark. Only taps on the row's text worked.
Each icon is a React Native view hosted inside the Compose menu row.
@expo/ui's host view consumes every touch over its bounds (TouchDispatchingRootViewGroup.onTouchEventalways returnstrue), so the row'sonClicknever sees a tap on the glyph. The icon is now aPressablethat runs the same action as its row. It stays hidden from accessibility and from keyboard and D-pad focus, so the row remains the only focusable element, and it is inert when the row is disabled.Patching the host view to pass touches through would change every
RNHostViewin the app, so the fix stays local to the menu.Split out of #19987 by @PixPMusic, who found the bug and the fix on device. That PR is being rebuilt as smaller PRs.
Verification: mobile typecheck and lint pass. Two reviewers (Opus and Sol, two rounds) traced the touch path for both the popup and inline menus. Not yet checked on a device:
🤖 Generated with Claude Code