Skip to content

fix(server): remove one-child-per-model instruction - #25359

Merged
Yash-Singh1 merged 1 commit into
mainfrom
t3/fix-subagent-model-limit
Oct 26, 2026
Merged

Yash-Singh1 merged 1 commit into
mainfrom
t3/fix-subagent-model-limit

Conversation

@Yash-Singh1

Copy link
Copy Markdown
Collaborator

Problem

The injected "One child per named model" instruction makes agents refuse requests for multiple subagents using the same model. For example, a request for 20 Sol workers and 20 Luna workers was reduced to one worker per model.

Change

Remove that sentence from the shared orchestration prompt so it no longer imposes a per-model child limit across providers and clients.

Scope and approval

This is a focused fix for an obvious prompt bug in the existing delegation capability. Related to #24967 and the existing fix proposed in #25154.

Verification

  • vp test run apps/server/src/provider/CodexDeveloperInstructions.test.ts: all five tests passed, including instruction routing and the per-entry byte limit.
  • Executed the shared, system, first-run, and ACP prompt builders and confirmed that none emits the removed restriction.
  • vp run check:changed: formatting, lint, both knip passes, and typechecks for 21 affected packages passed. Two existing looping .env symlinks were temporarily moved for this check and restored afterward.

Model: GPT-6.1 Sol. Harness: Codex.

@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 26, 2026
@macroscopeapp

ghost commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — This removes a constraint from the server's default orchestration prompt, allowing agents to delegate multiple children to the same model on an existing production path. The change is small but alters default product behavior and warrants human review.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

ghost commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 10629af and 4f002fc.

Files selected for processing: 1
  • packages/provider-core/src/server/orchestrationInstructions.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The shared orchestration instructions no longer require one child per named model before delegation. Provider capability checks, target option configuration, unavailable provider or model reporting, and fallback rules remain.

Changes: Orchestration delegation

Layer / File(s) Summary
Delegation instruction update
packages/provider-core/src/server/orchestrationInstructions.ts
The instructions remove the requirement to use one child per named model. Other delegation instructions remain.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix · Severity of issue fixed: Low

Possibly related issues

  • pingdotgg/t3code#24967 reports that the removed restriction blocked requests for two subagents on the same model. This change removes that restriction; it does not add the proposed orchestration eval.

Possibly related PRs

  • pingdotgg/t3code#25154: This PR also changes the shared instruction that limited delegation to one child per model.

Suggested labels: bugfix

Suggested reviewers: t3dotgg

Merge Risk: Minimal · up to 4f002

No actionable merge-blocking risk was identified.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly identifies the main change: removing the one-child-per-model instruction from server orchestration.
Description check Passed The description includes the required Problem, Change, Scope and approval, and Verification sections. It explains the bug, the focused fix, the approval rationale, and detailed verification results.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

ghost commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.0 KiB 5.0 KiB +7 B (+0.1%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.2 KiB 1.2 KiB +7 B (+0.6%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 20.9 KiB 20.9 KiB 0 B (0.0%) 29.3 KiB ✅
Codex Live turn messages 2 2 0 (0.0%) 8 ✅
Claude Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.2 KiB 21.2 KiB 0 B (0.0%) 29.3 KiB ✅
Claude Live turn messages 2 2 0 (0.0%) 8 ✅

Baseline: 10629af · PR result: 4f002fc · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant