Skip to content

fix(mobile): polish Android toast styling and text scaling - #28586

Open
none23 wants to merge 5 commits into
pingdotgg:mainfrom
none23:t3/android-toast-font-scaling
Open

none23 wants to merge 5 commits into
pingdotgg:mainfrom
none23:t3/android-toast-font-scaling

Conversation

@none23

@none23 none23 commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Problem

On Android, changing the app's text size scales the settled/snoozed message but leaves much of the toast's icon, spacing, and Undo control fixed. Small text sits inside an oversized container, and larger text makes the surrounding elements look out of proportion.

The toast also has tight padding before the icon and mismatched rounding around Undo, leaving an uneven gap around the button.

Original Android toast with tight left padding and mismatched rounding around Undo highlighted

Change

Fix Android toast scaling and polish its rounding, spacing, and Undo button while preserving 48 dp touch targets. Icons and controls follow the app and system text scales, with compact padding at larger sizes, coordinated container and button corners, and more space before the icon. Large text can move the action onto a second row.

The change stays in the shared mobile toast component. iOS keeps its existing layout and controls.

Scope and approval

Focused fix for an obvious visual defect in the existing Android font-size setting. It changes toast sizing and visual styling, with no new settings, workflows, or backend behavior. The before/after captures below establish the defect without a separate issue.

Verification

  • vp run check:changed passed after rebasing onto current main.
  • Android 16 emulator captures cover app sizes 11, 16, and 22 pt, plus 150% system text at 16 and 22 pt. Messages, icons, and actions fit without clipping.
  • Snooze and settle Undo restored the threads. At 11 and 16 pt, taps outside Undo's visible pill but inside its 48 dp target also worked.
  • A temporary component-catalog fixture verified a four-line message and a description-only toast. The fixture was removed after verification.
  • Opus 5.5 reviewed the native captures and requested no further changes. iOS was not runtime-tested.
Text size Before After
11 pt Snoozed Before 11 pt Snoozed cropped toast After 11 pt Snoozed cropped toast
16 pt Snoozed Before 16 pt Snoozed cropped toast After 16 pt Snoozed cropped toast
22 pt Snoozed Before 22 pt Snoozed cropped toast After 22 pt Snoozed cropped toast
16 pt + Android 150% Snoozed Before 16 pt Android 150%  Snoozed cropped toast After 16 pt Android 150%  Snoozed cropped toast
22 pt Settled Before 22 pt Settled cropped toast After 22 pt Settled cropped toast
Full screenshots
Text size Before After
11 pt Snoozed Original Android snoozed-thread toast at 11pt Updated Android snoozed-thread toast at 11pt
16 pt Snoozed Original Android snoozed-thread toast at 16 pt Updated Android snoozed-thread toast at 16pt
22 pt Snoozed Original Android snoozed-thread toast at 22pt Updated Android snoozed-thread toast at 22pt
16 pt + Android 150% Snoozed Original Android snoozed-thread toast at 16pt-system150 Updated Android snoozed-thread toast at 16pt-system150
22 pt Settled Before 22 pt Settled full screenshot After 22 pt Settled full screenshot
22 pt + Android 150% Long messages at 11 pt
Updated Android toast at 22 pt and 150 percent system text Updated Android toasts with long messages at 11 pt

Implemented by GPT-6 Astra using the Codex harness. Design reviewed by Claude Opus 5.5 using Claude Agent.

@github-actions github-actions Bot added vouch:unvouched Author is not yet trusted in the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Nov 1, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at fe34b65

Macroscope's review found this PR approvable — Android toasts now scale their icons, spacing, and controls with text size while retaining 48 dp touch targets. The change is presentation-only, with reported Android scaling and Undo verification and no backend or saved-preference changes.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

ToastContent uses scaled typography to size Android toast layouts and controls. Android actions and dismissal controls use explicit Pressable touch targets. iOS retains its existing Button action and IconButton dismissal paths.

Changes: Toast Layout and Controls

Layer / File(s) Summary
Typography scaling and action layout
apps/mobile/src/components/ui/Toast.tsx, apps/mobile/src/lib/designTokens.ts
ToastContent derives Android sizing from scaled footnote typography. Android action controls and inline-action selection use platform-specific scaling. The fixed toast shape token is removed.
Surface and dismissal controls
apps/mobile/src/components/ui/Toast.tsx
The Android toast surface, spacing, indicators, symbols, and dismissal controls use scaled sizing. iOS retains its existing surface sizing and dismissal control component.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

Suggested labels: bugfix

Suggested reviewers: shivamhwp, juliusmarminge, pixpmusic

Merge Risk: Minimal · up to b855f

This change scales Android toast icons, controls and spacing with text size. No concrete merge-blocking defect was identified. iOS and extreme narrow-width text scaling were not runtime-verified.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: Android toast styling and text scaling in the mobile app. It uses the conventional commit form. The changeset scales Android toast typography, icons, padding, and the …
Description check Passed The description follows the template sections: Problem, Change, Scope, and Verification. The Problem and Change sections are clear. The Scope section explains why no issue is linked. The Verification …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: Android toast styling and text scaling in the mobile app. It uses the conventional commit form. The changeset scales Android toast typography, icons, padding, and the Undo control, so the title matches the main change.

Full details: Description check

Explanation

The description follows the template sections: Problem, Change, Scope, and Verification. The Problem and Change sections are clear. The Scope section explains why no issue is linked. The Verification section lists focused checks, observed results, and untested items such as iOS. It also includes before/after screenshots for the UI change. The template's note about the agent model is present. The description is mostly complete.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 4ca9c6d and b855fbf.

Files selected for processing: 2

  • apps/mobile/src/components/ui/Toast.tsx
  • apps/mobile/src/lib/designTokens.ts
Files with no reviewable changes: 1

  • apps/mobile/src/lib/designTokens.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@none23 none23 changed the title fix(mobile): keep Android toasts proportional to text size fix(mobile): polish Android toast styling and text scaling Nov 1, 2026
@maria-rcks

maria-rcks commented Nov 1, 2026 •

Copy link
Copy Markdown
Collaborator

Note

Written by gpt-6.1-sol on behalf of Maria

Verified on Android emulator (API 35) against a real dev server

Verified head fe34b6501212f2e31f5f6e977d7fec6d2dd3b412 on the t3 Android API 35 emulator with the cached native dev client, Metro, and an isolated dev server. Used the real server project and two completed Codex gpt-6.1-sol turns through the local proxy. No mocks or demo data.

At 22 pt, settle and snooze showed readable scaled icons and Undo controls. Undo restored each thread in the client; the server projection also returned to active with no snooze. At 22 pt plus Android 150% font scaling, the action moved onto its own row and remained readable and tappable.

The matched large-text comparison below uses the same project and threads. For the baseline, rebuilt Metro with only Toast.tsx replaced by its github/main version, which matches this PR's parent. The baseline leaves the icon small beside large text. The PR scales the icon and aligns the action's spacing and corners. Restored the exact PR file afterward; no source changes or commits.

before: original toast at 22 pt and Android 150%

after: scaled toast at 22 pt and Android 150%

snooze toast at 22 pt

settle and undo restore the real Codex thread at 22 pt

All 29 existing CI checks were successful when inspected. This pass changed no code, so no new check run was submitted.

Not verified

  • iOS cannot run on this Linux VM.
  • 11 pt, every toast variant, TalkBack announcements, and the outer edge of the 48 dp touch targets were not exercised.

Merge conflict resolution

Merged current main without rebasing in c429954aa7998228c597d2962c5e8bba05bf6fce and pushed to the existing contributor branch without force. Android toast scaling and controls are unchanged. Kept main's iOS radius 28, p-2 surface padding, compact action, and inline-action leading inset. The PR still changes only Toast.tsx (108 additions, 16 deletions against main).

Blacksmith vp run check:changed 61c3794c32b0eeebfac09add43e403618c65d2d7 passed: format, lint, knip, mobile and scripts typechecks, and six existing React Compiler checks. Two independent source reviews approved the merged head with no findings. All 29 checks on the merged head passed. GitHub reports CLEAN and MERGEABLE, and the latest bot review has no actionable findings.

Native runtime was not repeated on this merged head: device access is disabled in this VM and no Android device is attached. The earlier Android evidence above covers the unchanged Android implementation. iOS remains unverified.

@github-actions

Copy link
Copy Markdown
Contributor

This PR conflicts with main. Rebase it or merge main into it. If it still conflicts after 7 days with no activity, it will be closed automatically.

See the conflict window.

@github-actions github-actions Bot added the needs-rebase Conflicts with its base branch. Closes after 7 days with no activity. label Nov 18, 2026
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor
Action not completed

Already reviewed the last commit. Use @coderabbitai full review to rerun a review of the entire changeset.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@github-actions github-actions Bot removed the needs-rebase Conflicts with its base branch. Closes after 7 days with no activity. label Nov 19, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:unvouched Author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants