Repository navigation
fix(web): sideways swipes over a terminal scroll the pane strip - #29054
Merged
maria-rcks merged 1 commit intoNov 2, 2026
Conversation
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Sideways wheel gestures over terminals now remain available to scroll the pane strip, while vertical gestures retain existing terminal handling. The change is limited to UI gesture routing and carries no evident material data or operational risk. You can add or adjust custom eligibility rules. Learn more. |
maria-rcks
merged commit Nov 2, 2026
14bbb57
into
pingdotgg:maria/redesign/6-workspace-panes
63 of 65 checks passed
maria-rcks
pushed a commit
that referenced
this pull request
Nov 2, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 3, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 3, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 3, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 3, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 3, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 3, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 3, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 3, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 3, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 3, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 3, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 3, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 3, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 3, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 3, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 3, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 3, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 3, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 3, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 3, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 3, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 3, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 3, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 3, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 3, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 3, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 4, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 4, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 4, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 4, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 4, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 4, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 4, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 4, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 5, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 5, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 5, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 5, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 5, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 5, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 5, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 5, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 5, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 5, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 6, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 6, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 6, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 6, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 6, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 6, 2026
maria-rcks
pushed a commit
that referenced
this pull request
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
🤖 Claude Opus 5.5 on behalf of Oliver
Fix for the redesign stack, targets layer 6 (#28845).
Problem
Swiping sideways over a terminal pane barely moves the pane strip, so it feels laggy. The same swipe over a thread pane is smooth.
The terminal's wheel handler cancelled every wheel event with any vertical movement. A trackpad's sideways swipe usually carries ±1px of vertical noise. Those events got cancelled, so the strip only moved on the few events with exactly zero vertical delta. Chromium on macOS usually locks a swipe to one axis, which hides the problem there. Firefox and Zen pass the noise through.
Fix
The terminal now leaves mostly-sideways wheel events alone. The strip scrolls them the same way it does over a thread pane. Mostly-vertical events still scroll the terminal's scrollback.
Before
https://gh-file-drop-api-prod-galwoqjslzlnws6s.oliver-boorstein.workers.dev/f/193cc9a724042d74/before.mp4
After
https://gh-file-drop-api-prod-galwoqjslzlnws6s.oliver-boorstein.workers.dev/f/a0d370c72fcac0ff/after.mp4
Validation
The red dot marks the pointer. Each clip swipes sideways over the thread pane, then over the terminal pane.
Firefox, 8 sideways wheel events of 20px with ±1px vertical noise. The strip starts at 226px.
The same synthetic input gets the same result in Chromium. Vertical wheel over the terminal still scrolls about 26 rows of scrollback and leaves the strip where it is, in both browsers.
surface.test.tshas a new case that fails on the layer and passes here.Made with Claude Opus 5.5 in Claude Code.