[flamboh]

Fix for the redesign stack, targets layer 6 (#28845).

Problem

Closing a thread's tab settles the thread when it has stopped and nothing else holds it (not pinned, snoozed, archived, already settled, working, or waiting on an approval or answer). Nothing said so. The tab menu read "Close", the close button's tooltip read "Close tab", and after the close the thread was simply gone from the active list.

Fix

Closing still settles in the same cases. Now it says so first.

One check, threadSettlesOnTabClose, decides whether a close settles. The label and the settle both use it, so they can't disagree.

• Tab menu: "Close and settle" instead of "Close". The ⌘W hint stays on the item.
• "Close others and settle" when any of the other tabs would settle.
• The close button's tooltip: "Close and settle (⌘W)" instead of "Close tab (⌘W)".
• A thread that won't settle (working, waiting for input, pinned, a draft, a surface tab) keeps plain "Close".

The way back hasn't changed: the thread is in Settled, and ⌘Z undoes the settle while the sidebar's undo row is showing.

Before / after

Before (layer 6)	After

• vp run check:changed origin/maria/redesign/6-workspace-panes: format, lint, knip, typecheck, tests and React compiler all pass.
• New case in Sidebar.logic.test.ts covers the settle condition: finished, failed and woken threads settle; running, approval, input, pinned, settled, archived and snoozed threads don't.
• Checked on a Boat dev server with Replay threads. The menu and tooltip said "Close and settle" on the finished thread and "Close" on the one waiting for an answer. Closing the finished tab moved it to Settled, the Settled header pulsed once, and it didn't pulse again after a reload.

Done with Claude Code (Opus 5.5) in T3 Code.

[macroscopeapp]

Approvability

Verdict: Approved at a6557be

Macroscope's review found this PR approvable — Tab menus and close-button tooltips now indicate when closing will settle a thread. The existing settlement conditions remain unchanged and are shared with the labels, keeping the change limited to clearer presentation.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate a6557be

[maria-rcks]

Note

Written by claude-opus-5-5 on behalf of Maria

Thanks for this. We're changing the stack so that closing a tab never settles the thread, which makes the warning unnecessary. Closing this one in favor of that change.