Skip to content

fix(desktop): remove stale AppImage mounts from cached PATH - #30824

Merged
maria-rcks merged 3 commits into
pingdotgg:mainfrom
voltcrash:voltcrash/scrub-stale-appimage-paths
Nov 19, 2026
Merged

maria-rcks merged 3 commits into
pingdotgg:mainfrom
voltcrash:voltcrash/scrub-stale-appimage-paths

Conversation

@voltcrash

@voltcrash voltcrash commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Linux AppImage launches can restore obsolete /tmp/.mount_T3-* directories from a version-1 shell environment cache and pass them into login-shell discovery and the desktop-hosted server. A synthetic cached + inherited PATH reproduces this on current main.

Remove current APPDIR entries and historical T3 mount entries at the desktop cache/discovery boundary: before inherited PATH is used, before cache replay, and before discovered PATH is published or persisted. Keep unrelated paths, mise metadata, and the existing PATH merge policy. The scrubber preserves existing empty entries and deletes PATH when removing its entries leaves none. Non-AppImage and non-Linux launches retain their behavior.

This is a small, focused obvious-bug fix under the contribution exception, with no new product behavior or settings. No upstream maintainer approval is claimed. #16679 and #30688 address current-mount runtime environments at provider spawn; #29672 addresses mount lifetime. This PR only fixes historical PATH contamination in desktop cache/discovery.

Proof on Linux:

  • Before the fix, vp test run src/shell/DesktopShellEnvironment.test.ts -t 'keeps AppImage mounts|does not wait for discovery when the cache is missing' from apps/desktop gives 4 failed, 3 passed, 21 skipped. Failures show stale cache/inherited entries survive and a mount-only PATH remains installed.
  • After: all 28 shell-environment tests pass, including cache replay, probe input, streamed snapshots, persistence, unchanged platform/runtime controls, unrelated AppImage paths, ordering, empty entries, and mise metadata. The existing real Node subprocess fixture remains Darwin-only; the focused service table covers Linux AppImage cleanup.
  • vp run check:changed passes format, lint, both Knip passes, desktop/scripts typechecks, and 28 tests. Commit hooks also pass.

Limits: synthetic AppImage environment on Linux; no packaged AppImage/GUI or native ARM64/macOS/Windows run. Historical matching covers the observed /tmp/.mount_T3-* naming, not renamed AppImages or custom TMPDIR mounts; another AppImage sharing that filename prefix is indistinguishable. Current APPDIR is handled regardless of its location. No filesystem mount removal or performance claim.

Reviewed with review-loop: 1 round with Claude Opus 5.5 on high. Reviewer verdict: approved. No blocker or should findings; known naming limitation documented. Removed the redundant Linux subprocess row following Macroscope Test Signal feedback; implementation unchanged.

Created with GPT-6.1 Sol in the Codex harness.

@github-actions github-actions Bot added vouch:unvouched Author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Nov 4, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 2071690

Macroscope's review found this PR approvable — Removes AppImage mount entries from inherited, cached, and discovered PATH values before they reach desktop subprocesses or are cached again. The cleanup is limited to Linux AppImage launches and leaves unrelated paths and other runtime modes unchanged.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • Resume reviews
  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

On Linux, the shell environment removes AppImage mount paths from inherited, discovered, and cached PATH values when APPIMAGE or APPDIR is set. Tests cover retained paths, empty results, cache updates, startup behavior, and macOS behavior.

Changes: AppImage PATH filtering

Layer / File(s) Summary
Filter AppImage paths across environment sources
apps/desktop/src/shell/DesktopShellEnvironment.ts, apps/desktop/src/shell/DesktopShellEnvironment.test.ts
The shell environment removes APPDIR and its descendants, and paths matching /tmp/.mount_T3-*, from Linux PATH values when APPIMAGE or APPDIR is set. It deletes PATH if no entries remain. Tests cover inherited, discovered, and cached values, startup behavior, and unchanged paths on macOS and Linux without those runtime variables.

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Bug fix

Suggested reviewers: yash-singh1, juliusmarminge

Merge Risk: Minimal · up to 98985

This change removes stale AppImage mount paths from the desktop PATH on Linux and leaves other platforms unchanged. It is covered by focused tests, and no merge-blocking risk is evident.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: removing stale AppImage mount entries from the cached PATH in the desktop shell environment. The raw summary and objectives confirm the change also covers inherited an…
Description check Passed The description follows the template's main sections in substance. It states the problem (stale /tmp/.mount_T3-* entries restored from a version-1 cache), the change at the cache and discovery boundar…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: removing stale AppImage mount entries from the cached PATH in the desktop shell environment. The raw summary and objectives confirm the change also covers inherited and discovered PATH, which the title does not mention, but it is a specific, accurate description of the primary fix.

Full details: Description check

Explanation

The description follows the template's main sections in substance. It states the problem (stale /tmp/.mount_T3-* entries restored from a version-1 cache), the change at the cache and discovery boundary, scope (a small obvious-bug fix with a contribution-exception reference), and verification (specific focused test commands with before/after results, plus Linux-only limits). The template's Verification section asks for focused checks and observed results, and the author supplied both. The description does not include a separate issue link or a maintainer-request statement, but it explains why no issue is needed. Minor deviation: the template's comment that the author should not use the PR body to claim maintainer approval is respected.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 4989fe2 and 989855e.

Files selected for processing: 2

  • apps/desktop/src/shell/DesktopShellEnvironment.test.ts
  • apps/desktop/src/shell/DesktopShellEnvironment.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

@maria-rcks

maria-rcks commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Note

Written by gpt-6.1-sol on behalf of Maria

Verified in a real dev environment

verified head 589c7636b0f15f55c74db33047e8f5f671e9f269 against github/main at 9e85538535c8553901351112ab02dd1dd62db5ee on linux.

used vp i in both checkouts, then ran one desktop dev server at a time with vp run dev:desktop --no-seed. desktop startup owns the changed code, so a standalone web server would bypass it. chrome was driven with the repository's playwright dependency and /usr/bin/google-chrome.

launched electron with APPIMAGE=/tmp/T3-Code.AppImage, APPDIR=/tmp/.mount_T3-Codverify, and an inherited stale /tmp/.mount_T3-Codprevious/usr/bin PATH entry. the real app created its cache. added a project pointing to a real git repository through the ui and ran codex gpt-6.1-sol turns through the local proxy. no mocked provider, seeded database, or hand-written cache was used. stopped main before starting the exact pr head against the same isolated state.

  • main: the stale path survived in the persisted cache, desktop-hosted server, and real codex command output.
  • pr: the stale path was absent from the cache, server startup environment, and codex command output.
  • neighboring behavior: /tmp/.mount_OtherKeep/usr/bin and /opt/keep-tools/bin survived; node and git commands succeeded. a second turn in the same thread repeated the clean result.
  • focused checks through blacksmith: cd apps/desktop && vp test run src/shell/DesktopShellEnvironment.test.ts, 28 passed. existing ci checks are green. no source changes were needed.

runtime command transcript

main: real codex command sees the stale appimage path

pr: the same real codex command sees a clean path and retained unrelated paths

Not verified

a packaged appimage executable and real fuse mount lifecycle were not exercised. this ran the actual electron desktop startup with appimage launch variables and deliberately stale inherited paths. macos, windows, native mobile clients, and other providers were not exercised. no performance claim.

current merge verification

merged github/main at 015eba4083974f8ed86694a8770a4311d8a4714b without rebasing and pushed 989855ee98c29230c49fcc0bb99eecc2df4877f2 to the existing contributor branch. resolved the shell-discovery conflict by keeping main's probe budgets and retries and scrubbing each fresh result before publishing or caching it. no additional behavior or files were added.

the duplicate linux subprocess finding is already addressed by the existing darwin-only case; the review thread is resolved. two independent read-only reviews found no correctness blockers on the merged head.

blacksmith verification on this head passed vp run check:changed 015eba4083974f8ed86694a8770a4311d8a4714b: formatting, lint, both knip passes, affected typechecks, and all 33 shell-environment tests. the focused desktop shell suite also passed all 33 tests. the earlier real-client evidence above was not repeated for this merge commit; packaged appimage/fuse and other platforms remain unverified.

Wladefant

This comment was marked as spam.

@voltcrash
voltcrash force-pushed the voltcrash/scrub-stale-appimage-paths branch from 589c763 to 209d4df Compare November 7, 2026 11:53
@voltcrash
voltcrash force-pushed the voltcrash/scrub-stale-appimage-paths branch from 209d4df to 4989fe2 Compare November 13, 2026 02:32
@maria-rcks
maria-rcks merged commit ab43269 into pingdotgg:main Nov 19, 2026
32 checks passed
@voltcrash
voltcrash deleted the voltcrash/scrub-stale-appimage-paths branch November 19, 2026 05:59
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Nov 19, 2026
**v0.1.11-nightly.20261119.4928** · 60 changes from 30 contributors

- **Antigravity terminal triage.** Choose Antigravity as the agent for terminal triage.
- **Arch Linux ARM installation.** Install stable or nightly T3 Code AUR packages on ARM64.
- **GitHub stack merging.** Agents can merge a GitHub pull request stack at once, avoiding repeated CI runs on each layer.
- **Antigravity slash commands.** Use Antigravity’s native slash commands from the composer, including after a restart.
- **Relink T3 Connect.** Link an environment to a different T3 Connect account after removing its previous link.
- **Claude messages during a turn.** Messages sent while Claude is working no longer get lost or leave the turn hanging.
- **Pull request merge watches.** Agents are notified when a watched pull request merges.

### Plus 49 more bug fixes and performance improvements.

<details>
<summary>Full changelog</summary>

## What's Changed
* fix(web): settings search icons line up with their titles by @Yash-Singh1 in pingdotgg/t3code#38944
* fix(connect): let remote clients with relay configuration link by @juliusmarminge in pingdotgg/t3code#38892
* fix(claude): a background subagent's shell shows its command in Background work details by @nsigel in pingdotgg/t3code#38904
* fix(server): watched PRs wake the agent when they merge by @juliusmarminge in pingdotgg/t3code#26271
* fix(client-runtime): command rows unwrap Windows pwsh -Command and cmd /c launchers by @juliusmarminge in pingdotgg/t3code#38946
* fix(client): resume no longer sends a blank message to older servers by @OmarAlex24 in pingdotgg/t3code#38917
* fix(server): turn starts no longer rescan every attempt per ended run by @navidnadali in pingdotgg/t3code#38825
* fix(server): keep compact Codex launch options in text generation by @Lucenx9 in pingdotgg/t3code#38848
* fix(server): a PR watch the agent owns keeps its thread working until the PR merges by @juliusmarminge in pingdotgg/t3code#38926
* perf(server): task follow-ups no longer read the whole parent thread by @navidnadali in pingdotgg/t3code#38867
* fix(server): Antigravity native slash commands reach the composer after a restart by @juliusmarminge in pingdotgg/t3code#38955
* fix(server): adb-attached Android devices stay listed when avdmanager fails by @juliusmarminge in pingdotgg/t3code#38954
* fix(server): runs no longer stay preparing after a full disk by @Alb11747 in pingdotgg/t3code#28029
* fix(provider-cursor): retry invalid text generation once by @Aforno in pingdotgg/t3code#26056
* fix(desktop): remove stale AppImage mounts from cached PATH by @voltcrash in pingdotgg/t3code#30824
* fix(server): closing a terminal also stops its background jobs by @ruck-syu in pingdotgg/t3code#34444
* fix(server): a revoked T3 Connect link can be relinked to another account by @Derpedyea in pingdotgg/t3code#34194
* fix(server): shadow-home Codex instances keep bundled plugins by @barmatr in pingdotgg/t3code#23668
* fix(server): bound retained VCS status snapshots by @saphid in pingdotgg/t3code#35631
* fix(aur): support ARM64 in stable and nightly packages by @voltcrash in pingdotgg/t3code#30909
* feat(cli): allow Antigravity in terminal triage by @shethshlok in pingdotgg/t3code#31761
* fix(provider-core): bound status probe output while draining pipes by @primevishnu in pingdotgg/t3code#37936
* fix(server): preview and Device Hub streams survive DPoP session renewal by @elias1218 in pingdotgg/t3code#38410
* fix(ssh): an SSH host that already has the matching t3 runs it instead of the portable archive by @felixleopold in pingdotgg/t3code#35268
* perf(server): index historical usage-limit recovery lookups by @omar7550 in pingdotgg/t3code#27896
* fix(antigravity): keep truncated command output valid Unicode by @Lucenx9 in pingdotgg/t3code#38837
* fix(web): a thread that finished while you were away opens at its end by @juliusmarminge in pingdotgg/t3code#38963
* fix(desktop): middle-click paste ignores the GNOME key outside GNOME by @chreko in pingdotgg/t3code#38943
* fix(server): the Claude process poll forgets jobs that have ended by @navidnadali in pingdotgg/t3code#38800
* fix(server): list skills from plugins in the Antigravity instance profile by @juliusmarminge in pingdotgg/t3code#38960
* fix(server): preserve native history in busy Codex forks by @Alb11747 in pingdotgg/t3code#29239
* fix(server): archiving a thread also archives its side chats by @Jacksondr5 in pingdotgg/t3code#32213
* perf(server): sending to a long compacted thread skips its old prompts by @brauliobo in pingdotgg/t3code#36289
* feat(server): agents read, open, update, respond to, and merge PRs through MCP tools by @juliusmarminge in pingdotgg/t3code#26751
* feat(server): agents read failing CI logs and re-run checks through MCP tools by @juliusmarminge in pingdotgg/t3code#26752
* fix(acp): classify web search by title and omit fake filename results by @helmipradita in pingdotgg/t3code#38106
* fix(web): the command palette lists a failed thread as Failed, not Waiting by @juliusmarminge in pingdotgg/t3code#38968
* fix(server): Antigravity resumes after its local harness fails by @pedrosatin in pingdotgg/t3code#23654
* fix(server): Antigravity native slash commands reach the composer by @azygoss in pingdotgg/t3code#35621
* fix(server): Antigravity invoke_subagent calls show as running subagents again by @juliusmarminge in pingdotgg/t3code#38966
* feat(server): agents land a GitHub stack in one merge by @juliusmarminge in pingdotgg/t3code#38973
* fix(web): removing a connection withdraws its permission update notice by @StiensWout in pingdotgg/t3code#38980
* fix(provider-acp): a titleless tool_call_update keeps the tool's name by @juliusmarminge in pingdotgg/t3code#38989
* fix(mobile): a project picked while No project opens is no longer replaced by @StiensWout in pingdotgg/t3code#38978
* fix(server): Windows .cmd launchers work as the Antigravity binary path by @only21mil in pingdotgg/t3code#24683
* fix(azure-devops): refreshing Issues reads each project's current finished states by @StiensWout in pingdotgg/t3code#38986
* fix(web): hiding a revealed email no longer flashes its placeholder by @tiliakoos in pingdotgg/t3code#38996
* fix(client-runtime): a failed issue refresh keeps older comments already loaded by @StiensWout in pingdotgg/t3code#39000
* fix(web): screen readers read a linked issue's key once in thread details by @tiliakoos in pingdotgg/t3code#38995
* fix(web): drawer drops a background terminal closed by another client by @StiensWout in pingdotgg/t3code#38998
* fix(server): read detached Antigravity 1.5 subagent transcripts by @DASungta in pingdotgg/t3code#39004
* fix(client-runtime): file tooltips keep the size after workspace search by @StiensWout in pingdotgg/t3code#39012
* fix(server): report held recurring task occurrences by @dajiaohuang in pingdotgg/t3code#38906
* fix(relay): queued APNs jobs skip delivery when the activity recheck fails by @juliusmarminge in pingdotgg/t3code#38971
* fix(server): cleanup refreshes the size of a kept orphan worktree by @StiensWout in pingdotgg/t3code#39017
* fix(mobile): the compact control no longer clips the composer's provider icon by @juliusmarminge in pingdotgg/t3code#39026
* fix(cli): `t3 auth session revoke` closes the revoked client's open connections by @juliusmarminge in pingdotgg/t3code#38974
* refactor(cli): commands that change state go through a running server by @juliusmarminge in pingdotgg/t3code#38991
* fix(pi): dev servers a Pi agent starts show under its thread by @preinpost in pingdotgg/t3code#39007
* fix(server): an unread Claude steer no longer hangs the turn or gets lost by @Alb11747 in pingdotgg/t3code#39018

## New Contributors
* @barmatr made their first contribution in pingdotgg/t3code#23668
* @shethshlok made their first contribution in pingdotgg/t3code#31761
* @felixleopold made their first contribution in pingdotgg/t3code#35268
* @brauliobo made their first contribution in pingdotgg/t3code#36289
* @helmipradita made their first contribution in pingdotgg/t3code#38106
* @pedrosatin made their first contribution in pingdotgg/t3code#23654
* @azygoss made their first contribution in pingdotgg/t3code#35621
* @DASungta made their first contribution in pingdotgg/t3code#39004
* @dajiaohuang made their first contribution in pingdotgg/t3code#38906
* @preinpost made their first contribution in pingdotgg/t3code#39007

**Full Changelog**: pingdotgg/t3code@v0.1.11-nightly.20261119.4918...v0.1.11-nightly.20261119.4928

</details>


Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.1.11-nightly.20261119.4928
kriegcloud added a commit to beep-effect/t3code that referenced this pull request Nov 19, 2026
…dotgg#30824

Upstream's stripAppImagePaths removes T3 AppImage mounts from the inherited,
cached and discovered PATH, which covers the fork's dd03132 fix for the
installed T3-Code.AppImage. The fork's unconditional `.mount_*` filter broke
upstream's tests by also stripping mounts outside an AppImage runtime and
non-T3 mounts, so take upstream's versions of both files.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched Author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants