You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
perf(server): Windows terminals report exit 0.9 s sooner (PowerShell 1,034 → 138 ms) - #30880
On a Windows host, typing exit (or Ctrl+D, or running a command that ends the shell) in a T3 terminal prints the shell's output at once, but the terminal only reports exited about 1.0 s later. In the drawer, "Process exited" and the tab auto-close wait that second; the onboarding install terminal and the mobile terminal screen leave the same second late.
node-pty's Windows backend cannot see the end of ConPTY's output pipe (ConPTY keeps it open until the pseudoconsole is closed, and node-pty has already dropped the handle when the exit callback runs). So after the shell exits it waits FLUSH_DATA_INTERVAL for trailing output and only then destroys the socket, whose close event emits exit. That interval is 1000 ms.
Measured through the real terminal Manager and NodePtyAdapter on Windows 11 (build 26200), Node 26.12.1, exit typed to the exited event, node-pty 1.2.0-beta.15 as T3 ships it:
shell
main
this PR
PowerShell 5.1
1,034 ms (min 1,024, n=10)
138 ms (min 123, n=10)
cmd
1,016 ms (min 1,007, n=10)
108 ms (min 106, n=10)
The remaining 100 to 140 ms is the shell itself exiting plus the 100 ms window.
Change
Only patches/node-pty@1.2.0-beta.15.patch changes (T3 already patches this file for watch mode and for the console-list helper), plus the regenerated patch hash in pnpm-lock.yaml and a unit test. In lib/windowsPtyAgent.js:
FLUSH_DATA_INTERVAL goes from 1000 to 100.
When the timer fires, the cleanup runs one setImmediate turn later, and only if no data event re-armed the timer in between.
Why 1000 ms exists: node-pty set 20 ms in 2018 (e4c294a) and raised it to 1000 ms in 2020 (e430d82e, "Host conout socket in a worker", the fix for the ConPTY close deadlock, microsoft/node-pty#375). The commit message says ConPTY "can send a final screen update after ClosePseudoConsole", and the conout worker added a second pipe hop. The value was never tuned or measured again.
What it protects is trailing output that conhost renders after the shell process has exited. Over 240 sessions per shell with the stock timer, data still arrived after the exit callback in 240/240 cmd sessions (median 12 ms, max 20 ms) and in 123/240 PowerShell sessions (median 2.8 ms, max 8 ms). 100 ms is 5x the longest tail seen.
Why lowering the constant alone is not safe: Node runs timers before the poll phase. If the main thread is blocked for longer than the interval right after the exit callback (T3 sees sporadic spawn() blocks of 85 to 329 ms and 100 to 200 ms terminal restores), the cleanup timer fires first and outSocket.destroy() discards output that is already sitting in the pipe. cmd prints its last line about 12 ms after the exit callback, so it is lost. With only the constant lowered, cmd's final line was lost in 20/20 runs once the stall reached the interval (stall 150 ms at interval 100; 60 ms at 50; 400 ms at 250). The extra setImmediate turn lets the poll phase read what is buffered first (every chunk re-arms the timer) before the decision, so a stall costs only time. It also removes the same failure mode from stock at a 1.1 s stall (cmd lost its last line in 18/20 runs on stock below).
Linux and macOS are unaffected: node-pty/lib/index.js loads windowsTerminal (and so windowsPtyAgent.js) only when process.platform === 'win32'. Nothing in apps/ or packages/ imports the agent file except tests.
The event-driven fix is upstream: microsoft/node-pty#990 and #991 (both open, unreviewed) close the pseudoconsole on natural exit so the pipe EOF ends the session about 60 ms after the shell exits. That needs a native conpty.cc change and new prebuilds, which T3 cannot take through patches/. If either lands, this patch should be dropped.
Scope and approval
I described this first in Ideas discussion #30872. There's no maintainer reply there yet, so I'm submitting it as a small, focused fix for an obvious defect: the terminal reports that the shell exited a second after it did, because of a fixed wait in node-pty's Windows agent. The change is two edits to lib/windowsPtyAgent.js inside the patch T3 already carries, plus its regenerated lockfile hash and a test in apps/server/src/terminal. No product source changes. It does change timing, as described below. If you'd rather settle it in the discussion first, I'm happy to close this.
Behaviour differences, stated plainly:
exited is emitted about 0.9 s earlier on Windows for every natural shell exit.
Output that conhost produces more than 100 ms (plus one loop turn) after the exit callback is no longer delivered. Not reproduced here (see below), but a pathologically slow or starved conhost could do it; before, the limit was 1000 ms.
Windows builds before 24H2, ARM, PowerShell 7 and useConptyDll were not tested (useConptyDll skips this timer entirely).
Verification
Harness: the real apps/server/src/terminal/NodePtyAdapter.ts and Manager.ts on the installed, patched node-pty (vp i regenerated the lock hash; node_modules/node-pty/lib/windowsPtyAgent.js has the change), real PowerShell 5.1 and cmd, with a stock copy of the package (patch state of main) alternating with the patched one. A lost line means the unique last line was missing from the output; for big writes the exact count of payload characters is also checked. Stalls are injected with Atomics.wait on the main thread right after the exit callback.
Results (lost = unique last line, or any payload character, missing from the output; time = exit callback to exit/exited, median and min..max):
scenario (patched unless noted)
PowerShell 5.1
cmd
exit typed to exited through the Manager, stock
1,034 ms (1,024..1,040), n=10
1,016 ms (1,007..1,017), n=10
same, patched
138 ms (123..140), n=10
108 ms (106..111), n=10
final line then exit, adapter, stock
1,010 ms, 0/30 lost
1,022 ms, 0/30 lost
same, patched
111 ms (101..116), 0/60 lost
119 ms (103..121), 0/60 lost
1 MB / 10 MB / 50 MB then exit
0/30, 0/15, 0/5 lost
0/30, 0/15, 0/5 lost
output, 300 ms pause, last line, exit
0/20 lost
0/20 lost
main thread blocked 30 / 150 / 400 / 1,100 ms right after the exit callback, final line
0/20 each
0/20 each
same through the Manager (stalls 0 / 150 / 400 / 1,100 ms)
0/10 each
0/10 each
10 MB with a 400 ms stall
0/10 lost
0/10 lost
stock with 150 / 400 / 1,100 ms stalls
0/20 each
0/20, 0/20, 18/20 lost at 1,100 ms
40 busy loops at BelowNormal (CPU-starved conhost), final line
0/60 lost (stock 0/40)
0/60 lost (stock 0/40)
same, 10 MB / slow tail / Manager final line
see below
0/15, 0/20, 0/15 lost
Under the CPU-starved run the PowerShell Manager, 10 MB and slow-tail rows did not complete: PowerShell 5.1 itself took 5 to 14 s to start and run a command, so the harness timed out before sending exit (12/15 Manager runs, 2/4 big runs) and the run was stopped at its time limit. No completed run in that cell lost output, but it is not evidence for those rows.
Unit tests (apps/server/src/terminal/nodePtyFlushDataAndCleanUp.test.ts, run on any OS because the agent file is plain JS; they replace the global timer functions with a tiny loop that places the poll phase between the timer and check phases): cleanup 100 ms after the exit and not before; more data restarts the window; buffered data read right after a stalled timer expiry keeps the socket open; cleanup after a stall when nothing was buffered; nothing runs with useConptyDll. All 5 pass on this branch; run against the unpatched agent file (main's patch) 4 of 5 fail. vp test run src/terminal in apps/server on Windows, Node 26.12.1: 5 files, 105 tests pass (this includes NodePtyAdapter, the terminal Manager and nodePtyConsoleList, the other test that loads the patched agent). vp fmt and vp lint on the new test are clean; typecheck was not run.
Not checked: a UI run (the lingering tab is read from ThreadTerminalDrawer.tsx, not observed; no screenshots), Windows before 24H2, ARM, PowerShell 7, the packaged Electron server, Defender-off, and real (non-injected) server stalls.
Claude Sonnet 5.5 and Claude Opus 5.5 in T3 Code (Claude Code harness).
node-pty waited FLUSH_DATA_INTERVAL = 1000 ms after the shell exited before closing the ConPTY output socket and emitting exit, so the terminal showed Process exited a second late. Wait 100 ms instead, and run the cleanup one setImmediate turn after the timer fires so output already buffered in the pipe is read first after a main-thread stall (lowering the constant alone loses cmd's final line when a stall exceeds the interval).
Macroscope's review found this PR approvable — Windows terminals report exit sooner by shortening the output-flush delay, while deferring cleanup to let buffered output arrive. The scoped change is limited to terminal shutdown timing and retains output-driven postponement of cleanup.
You can add or adjust custom eligibility rules. Learn more.
Reviewing files that changed from the base of the PR and between 391d864 and de2c2ad.
Files ignored due to path filters: 1
pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Walkthrough
The Windows node-pty patch shortens the output flush interval from 1000 ms to 100 ms and defers cleanup by one event-loop turn. Tests simulate event-loop phases and verify output-socket cleanup timing.
Changes: Windows node-pty output cleanup
Layer / File(s)
Summary
Flush timeout and cleanup behavior patches/node-pty@1.2.0-beta.15.patch
The flush interval changes to 100 ms. Cleanup runs on the next immediate turn and skips stale timeouts when a later flush re-arms the timeout.
Flush timing and cleanup tests apps/server/src/terminal/nodePtyFlushDataAndCleanUp.test.ts
Tests simulate timers, polling, and immediates. They check that the socket remains open at 99 ms, is destroyed at 100 ms, and is not destroyed immediately when buffered output arrives after a stall. They also check cleanup after a stall without new output.
This change makes Windows terminals report shell exit much faster, about 100 ms instead of about 1 second. No concrete defect was found. Late output arriving after the shortened window could be dropped, which is a stated tradeoff.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the primary change: Windows terminals report shell exit about 0.9 s sooner, backed by the PowerShell timing figures. It follows the conventional commit format. The title does not menti…
Description check
The description follows the template. It has Problem, Change, Scope, and Verification sections, and each is filled in with specific detail. Verification gives focused tests, measured results, and the …
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the primary change: Windows terminals report shell exit about 0.9 s sooner, backed by the PowerShell timing figures. It follows the conventional commit format. The title does not mention the test or the lockfile update, which is expected.
Full details: Description check
Explanation
The description follows the template. It has Problem, Change, Scope, and Verification sections, and each is filled in with specific detail. Verification gives focused tests, measured results, and the unchecked areas. It also names the agent model and harness. The Scope section explains the missing maintainer approval and links a discussion. The description does not repeat the template's conventional-commit title guidance, which is a minor point.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
On the same Windows Server 2025 build 26100 machine with PowerShell 5.1 and Node 26.13.1, run 15 fresh terminals per commit through the real server's WebSocket RPC. Wait for the prompt, wait 300 ms, submit echo FINAL_LINE_<id>; exit, and measure receipt of final output and exited.
On the same Windows Server 2025 host (10.0.26100), Node 26.13.1 and PowerShell 5.1, start each commit's real server with fresh isolated state. For 15 new terminals per side, wait for the prompt plus 300 ms, submit echo FINAL_LINE_<id>; exit, and measure final output and exited over the authenticated client WebSocket.
Final-line median 99 ms; installed flush interval 1,000 ms
Final-line median 89 ms; installed flush interval 100 ms
The median improves by 914 ms (81.2%), exceeding both run spreads (61 and 32 ms). All 30 runs delivered the complete final output line before exited and returned exit code 0.
The exact Windows 11 build 26200 / Node 26.12.1 figures were not measured; the available Windows Server 2025 / Node 26.13.1 host measured 212 ms on head.
Cmd timing was not measured; the reproduced client path selected PowerShell and exposes no shell selector.
Terminal drawer closing was not observed visually; measurements cover the real client-protocol exited event.
Watch-mode helper handling and output preservation during a long event-loop stall were not exercised by this reproduction.
* fix(web): opening a very large folder no longer freezes the Files panel (pingdotgg#29996)
Co-authored-by: Nathan Wong <20381195+thelogicmatrix@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(gitlab): a fork's same-named branch no longer hides the branch's own merge request (pingdotgg#29791)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(editors): Open in Zed no longer finds the ZFS event daemon (pingdotgg#33461)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): preview hover and drag fail within their timeout, not up to 3x later (pingdotgg#33550)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): skills from CLAUDE_CODE_PLUGIN_DIRS plugins show in the composer (pingdotgg#33341)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(gitlab): `glab mr new` links the new merge request to the thread (pingdotgg#33475)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(mobile): Android section headers show the collapse arrow when expanded (pingdotgg#33513)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(claude): tools running at Stop show as stopped, not failed (pingdotgg#29801)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): a pull request whose title holds a numeric search ranks above description-only matches (pingdotgg#33692)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(acp-registry): a uv-installed agent launches its managed command, not a same-named one on PATH (pingdotgg#33836)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): refuse unresolved UTF-16 merge commits (pingdotgg#36817)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): remove worktrees through their owning repository (pingdotgg#33586)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): RTF attachment text keeps joiners and direction marks (pingdotgg#36824)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): scheduled tasks in a non-Git project run in its folder instead of failing (pingdotgg#36821)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): deleting a thread with side chats offers to delete its worktree (pingdotgg#36800)
Co-authored-by: Alex Southwell <4596216+saphid@users.noreply.github.com>
* perf(web): completed Markdown blocks no longer render twice (pingdotgg#33794)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* perf(web): opening a thread from a draft only renders its sidebar row (pingdotgg#33435)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(usage): refetch cached rates early for a model they do not list (pingdotgg#33725)
Co-authored-by: DrSeedon <DrSeedon@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): copied email links keep their destination (pingdotgg#36830)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): message search finds smart apostrophes when scanning (pingdotgg#36832)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(shared): preserve whitespace in POSIX PATH directories (pingdotgg#33840)
Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): dropdown hover fills expanded Git action rows (pingdotgg#35527)
Co-authored-by: brkgzlsy <berke.guzelsoy@fabrite.ch>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(clients): undoing a settle puts the thread back where you placed it (pingdotgg#33248)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): queued images open in the image viewer (pingdotgg#33298)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(mobile): removing an environment drops its threads from Android launcher shortcuts (pingdotgg#33726)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): a zero Git fetch interval also stops the status upstream fetch (pingdotgg#33845)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(ssh): include hosts from wildcard filenames with line separators (pingdotgg#35479)
Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): preserve DOCX non-breaking hyphens in attachment text (pingdotgg#36845)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): diff file tree shows added and deleted files before their patches load (pingdotgg#33310)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): audio and server spinners respect reduced motion (pingdotgg#33795)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): provider switches on portable forks keep inherited conversation (pingdotgg#36839)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): show Browser device preferences read-only for projects (pingdotgg#36846)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(cli): t3 connect unlink with T3 stopped also clears the webhook hold setting (pingdotgg#33822)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): decode escaped XLSX attachment text (pingdotgg#36849)
Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(desktop): recover prepared remote updates on retry (pingdotgg#33605)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): OpenCode keeps its cached models when a cold probe lists none (pingdotgg#33640)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): retain custom model drafts until saved (pingdotgg#35176)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): trackpad scrolling no longer stalls on gaps between right panel tabs (pingdotgg#35255)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): Settings > Projects list follows the selected environment (pingdotgg#36856)
* fix(web): pasted images stay at their original insertion point (pingdotgg#35528)
Co-authored-by: brkgzlsy <berke.guzelsoy@fabrite.ch>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): Cite is offered for text an agent sent with send_to_user (pingdotgg#36858)
* fix(web): desktop browser tabs show native navigation immediately (pingdotgg#35299)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): a steer that misses its turn moves into the run it starts (pingdotgg#36855)
* fix(server): keep boolean XLSX cells as true/false in extracted text (pingdotgg#35191)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(desktop): tolerate disk-full console output (pingdotgg#35245)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(dev): first dev start builds the missing resource monitor (pingdotgg#34975)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): a failed comments read no longer hides PR check updates (pingdotgg#33452)
Co-authored-by: Emi Griffith <emi.g@jinemi.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(mobile): typing before a chip no longer leaves the iOS caret behind (pingdotgg#33774)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* perf(server): git status refresh reads local status once unless refs moved (pingdotgg#29155)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): a setting change no longer detaches a busy session kept from an earlier hand-off (pingdotgg#35258)
Co-authored-by: Mika Hertler <mika@mikahertler.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): storage cleanup removes idle worktrees whose branch was renamed or switched (pingdotgg#34984)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(claude): rename the native session when the thread title changes (pingdotgg#34775)
Co-authored-by: kumar-karan <kumar-karan@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(desktop): an emptied browser cookie jar imports as empty instead of failing (pingdotgg#34698)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): each websocket RPC starts its own trace so Tempo keeps its spans (pingdotgg#36863)
* fix(mobile): compaction notice becomes a chip in the composer (pingdotgg#36872)
* fix(web): repeated diff blocks no longer crash the viewer (pingdotgg#35304)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): copied literal Markdown sends as shown (pingdotgg#36867)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): move to Node 26.13.1 without migrations storing JSON arrays as strings (pingdotgg#34576)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* perf(server): skip the full untracked scan when Git status shows none (pingdotgg#36870)
* fix(server): show Claude's root refusal when it exits before the turn starts (pingdotgg#34621)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): keep a launched thread's title when its first message arrives (pingdotgg#35117)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* perf(server): the next turn no longer waits for the previous turn's git status refresh (pingdotgg#32349)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
* fix(server): queued messages no longer wait behind every later delegate completion (pingdotgg#34620)
Co-authored-by: Apex-ICP <jesse@apexicp.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(mobile): a link during video playback no longer rebuilds the open thread (pingdotgg#34990)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* test(web): terminal drawer test keeps its session atoms across GC (pingdotgg#36888)
* fix(server): switching the Claude model no longer blocks a later provider switch (pingdotgg#34498)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): a worktree launch from a missing base branch names the branch (pingdotgg#34452)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): Claude /rename now retitles the T3 thread (pingdotgg#36879)
* fix(web): open editors when saving their preference fails (pingdotgg#34308)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* feat(client): add-project folder search matches substrings and fuzzy subsequences (pingdotgg#26376)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Yash Singh <saiansh2525@gmail.com>
* fix(web): typing in the file editor no longer jumps to the prompt (pingdotgg#35122)
Co-authored-by: user <user@qubes-os.org>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): keep thread find working with many matches in one row (pingdotgg#34402)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): Arabic and Hebrew folds in chat read right to left (pingdotgg#36876)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(mobile): iOS composer text follows the system text size (pingdotgg#34670)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): turn recovery covers interrupted and cancelled runs' abandoned turns (pingdotgg#34639)
Co-authored-by: Ali-Al1 <Ali-Al1@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): show TAR hard links in archive previews (pingdotgg#34329)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): preserve ODF paragraph whitespace in agent sidecars (pingdotgg#36883)
Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* perf(web): trim terminal link delimiters in linear time (pingdotgg#34397)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(shared): preserve Unicode during command output overwrites (pingdotgg#34332)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): a self-settle survives a queued message steered into the turn (pingdotgg#36896)
* fix(server): queued-input index no longer rejects user messages with non-JSON payloads (pingdotgg#36898)
* fix(server): filter scheduled tasks without exposing webhook URLs (pingdotgg#27716)
Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): distinguish media Back from window close (pingdotgg#33125)
* fix(mobile): VoiceOver names the iOS message box (pingdotgg#34658)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): PR sync backs off links on hosts it cannot read (pingdotgg#36901)
* perf(web): skip oversized TAR preview payload copies (pingdotgg#34301)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): voice cleanup pinned to an ACP provider uses the text model (pingdotgg#36912)
* fix(server): Swift TestFlight clients can read settings again (pingdotgg#26455)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(github): Load more no longer stalls on a full page of equal update times (pingdotgg#36910)
* fix(desktop): preserve recordings saved in the same millisecond (pingdotgg#34314)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(client): refresh open archive when threads are archived elsewhere (pingdotgg#36909)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): keep files when submodule checks retain a worktree (pingdotgg#34196)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): copying from a later list item keeps its numbers (pingdotgg#36915)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): a failed turn start no longer leaves the thread stuck starting (pingdotgg#14424)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: SAPHID <saphid@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): successive custom model saves keep earlier edits (pingdotgg#36906)
Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): restore word selection in inline code (pingdotgg#36936)
* fix(server): recognize Windows Volta provider installs (pingdotgg#36917)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): showing a composer banner no longer makes the page restyle everything until reload (pingdotgg#34537)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(install): launch t3 by absolute path (pingdotgg#13794)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* perf(server): Windows process launches no longer block the RPC thread (pingdotgg#32260)
Co-authored-by: Lakshmi Tanmay <lakshmi@voltcrash.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): more GitLab merge request links open their file, line or commit (pingdotgg#34662)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(opencode): show background replies after a turn settles (pingdotgg#36887)
Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): conventional commit subjects start lowercase (pingdotgg#36938)
* fix(shared): stop rescanning unclosed TeX math (pingdotgg#34398)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): Arabic and Hebrew artifact template cards read right to left (pingdotgg#36922)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): stop leaving Codex plan items running after their run (pingdotgg#22617)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* perf(gitlab): MR watches check a one-query fingerprint before full reads (pingdotgg#34638)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): font picker scrolls to every font in short windows (pingdotgg#22795)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(source-control): repository paths match however their names are percent-encoded (pingdotgg#36929)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(mcp): return delegated task handles before client timeouts (pingdotgg#15622)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): allow tooltip text to wrap naturally (pingdotgg#36948)
* fix(preview): unload desktop pages before removing their tabs (pingdotgg#35135)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): remove redundant status info icon (pingdotgg#36947)
* fix(desktop): agent snapshots keep full detail in narrow and mini previews (pingdotgg#36944)
* test(web): pin the minute clock in the sidebar jump-hint render test (pingdotgg#36954)
* fix(acp-registry): models show the reasoning levels the agent advertises for them (pingdotgg#36950)
Co-authored-by: 0xpolarzero <0xpolarzero@gmail.com>
* fix(web): enable Send when the composer holds only a thread context (pingdotgg#23166)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): thread details card no longer jumps mid panel animation (pingdotgg#22614)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web,mobile): /btw and /side drafts show the send arrow while a turn runs (pingdotgg#36932)
* fix(server): migrated databases can return freed space to disk (pingdotgg#30066)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(devices): rename EAS Simulator to Expo Simulators (pingdotgg#36951)
* fix(server): find the EAS project of variant app configs (pingdotgg#29466)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): include untracked files when Git config hides them (pingdotgg#23134)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web,server): picking the previous branch after an agent's checkout switches back (pingdotgg#30107)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): t3_thread_list leaves out tasks delegated from a linked environment (pingdotgg#36961)
* fix(server): prune checkpoint refs owned by deleted threads (pingdotgg#24140)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(mobile): screen readers hear a thread row's status and time (pingdotgg#34636)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): isolate Linux process launches from the RPC event loop (pingdotgg#30209)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* perf(server): Pull no longer waits behind other repositories' fetches (6.3 s → 0.21 s median) (pingdotgg#30059)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(wsl): label WSL environments with their Windows host on every client (pingdotgg#22629)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(azure-devops): derive CLI scope from checkout remotes (pingdotgg#21838)
Co-authored-by: Ved Pandey <vedprakash2302@gmail.com>
* fix(server): subagent threads no longer show the remote parent their parent was delegated from (pingdotgg#30334)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): t3_thread_launch worktrees honor the new-worktree setting (pingdotgg#30226)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* perf(server): text-only browser snapshots skip the PNG encode (66 ms → 20 ms median) (pingdotgg#30305)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): diff Copy path uses Windows separators in a Windows workspace (pingdotgg#30394)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(opencode): usage totals include what OpenCode 2 spends on compaction (pingdotgg#30565)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): opening a project or deleting the open thread skips delegated tasks (pingdotgg#30428)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* chore(web): upgrade @pierre/diffs to 1.7.0-beta.4 and drop patched find (pingdotgg#36974)
* fix(server): keep Vietnamese words readable in scratch folder names (pingdotgg#30311)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(client-runtime): a line of inline triple-backtick code no longer breaks media in PR descriptions (pingdotgg#30571)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): preserve thread identity across composer pastes (pingdotgg#30583)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(opencode): pages a Code Mode script publishes now show inline (pingdotgg#30492)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(cursor): preserve recognized transport failure diagnostics (pingdotgg#30631)
Co-authored-by: Trevor Edwards <9443483+trevoedwards@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(client-runtime): a disconnected machine's scratch folder no longer lists as a second "No project" (pingdotgg#30597)
Co-authored-by: DanielJBurbridge <36094258+DanielJBurbridge@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(mobile): iOS tab bar no longer covers a thread opened from the Usage tab (pingdotgg#36975)
* fix(cursor): stream Task subagent work into child threads live (pingdotgg#30539)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): app loads in browsers without URL.canParse or URL.parse (pingdotgg#36973)
* fix(server): preserve the crash recovery budget across restarts (pingdotgg#25603)
Co-authored-by: Tin Zeljar <35663757+Zheruel@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): Claude goals no longer re-prompt while a delegated task will wake the thread (pingdotgg#30646)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(codex): preserve terminal connection failure categories (pingdotgg#30639)
Co-authored-by: Trevor Edwards <9443483+trevoedwards@users.noreply.github.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(client-runtime): derive MCP download names before URI suffixes (pingdotgg#30712)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(desktop): providers are found after a failed shell probe without relaunching (pingdotgg#30667)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* feat(themes): theme CSS can hold 50,000 characters (pingdotgg#36656)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(web): diff file Open and Reveal reach a file whose name has a backslash (pingdotgg#23167)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(release): enforce packaged Linux glibc requirements (pingdotgg#30827)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(client-runtime): tool output no longer rounds integers beyond 2^53 (pingdotgg#30806)
Co-authored-by: Geezy <igor.licko@gloryck.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(gitlab): remove reactions beyond the first award page (pingdotgg#30700)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): let Expo decide EAS Simulator access (pingdotgg#29490)
Co-authored-by: Hirbod Mirjavadi <hirbod@expo.dev>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* perf(azure-devops): opening a pull request no longer reads it twice (pingdotgg#29918)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(shared): the SQLite reader pool comes back after a failed start (pingdotgg#30818)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): keep history-placed guest messages out of the footer (pingdotgg#30718)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(shared): keep Windows path separators beside ampersands (pingdotgg#36977)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(cli): keep log warnings out of JSON output (pingdotgg#30898)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web,mobile): a late MCP app teardown no longer closes the app that replaced it (pingdotgg#30387)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): Grok usage counts turns from resumed sessions (pingdotgg#30694)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* test(desktop): wait for the published PATH after a fallback-shell retry (pingdotgg#36991)
* fix(server): checkpoint restore reverts edits inside submodules (pingdotgg#30829)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* perf(server): delegated tasks start and finish without reading the whole parent thread (pingdotgg#34551)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(pi): resume attached sessions without reloading extensions (pingdotgg#21512)
Co-authored-by: Julian Rustig <jruestig@posteo.de>
* fix(provider-acp): a cancel no longer overtakes the prompt it cancels (pingdotgg#30846)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): wake GitLab MR watches when a rebase is required (pingdotgg#30312)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): drain queued native child continuations (pingdotgg#21461)
Co-authored-by: Exotic209093 <134711311+Exotic209093@users.noreply.github.com>
Co-authored-by: Issue triage verification <triage@localhost>
* fix(web): a send that finishes after you leave its thread no longer blanks the open thread's composer (pingdotgg#30947)
Co-authored-by: Isaac-b-ux <264455269+Isaac-b-ux@users.noreply.github.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(mobile): Android menus opened over the keyboard close when it hides (pingdotgg#30853)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(client-runtime): omit machine labels from relay spans (pingdotgg#30940)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): MCP list tools clamp an oversized limit instead of failing (pingdotgg#30976)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* perf(web): collapse all no longer remounts the diff viewer (pingdotgg#36995)
* fix(server): skip Codex page context in imported titles (pingdotgg#31090)
Co-authored-by: flexi767 <flexi767@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): renaming a sidebar thread no longer shifts the row or covers it with the hover card (pingdotgg#31009)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* perf(server): resolve model aliases in one memoized traversal (pingdotgg#31197)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* perf(relay): reconcile multiline env values without rescanning prefixes (pingdotgg#31196)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): terminals start a $SHELL whose path contains a space (pingdotgg#30969)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(desktop): a waiting update is no longer re-announced on every poll (pingdotgg#31154)
Co-authored-by: Taylor Dolezal <117500+onlydole@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(acp): replace and remove identified plans across turns (pingdotgg#36978)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): streamed replies keep updating after a line that starts with inline triple-backtick code (pingdotgg#30966)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(provider-cursor): advertise manual compaction (pingdotgg#31203)
Co-authored-by: Yaroslav Litkovych <yaroslav.litkovych@tamara.co>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): preserve published theme IDs during alias lookup (pingdotgg#31318)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(mobile): iOS image viewer pages and dismisses after slow opens (pingdotgg#36862)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* test(server): stop Git auto-maintenance racing the shared repo template copy (pingdotgg#37012)
* fix(server): Open in and Reveal open ~/ file links from projects outside the home folder (pingdotgg#31246)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* perf(server): Windows terminals report exit 0.9 s sooner (PowerShell 1,034 → 138 ms) (pingdotgg#30880)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): up-arrow recall keeps thread and machine mentions (pingdotgg#31314)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): choosing a provider in the model picker no longer raises the phone keyboard (pingdotgg#36999)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(cursor): resume stopped turns with Cursor's native resume action (pingdotgg#36918)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(web): an unreachable environment no longer hides pull requests from repositories it shares (pingdotgg#34088)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): honor right panel state in custom shortcuts (pingdotgg#34081)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(shared): decode URI paths in ghq clone folders (pingdotgg#37004)
Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): overlapping image pastes keep their prompt order (pingdotgg#37010)
Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): show failed desktop downloads in retry tooltips (pingdotgg#31324)
Co-authored-by: johan vaz <johanvaz@Nathalines-MacBook-Pro.local>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* perf(right panel): normalize pr tab target once (pingdotgg#37002)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(marketing): prevent harness-grid content overflow on mobile devices. (pingdotgg#31459)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(mobile): diagonal thread-row swipes open on Android instead of scrolling the list (pingdotgg#37011)
* fix(web): focus side-chat composer when selecting its tab (pingdotgg#31360)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(claude): show monitor commands in background work details (pingdotgg#37019)
* fix(web): thread chips in the composer can no longer be dragged out as links (pingdotgg#31541)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): show drag preview inside sidebar search results (pingdotgg#37022)
* perf(desktop): the remote editor list appears in 62 ms instead of 2.5 s (17 editors, 58 PATH entries, Windows) (pingdotgg#31033)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(codex): crashed handlers and transport workers no longer hang silently (pingdotgg#31192)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(mobile): an answered question no longer shows its raw item JSON (pingdotgg#31330)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* perf(server): message ordinals are read through an index, not a scan (pingdotgg#30873)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* perf(web): batch middle truncate fits (pingdotgg#37001)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): prevent stray highlights when selecting shell commands (pingdotgg#37024)
* fix(desktop): Check for Updates says when an update is available (pingdotgg#31957)
* fix(web): right panel shortcuts work while a side chat has focus (pingdotgg#32117)
* feat(github): issues and PRs from denounced authors close when opened (pingdotgg#37017)
* fix(server): threads show the new branch's pull request after a branch switch (pingdotgg#32042)
* fix(server): preserve run start time when steering restarts a turn (pingdotgg#31640)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(cli): t3 project add brings back an archived project instead of refusing it (pingdotgg#31661)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): track switch no longer blocked when Local environment is off (pingdotgg#32048)
* fix(web): reopened composer drafts keep quote spacing and show the caret (pingdotgg#31880)
* fix(server): SSH device host probe failures say what ssh refused (pingdotgg#31695)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(provider-acp): Grok runs complete when a background dev server keeps running (pingdotgg#32109)
* fix(server): parallel worktree launches no longer leave all but one branch on its t3/ name (pingdotgg#31662)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(client): avoid worktree setup flash after editing first message (pingdotgg#31738)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(codex): an app-server that exits before initialize reports its exit, not EPIPE (pingdotgg#37029)
* fix(server): count only newly imported agent threads (pingdotgg#37025)
Co-authored-by: Federico Lomurno <275704276+flomurno@users.noreply.github.com>
* fix(usage): a Claude hub account with an unmeasured window keeps its other limits (pingdotgg#31748)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): thread_not_found points agents at linked environments (pingdotgg#31946)
* perf(web): Expand all folders in the diff file tree no longer rescans every folder for each expansion (pingdotgg#31465)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): a send to an idle thread with a queue now waits behind it (pingdotgg#33857)
* fix(shared): recognize SSH remotes with a single path component (pingdotgg#31781)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(mobile): grouped projects show their own monogram in the picker and draft rows (pingdotgg#31195)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(shared): file mentions of __init__.py keep their name as the label (pingdotgg#31593)
Co-authored-by: Matyas Rathonyi <matyasrathonyi@imac-server2.tailacc4a3.ts.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): delegate_task model refusals name slugs to retry with (pingdotgg#31905)
* fix(server): clearing a terminal that keeps printing no longer hangs (pingdotgg#31752)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(shared): preserve Git remote headers after comments (pingdotgg#31788)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): dictionary spellings apply next to Chinese and Japanese text (pingdotgg#31780)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): MCP tools no longer advertise non-string enums that Gemini rejects (pingdotgg#37031)
* fix(server): re-base worktree launches whose recorded base ref does not resolve (pingdotgg#31747)
Co-authored-by: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): expand viewed checkbox click area (pingdotgg#37033)
* fix(web): Shift+F6 moves from a side chat back to the main chat (pingdotgg#31931)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): check out cloned submodules when one submodule clone fails in a new worktree (pingdotgg#37030)
* fix(server): MCP send errors say how to continue a finished thread (pingdotgg#31908)
* fix(server): open WSL-mounted Windows drives directly in File Explorer (pingdotgg#31816)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): PR watch wakes quote a bot comment's text, not its HTML (pingdotgg#37032)
Co-authored-by: Taylor Dolezal <117500+onlydole@users.noreply.github.com>
* fix(web): opening a project from the command palette skips settled and snoozed threads (pingdotgg#31894)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): the PDF preview says "1 / 1 page" for a one-page PDF (pingdotgg#31885)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): setup script output no longer shows stray bytes of escape sequences (pingdotgg#31882)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): the SQLite, archive and notebook previews say "1 row", "1 entry" and "1 cell" (pingdotgg#31886)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
---------
Co-authored-by: Nathan Wong <thelogicmatrix@gmail.com>
Co-authored-by: Nathan Wong <20381195+thelogicmatrix@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Alex Southwell <saphid@gmail.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Daniel Dewhurst <danjdewhurst@users.noreply.github.com>
Co-authored-by: Victor <satsdev@only21mil.xyz>
Co-authored-by: David Mendes <david.mendes@outsystems.com>
Co-authored-by: Arav Jain <aravhawk@gmail.com>
Co-authored-by: juccul <101457938+juccul@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ibrahim Elkamali <igrimanigroman@gmail.com>
Co-authored-by: Wout Stiens <71498452+StiensWout@users.noreply.github.com>
Co-authored-by: Luis Taniça <matallui@gmail.com>
Co-authored-by: Bryan Clark <5405766+moenzuel@users.noreply.github.com>
Co-authored-by: Alex Southwell <4596216+saphid@users.noreply.github.com>
Co-authored-by: Lakshmi Tanmay <lakshmi@voltcrash.com>
Co-authored-by: Dominik Žabčík <35886301+dominikzabcik@users.noreply.github.com>
Co-authored-by: Maxim <65215214+DrSeedon@users.noreply.github.com>
Co-authored-by: DrSeedon <DrSeedon@users.noreply.github.com>
Co-authored-by: Simone <lucenz@proton.me>
Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com>
Co-authored-by: Dragesia <69815671+Dragesia@users.noreply.github.com>
Co-authored-by: brkgzlsy <berke.guzelsoy@fabrite.ch>
Co-authored-by: OpeOginni <107570612+OpeOginni@users.noreply.github.com>
Co-authored-by: Mateusz Choma <chomamateusz@gmail.com>
Co-authored-by: Baptiste Arnaud <baptiste@typebot.io>
Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Amman <ammanuelamsal@gmail.com>
Co-authored-by: project516 <138796702+Project516@users.noreply.github.com>
Co-authored-by: Byntham <135178921+Byntham@users.noreply.github.com>
Co-authored-by: rafi-the-dev <rafisleep570@gmail.com>
Co-authored-by: Fuksss <fuxik12345@gmail.com>
Co-authored-by: Unlock Digital Media <134563073+unlockdigital@users.noreply.github.com>
Co-authored-by: Jon Duea <jdueadev@gmail.com>
Co-authored-by: Emi Griffith <emerytgriffith@gmail.com>
Co-authored-by: Emi Griffith <emi.g@jinemi.com>
Co-authored-by: Arun Krishnamurthy <arun.km.279@gmail.com>
Co-authored-by: Andrei <108398860+Yuruzuu@users.noreply.github.com>
Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
Co-authored-by: Mika Hertler <77012401+MikaMcFlurry@users.noreply.github.com>
Co-authored-by: Mika Hertler <mika@mikahertler.com>
Co-authored-by: Alex Hatzenbuhler <hatz@hey.com>
Co-authored-by: Karan Kumar <karan.8080dev@gmail.com>
Co-authored-by: kumar-karan <kumar-karan@users.noreply.github.com>
Co-authored-by: Julio Saldaña <102325762+wincrack07@users.noreply.github.com>
Co-authored-by: Jake Leventhal <jakeleventhal@me.com>
Co-authored-by: Sohaib Ali <43256484+SohaibAli9@users.noreply.github.com>
Co-authored-by: Noah <105475352+Noah-mh@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Jesse-pink-lab <co.breakingbits@gmail.com>
Co-authored-by: Apex-ICP <jesse@apexicp.com>
Co-authored-by: Chirag Agggarwal <96696271+Schreezer@users.noreply.github.com>
Co-authored-by: Dmitry Farafonov <mail.xaber@gmail.com>
Co-authored-by: Michael Bennett <mishdotdev@gmail.com>
Co-authored-by: Romil <romilbij@gmail.com>
Co-authored-by: Christoffer Artmann <Artgaard@gmail.com>
Co-authored-by: Yash Singh <saiansh2525@gmail.com>
Co-authored-by: Christian R. Kounatze <chreko@gmx.net>
Co-authored-by: user <user@qubes-os.org>
Co-authored-by: nasser <63818147+newer97@users.noreply.github.com>
Co-authored-by: MarcoDotIO <Marcus.Arnett10@gmail.com>
Co-authored-by: Ali-Al1 <11404482+Ali-Al1@users.noreply.github.com>
Co-authored-by: Ali-Al1 <Ali-Al1@users.noreply.github.com>
Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: SAPHID <saphid@users.noreply.github.com>
Co-authored-by: Alex Vallone <39172404+amv146@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Theo Browne <me@t3.gg>
Co-authored-by: Dara Adedeji <76637177+SunkenInTime@users.noreply.github.com>
Co-authored-by: Antony <97451137+TonybynMp4@users.noreply.github.com>
Co-authored-by: grey-tsosie <45133231+grey-tsosie@users.noreply.github.com>
Co-authored-by: Pavel Kroupa <63880977+Tabonx@users.noreply.github.com>
Co-authored-by: kirat02 <142911687+Kirat0201@users.noreply.github.com>
Co-authored-by: 0xpolarzero <0xpolarzero@gmail.com>
Co-authored-by: Advait Paliwal <advaitspaliwal@gmail.com>
Co-authored-by: Hirbod <504909+hirbod@users.noreply.github.com>
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
Co-authored-by: Tin Zeljar <tinzeljar@gmail.com>
Co-authored-by: Robbie <robbiethewadley@gmail.com>
Co-authored-by: Ved Pandey <vedprakash2302@gmail.com>
Co-authored-by: spoukyii <61633921+spoukyii@users.noreply.github.com>
Co-authored-by: Brett Lyman <LymanBE@gmail.com>
Co-authored-by: Epistex <171461678+epistex-dev@users.noreply.github.com>
Co-authored-by: Elliot Drel <156480527+ElliotDrel@users.noreply.github.com>
Co-authored-by: David Pérez <101389653+DavidPerezA12@users.noreply.github.com>
Co-authored-by: Trevor <trevoedwards@users.noreply.github.com>
Co-authored-by: Trevor Edwards <9443483+trevoedwards@users.noreply.github.com>
Co-authored-by: tiliakoos <73005126+tiliakoos@users.noreply.github.com>
Co-authored-by: DanielJBurbridge <36094258+DanielJBurbridge@users.noreply.github.com>
Co-authored-by: Humberto Gontijo <96875138+humbertogontijo@users.noreply.github.com>
Co-authored-by: Tin Zeljar <35663757+Zheruel@users.noreply.github.com>
Co-authored-by: George Nijo <george.nijo8@gmail.com>
Co-authored-by: Johan Vaz <v.johan2234@gmail.com>
Co-authored-by: tatsuaki watanabe <tatsuaki.w@gmail.com>
Co-authored-by: Pouya Rezvani <32917154+pouyarezvani@users.noreply.github.com>
Co-authored-by: TheGuyWithHAT <igorlickn@gmail.com>
Co-authored-by: Geezy <igor.licko@gloryck.com>
Co-authored-by: Hirbod Mirjavadi <hirbod@expo.dev>
Co-authored-by: Navid Nadali <navid@corefinity.com>
Co-authored-by: Tanav Poswal <63358333+tanav29@users.noreply.github.com>
Co-authored-by: seth-dixon <333797056+seth-dixon@users.noreply.github.com>
Co-authored-by: Muhammad Auon <muhammad.auon@marham.pk>
Co-authored-by: Julian Rustig <jruestig@posteo.de>
Co-authored-by: tcrapts <51760013+tcrapts@users.noreply.github.com>
Co-authored-by: Exotic209093 <134711311+Exotic209093@users.noreply.github.com>
Co-authored-by: Issue triage verification <triage@localhost>
Co-authored-by: Isaac-b-ux <Isaac@tristarrei.com>
Co-authored-by: Isaac-b-ux <264455269+Isaac-b-ux@users.noreply.github.com>
Co-authored-by: Onkar Pradip Jadhav <118719336+Onkarj012@users.noreply.github.com>
Co-authored-by: hari <harikp2002@gmail.com>
Co-authored-by: flexi767 <96955327+flexi767@users.noreply.github.com>
Co-authored-by: flexi767 <flexi767@users.noreply.github.com>
Co-authored-by: Shlok Khemani <khemanishlok@gmail.com>
Co-authored-by: Hieu Le <78847613+hieu-lee@users.noreply.github.com>
Co-authored-by: Taylor Dolezal <onlydole@users.noreply.github.com>
Co-authored-by: Taylor Dolezal <117500+onlydole@users.noreply.github.com>
Co-authored-by: Yaroslav <defyrlt@users.noreply.github.com>
Co-authored-by: Yaroslav Litkovych <yaroslav.litkovych@tamara.co>
Co-authored-by: Pyseph <45090858+Pyseph@users.noreply.github.com>
Co-authored-by: Carlos Rico-Ospina <carlosricojr@gmail.com>
Co-authored-by: Vytor Rennan <61885695+vytorrennan@users.noreply.github.com>
Co-authored-by: John <5423006+johns1x@users.noreply.github.com>
Co-authored-by: César Bahena <119370903+cesarbahena@users.noreply.github.com>
Co-authored-by: johan vaz <johanvaz@Nathalines-MacBook-Pro.local>
Co-authored-by: Rohan Godha <dev@rohangodha.com>
Co-authored-by: Simon Ddungu <dev.simonddungu@gmail.com>
Co-authored-by: Joey van Dijk <mail@joeyvandijk.nl>
Co-authored-by: Nawfal Ahmed <111358247+NawfalAhmed@users.noreply.github.com>
Co-authored-by: Jackson Miller <jackson@jackson.codes>
Co-authored-by: oliver <97427849+flamboh@users.noreply.github.com>
Co-authored-by: ahalekelly <7078138+ahalekelly@users.noreply.github.com>
Co-authored-by: Amine Ilidrissi <38422328+aminevg@users.noreply.github.com>
Co-authored-by: Federico Lomurno <275704276+flomurno@users.noreply.github.com>
Co-authored-by: Darsh Mahadevia <160497999+darshmahadevia@users.noreply.github.com>
Co-authored-by: matyasrathonyi <matyas.rathonyi@gmail.com>
Co-authored-by: Matyas Rathonyi <matyasrathonyi@imac-server2.tailacc4a3.ts.net>
Co-authored-by: Zedong Peng <zedongpeng1@gmail.com>
Co-authored-by: sgoley <10283176+sgoley@users.noreply.github.com>
Co-authored-by: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Mel Boonchan <72452443+muunkk@users.noreply.github.com>
Co-authored-by: spoon <69200006+spoonkuh@users.noreply.github.com>
Co-authored-by: soap-agentops[bot] <310870250+soap-agentops[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:M30-99 changed lines (additions + deletions).vouch:unvouchedAuthor is not yet trusted in the VOUCHED list.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On a Windows host, typing
exit(or Ctrl+D, or running a command that ends the shell) in a T3 terminal prints the shell's output at once, but the terminal only reportsexitedabout 1.0 s later. In the drawer, "Process exited" and the tab auto-close wait that second; the onboarding install terminal and the mobile terminal screen leave the same second late.node-pty's Windows backend cannot see the end of ConPTY's output pipe (ConPTY keeps it open until the pseudoconsole is closed, and node-pty has already dropped the handle when the exit callback runs). So after the shell exits it waits
FLUSH_DATA_INTERVALfor trailing output and only then destroys the socket, whosecloseevent emitsexit. That interval is 1000 ms.Measured through the real terminal
ManagerandNodePtyAdapteron Windows 11 (build 26200), Node 26.12.1,exittyped to theexitedevent, node-pty 1.2.0-beta.15 as T3 ships it:The remaining 100 to 140 ms is the shell itself exiting plus the 100 ms window.
Change
Only
patches/node-pty@1.2.0-beta.15.patchchanges (T3 already patches this file for watch mode and for the console-list helper), plus the regenerated patch hash inpnpm-lock.yamland a unit test. Inlib/windowsPtyAgent.js:FLUSH_DATA_INTERVALgoes from 1000 to 100.setImmediateturn later, and only if no data event re-armed the timer in between.Why 1000 ms exists: node-pty set 20 ms in 2018 (
e4c294a) and raised it to 1000 ms in 2020 (e430d82e, "Host conout socket in a worker", the fix for the ConPTY close deadlock, microsoft/node-pty#375). The commit message says ConPTY "can send a final screen update after ClosePseudoConsole", and the conout worker added a second pipe hop. The value was never tuned or measured again.What it protects is trailing output that conhost renders after the shell process has exited. Over 240 sessions per shell with the stock timer, data still arrived after the exit callback in 240/240 cmd sessions (median 12 ms, max 20 ms) and in 123/240 PowerShell sessions (median 2.8 ms, max 8 ms). 100 ms is 5x the longest tail seen.
Why lowering the constant alone is not safe: Node runs timers before the poll phase. If the main thread is blocked for longer than the interval right after the exit callback (T3 sees sporadic
spawn()blocks of 85 to 329 ms and 100 to 200 ms terminal restores), the cleanup timer fires first andoutSocket.destroy()discards output that is already sitting in the pipe. cmd prints its last line about 12 ms after the exit callback, so it is lost. With only the constant lowered, cmd's final line was lost in 20/20 runs once the stall reached the interval (stall 150 ms at interval 100; 60 ms at 50; 400 ms at 250). The extrasetImmediateturn lets the poll phase read what is buffered first (every chunk re-arms the timer) before the decision, so a stall costs only time. It also removes the same failure mode from stock at a 1.1 s stall (cmd lost its last line in 18/20 runs on stock below).Linux and macOS are unaffected:
node-pty/lib/index.jsloadswindowsTerminal(and sowindowsPtyAgent.js) only whenprocess.platform === 'win32'. Nothing inapps/orpackages/imports the agent file except tests.The event-driven fix is upstream: microsoft/node-pty#990 and #991 (both open, unreviewed) close the pseudoconsole on natural exit so the pipe EOF ends the session about 60 ms after the shell exits. That needs a native
conpty.ccchange and new prebuilds, which T3 cannot take throughpatches/. If either lands, this patch should be dropped.Scope and approval
I described this first in Ideas discussion #30872. There's no maintainer reply there yet, so I'm submitting it as a small, focused fix for an obvious defect: the terminal reports that the shell exited a second after it did, because of a fixed wait in node-pty's Windows agent. The change is two edits to
lib/windowsPtyAgent.jsinside the patch T3 already carries, plus its regenerated lockfile hash and a test inapps/server/src/terminal. No product source changes. It does change timing, as described below. If you'd rather settle it in the discussion first, I'm happy to close this.Behaviour differences, stated plainly:
exitedis emitted about 0.9 s earlier on Windows for every natural shell exit.useConptyDllwere not tested (useConptyDllskips this timer entirely).Verification
Harness: the real
apps/server/src/terminal/NodePtyAdapter.tsandManager.tson the installed, patched node-pty (vp iregenerated the lock hash;node_modules/node-pty/lib/windowsPtyAgent.jshas the change), real PowerShell 5.1 and cmd, with a stock copy of the package (patch state ofmain) alternating with the patched one. A lost line means the unique last line was missing from the output; for big writes the exact count of payload characters is also checked. Stalls are injected withAtomics.waiton the main thread right after the exit callback.Results (lost = unique last line, or any payload character, missing from the output; time = exit callback to
exit/exited, median and min..max):exittyped toexitedthrough the Manager, stockexit, adapter, stockexitexitUnder the CPU-starved run the PowerShell Manager, 10 MB and slow-tail rows did not complete: PowerShell 5.1 itself took 5 to 14 s to start and run a command, so the harness timed out before sending
exit(12/15 Manager runs, 2/4 big runs) and the run was stopped at its time limit. No completed run in that cell lost output, but it is not evidence for those rows.Raw rows and harness: https://gist.github.com/Pyseph/4e3c3d1af2c7a495d9833b06bc133474 (
m-*.jsonlholds the 768 matrix rows andload-*.jsonlthe CPU-starved runs;hmgr.mjsandstress.mjsare the harness,run-matrix.shandrun-load.shthe drivers).Unit tests (
apps/server/src/terminal/nodePtyFlushDataAndCleanUp.test.ts, run on any OS because the agent file is plain JS; they replace the global timer functions with a tiny loop that places the poll phase between the timer and check phases): cleanup 100 ms after the exit and not before; more data restarts the window; buffered data read right after a stalled timer expiry keeps the socket open; cleanup after a stall when nothing was buffered; nothing runs withuseConptyDll. All 5 pass on this branch; run against the unpatched agent file (main's patch) 4 of 5 fail.vp test run src/terminalinapps/serveron Windows, Node 26.12.1: 5 files, 105 tests pass (this includesNodePtyAdapter, the terminalManagerandnodePtyConsoleList, the other test that loads the patched agent).vp fmtandvp linton the new test are clean; typecheck was not run.Not checked: a UI run (the lingering tab is read from
ThreadTerminalDrawer.tsx, not observed; no screenshots), Windows before 24H2, ARM, PowerShell 7, the packaged Electron server, Defender-off, and real (non-injected) server stalls.Claude Sonnet 5.5 and Claude Opus 5.5 in T3 Code (Claude Code harness).