Repository navigation
fix(server): Claude threads in a 200K window compact when idle #31455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
juliusmarminge
wants to merge
10
commits into
main
Choose a base branch
from
fix/issue-31441
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+278
−46
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a12294f
fix(server): Claude context meter shows the window Claude actually en…
vladikkuzn 0643560
fix(server): scope reported Claude context windows to their session
vladikkuzn a7b7108
test: reproduce #31441, 200K-window Claude threads never compact
juliusmarminge 73300ae
fix: Claude threads in a 200K window compact when idle
juliusmarminge a4bfe99
fix: settings copy names the 100K compaction minimum for 200K windows
juliusmarminge 9c4266e
fix(web): no Compact chip while a provider handoff is pending
juliusmarminge 33e034c
Merge remote-tracking branch 'origin/main' into fix/issue-31441
juliusmarminge f93a21f
Merge branch 'main' into fix/issue-31441
juliusmarminge d2559b4
test(client-runtime): expect each compact-before-send row's own token…
juliusmarminge c1a4493
fix(server): find a routed Claude session's reported context window
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look up reported windows with the routed model ID.
claudeContextWindowcompiles the selection against the unroutedmodelCatalog. The turn path compiles and opens the session with the routed catalog. When a backend route applies, the routedapiModelIdcan differ from the baseapiModelId. The lookup then uses an ID that the session does not run with. A window reported for the routed model is missed, and the catalog capacity (1M) is used. The meter, the compact-before-send limit, and idle compaction then use the wrong window for these sessions.Look up the window with the
apiModelIdthat the active query uses. Keep the routed selection available toclaudeContextWindow, or record the routed ID when the turn compiles its selection. Confirm that themodelUsagekeys use that same routed ID before relying on the lookup.