You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(server): Windows Antigravity install no longer rolls back after validation passes - #32462
On Windows, installing the managed Antigravity runtime rolls back even though validation succeeds. The UI then reports "Could not finish the Antigravity installation". The trace shows AntigravityInstallation.validate succeeding and then AntigravityInstallation.install failing with PlatformError: Unknown: ChildProcess.kill (...agy_acp_server.exe) / Failed to kill child process.
The Windows branch of validate adds a finalizer that kills the validation runtime's process tree, piped through Effect.orDie. When that finalizer runs, the runtime is exiting or has already exited. Effect's Node spawner runs taskkill unless Node has already recorded the exit. If taskkill fails because the process has gone, the spawner falls back to childProcess.kill(), which also fails for a process that has exited. orDie turns this best-effort cleanup failure into a defect, and the defect fails the whole install.
Change
The finalizer now pipes the kill through Effect.ignore instead of Effect.orDie. The kill still runs before ACP closes its pipes, but a failed kill no longer fails a validated install. Other best-effort child.kill() calls in the server, and Effect's own scope release of the same child, already ignore errors this way. Validation failures, defects and interruption still propagate. A process that really is still holding files is still caught later, when the profile directory is removed or the staging directory is renamed.
New test in apps/server/src/provider/AntigravityInstallation.test.ts, installs on Windows when the validation process exits before it is killed. It runs the real default validate with platform: "win32" and a real Node child that answers ACP initialize and exits. Its kill waits for the child to exit, then calls the real Node kill.
Without the fix (line 431 back to Effect.orDie, on main at d313b2a): it fails. The install ends with phase: "failed" and installedVersion: null, and the finalizer's kill fails with PlatformError: Unknown: ChildProcess.kill (…) (cause: Error: Failed to kill child process). Two independent reviews reproduced the failure.
With this change at b8bb93b: the whole file passes, 30 of 30 tests (log). Re-run after merging main at ebb02a9: 30 of 30; the two changed files are byte-identical to b8bb93b.
vp run check:changed passes: format, lint, typecheck and the tests next to the change.
Runtime transcript from Linux with the real @effect/platform-node spawner (effect 4.1.2): killing a child that has already exited fails with the same error as the report (log).
$ node kill-already-exited-child.ts
child exited with 0 pid 4084368
kill after exit: Cause([Fail(PlatformError: Unknown: ChildProcess.kill (node -e 'process.exit(0)') (cause: Error: Failed to kill child process))])
This changes nothing on screen. The proof audit's fixture matrix finds no render path that changes: the install reaches the existing success state where it used to fail. So there are no captures.
cannot-verify windows: the path through native taskkill, the PyInstaller process tree and NTFS was not run on Windows. The test runs the Windows branch on Linux with a real Node child.
Verification log
Review round 1 (two independent reviewers): both MERGE, no findings. Notes taken: the Problem wording now describes the taskkill race.
Review round 2 at ebb02a9 (after merging main, two fresh independent reviewers): both MERGE, no findings. One reviewer reproduced the failure on main in a separate worktree (phase: "failed", installedVersion: null) and saw the new test pass 8 of 8 isolated reruns.
Proof audit pass 1 at ebb02a9: sufficient; minimum capture set is empty, no rows to add.
Tests: 30/30 in AntigravityInstallation.test.ts at ebb02a9; vp run check:changed passes.
Unverified surfaces: windows.
AI-assisted; verified with the tests and tools listed above.
… validation cleanup
On Windows the default runtime validation kills the ACP process in a scope
finalizer. When that process has already exited, the kill fails and
Effect.orDie turns the best-effort cleanup into a defect, so the install
reports failed. This test drives the win32 branch with a real Node child
that exits after answering initialize.
AI-assisted; verified with the tests and tools listed above.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…kill failure
When the Antigravity validation runtime had already exited, the Windows
finalizer's best-effort kill failed and Effect.orDie turned that into a
defect that rolled back an install whose validation had passed. Ignore
the kill failure, matching other best-effort child kills in the server.
Fixes#32457
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Macroscope's review found this PR requires human approval — The specified comparison adds a default-enabled sleep inhibitor and disables Android release lint tasks, beyond the Windows installation cleanup fix. Human review is required for the changed power-management default and reduced production-build diagnostics.
Notes:
All code in this push has already been reviewed. Approvability was decided on eligibility alone.
You can add or adjust custom eligibility rules. Learn more.
No actionable comments were generated in the recent review.
Walkthrough
The Windows Antigravity validation finalizer now ignores child-process kill errors. A Windows installation test verifies that installation succeeds after the validation process exits and records version fixture-new.
Changes: Windows installation validation
Layer / File(s)
Summary
Validation cleanup and installation test apps/server/src/provider/AntigravityInstallation.ts, apps/server/src/provider/AntigravityInstallation.test.ts
The Windows validation finalizer ignores errors from child.kill. The test checks that installation succeeds and records version fixture-new after the validation process exits.
pingdotgg/t3code#29279: Both PRs change Windows validation cleanup. This PR changes whether kill errors fail installation; #29279 adds retry handling for the publish rename and cleanup.
Suggested reviewers:aledog007, stienswout
Merge Risk: Minimal · up to f8ed0
This change prevents a failed cleanup kill of an already-exited validation process from failing a Windows Antigravity installation that otherwise validated successfully. The change is small and has test coverage. Native Windows behavior was not tested, but no concrete merge-blocking risk is evident.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the main change: the Windows Antigravity install no longer rolls back after validation passes. It matches the finalizer change from Effect.orDie to Effect.ignore that stops a failed be…
Description check
The description follows the template well. It has Problem, Change, Scope and Verification sections. The Problem and Change sections clearly explain the Windows taskkill race, the Effect.orDie defect, …
Linked Issues check
[#32457] The whole-PR summary at reviewed head f8ed08a states that the Windows validation finalizer in apps/server/src/provider/AntigravityInstallation.ts now ignores …
Out of Scope Changes check
[#32457] The whole-PR summary lists two changed files: the one-line finalizer change in AntigravityInstallation.ts and a regression test in AntigravityInstallation.test.ts. The test directly exercises…
Full details: Title check
Explanation
The title names the main change: the Windows Antigravity install no longer rolls back after validation passes. It matches the finalizer change from Effect.orDie to Effect.ignore that stops a failed best-effort kill from failing a validated install. The title uses the conventional commit format and is specific. It is 85 characters, which is longer than ideal but still readable.
Full details: Description check
Explanation
The description follows the template well. It has Problem, Change, Scope and Verification sections. The Problem and Change sections clearly explain the Windows taskkill race, the Effect.orDie defect, and the Effect.ignore fix. Scope links issue #32457 and says it fixes a bug. Verification names a focused new test, the before and after results, the 30/30 test run, and a runtime transcript on Linux. It states what was not verified (native Windows taskkill, process tree, NTFS). The description also includes an AI-assisted note. It does not name the model and harness used, which the template asks for when an agent was used. The description is long and includes some extra review-log detail, but the required information is present.
Full details: Linked Issues check
Explanation
[#32457] The whole-PR summary at reviewed head f8ed08a states that the Windows validation finalizer in apps/server/src/provider/AntigravityInstallation.ts now ignores errors from the forced kill instead of converting them to defects with Effect.orDie (+1/-1). The issue requires a validated runtime to be published and activated when the already-exited validation process cannot be killed. The change removes the defect path that failed the install. A regression test in AntigravityInstallation.test.ts runs default validate with platform win32 and an exited Node child, then asserts that installation succeeds with version fixture-new. Limits: direct reads of the changed blobs were unavailable, so the exact changed lines at head were not read; the result relies on the whole-PR summary. Native Windows taskkill, process-tree, and NTFS behavior were not tested; the Windows branch ran on Linux. Incremental changes since fc3290f were not separately read.
Full details: Out of Scope Changes check
Explanation
[#32457] The whole-PR summary lists two changed files: the one-line finalizer change in AntigravityInstallation.ts and a regression test in AntigravityInstallation.test.ts. The test directly exercises the changed finalizer path, so it supports the objective. No unrelated changes appear in the summary. The direct diff could not be read, so this verdict relies on the summary; the PR description reports no other files changed.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.
The automated pipeline stopped on this pull request and will not merge it:
the capture step could not show the problem on the base commit, so there is nothing to prove fixed.
On each commit, pair Chromium, open Settings → Providers → Antigravity, confirm no custom binary path and runtime not installed, enable Antigravity, click Install Antigravity, and wait through download and validation. Both installed runtime 1.5.13 and displayed Installed. The reported cleanup error was not observed. The base recording was repeated from another fresh T3 home after correcting the driver's terminal-state wait.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugfixFix PR opened by an issue lead; enters the PR looppr:gate-failedA land gate failedsize:XS0-9 changed lines (additions + deletions).takeover:blockedTakeover blocked; reason in the PR bodyvouch:trustedAuthor is trusted by repo permissions or the VOUCHED list.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows, installing the managed Antigravity runtime rolls back even though validation succeeds. The UI then reports "Could not finish the Antigravity installation". The trace shows
AntigravityInstallation.validatesucceeding and thenAntigravityInstallation.installfailing withPlatformError: Unknown: ChildProcess.kill (...agy_acp_server.exe)/Failed to kill child process.The Windows branch of
validateadds a finalizer that kills the validation runtime's process tree, piped throughEffect.orDie. When that finalizer runs, the runtime is exiting or has already exited. Effect's Node spawner runstaskkillunless Node has already recorded the exit. Iftaskkillfails because the process has gone, the spawner falls back tochildProcess.kill(), which also fails for a process that has exited.orDieturns this best-effort cleanup failure into a defect, and the defect fails the whole install.Change
The finalizer now pipes the kill through
Effect.ignoreinstead ofEffect.orDie. The kill still runs before ACP closes its pipes, but a failed kill no longer fails a validated install. Other best-effortchild.kill()calls in the server, and Effect's own scope release of the same child, already ignore errors this way. Validation failures, defects and interruption still propagate. A process that really is still holding files is still caught later, when the profile directory is removed or the staging directory is renamed.Scope and approval
Fixes #32457
Verification
New test in
apps/server/src/provider/AntigravityInstallation.test.ts,installs on Windows when the validation process exits before it is killed. It runs the real defaultvalidatewithplatform: "win32"and a real Node child that answers ACPinitializeand exits. Itskillwaits for the child to exit, then calls the real Nodekill.Effect.orDie, on main at d313b2a): it fails. The install ends withphase: "failed"andinstalledVersion: null, and the finalizer's kill fails withPlatformError: Unknown: ChildProcess.kill (…) (cause: Error: Failed to kill child process). Two independent reviews reproduced the failure.vp run check:changedpasses: format, lint, typecheck and the tests next to the change.Runtime transcript from Linux with the real
@effect/platform-nodespawner (effect 4.1.2): killing a child that has already exited fails with the same error as the report (log).Driver script (not committed)
This changes nothing on screen. The proof audit's fixture matrix finds no render path that changes: the install reaches the existing success state where it used to fail. So there are no captures.
cannot-verify windows: the path through native
taskkill, the PyInstaller process tree and NTFS was not run on Windows. The test runs the Windows branch on Linux with a real Node child.Verification log
taskkillrace.phase: "failed",installedVersion: null) and saw the new test pass 8 of 8 isolated reruns.AntigravityInstallation.test.tsat ebb02a9;vp run check:changedpasses.AI-assisted; verified with the tests and tools listed above.