Skip to content

fix(web): make child-thread approval actions easier to find - #33988

Open
07rjain wants to merge 2 commits into
pingdotgg:mainfrom
07rjain:fix/child-thread-approval-card
Open

07rjain wants to merge 2 commits into
pingdotgg:mainfrom
07rjain:fix/child-thread-approval-card

Conversation

@07rjain

@07rjain 07rjain commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Problem

When a child thread needs permission, its approval card above the parent thread's composer uses small inline Decline/Approve/More links. The action to unblock the child is easy to overlook, and the request heading runs together with the child thread's title.

Change

Give that card a clear approval heading and shield icon, put the requesting thread title on its own wrapping line, and use filled Approve / outlined Decline buttons. A card presentation in the existing action component uses the standard multiline button size so long provider labels remain readable. The existing response handler and More menu handle all decisions.

Only the child-thread card selects this presentation. This follow-up contains two UI files plus the web translation catalogs and does not include the timeline changes from #29549 or #31562.

Scope and approval

This is the focused child-thread follow-up Julius invited in his closing comment on #29549: “The child-thread approval card changes are separate from that PR; if those still matter, a smaller PR focused on that card would be welcome.”

Verification

  • Matched before/after captures in T3 Code's Browser panel at 1280×800, using the same parent, child, and pending request. The baseline is main at 8ee7183e6c8a.
  • In isolated development state, drove Approve, Decline, Cancel, and Always allow this session from the parent card. Each decision was persisted as accept, decline, cancel, or acceptForSession, and the card disappeared. Approve/session approval allowed the free Replay turn to finish; Decline/Cancel ended the replay request without its approved continuation.
  • Checked the card at 390px browser width with no horizontal document overflow. Checked light and dark themes, a long child title, and long action labels. The long-label image uses temporary fixture labels in the existing default options; those strings were restored before validation.
  • vp run check:changed --concurrency 1 passed: format, lint, both knip passes, typechecks for 2 affected packages, the existing child-approval failure/retry browser test, and React Compiler checks for both changed components. No new static-markup test was added for this presentation change.
  • Fixture limits: parent and child were created through the app CLI; their relationship was seeded in the isolated database while the server was stopped. Pending approvals and responses flowed through the real Replay adapter, orchestrator, and UI. Replay does not execute the displayed shell command. Packaged Electron, native iOS/Android, real-provider execution, linked environments, and relay/tunnel connections were not exercised. The web component is also used by desktop; mobile has separate UI and is outside this card-only change.

Before:

Before: child approval card uses inline links

After:

After: clear heading, child title, and approval buttons

15-second recording: More menu and approval submitted from the parent card

Additional layout evidence:

390px browser layout

Light theme with a long child title and long action labels

Verification transcript, persisted decisions, and check results

GPT-6.1 Sol via the Codex harness in T3 Code.

takeover verification

Note

Written by gpt-6.1-sol on behalf of Maria

verified takeover head ac0a15c69bccd3807242be81c2c75ac54dfec53b.

merged current main without rebasing and resolved the two conflicts, keeping the card layout and main's translation handling. translated the new heading in every web locale. addressed the action-height finding by using icon-sm for the card's more-options button. left the optional lookup refactor out to keep this small.

vp run check:changed github/main and vp run i18n:check passed through blacksmith: format, lint, both knip passes, affected typechecks, existing child-approval failure/retry browser test, and react compiler checks. two independent read-only reviews found no blockers on this head.

verified in the real web app with playwright and system chrome against isolated development state. live codex gpt-6-luna parent turns delegated supervised children. approve executed the requested file write and dismissed the card. decline dismissed a separate request and prevented its write. the more menu retained cancel and session approval. checked 390px dark and light layouts. no fixtures, mock approvals, or database writes were used.

matching real pending request, command, title, and viewport; captures focus on the card and composer:

before on current main: inline child approval actions

after on takeover head: clear heading and matched action heights

real codex child approval: more menu, approve, and card dismissal

390px dark layout

390px light layout

unverified this pass: packaged electron, native mobile, other providers, linked environments, relay/tunnel, custom long provider labels, and execution of cancel/session approval. their handlers remain unchanged.

@github-actions github-actions Bot added vouch:unvouched Author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Nov 10, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Would Approve

Macroscope's review found this PR approvable — Child-thread approval cards gain clearer headings and more visible, wrapping action buttons. Approval choices, authorization checks, and submission behavior remain unchanged, keeping the change limited to presentation.

Needs human approval because:

  • Macroscope's correctness review did not reach a verdict

Notes:

  • The correctness review was unavailable. Eligibility was assessed without its result.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Child-thread approvals now show a shield-question icon, a fixed approval heading, and the child-thread title. Their actions use a card presentation with wrapping labels and multiline buttons. Approval translations no longer include a requester or title placeholder.

Changes: Child-thread approvals

Layer / File(s) Summary
Card heading and actions
apps/web/src/components/chat/ChildThreadApprovals.tsx, apps/web/src/components/chat/ComposerPendingApprovalActions.tsx, apps/web/src/i18n/translations/*.json
The approval display separates the fixed heading from the child-thread title and uses card presentation for its actions. The action component supports card-specific label wrapping and multiline button sizing. Composer and inline presentations retain their existing behavior. Translations replace interpolated approval messages with fixed text.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Feature

Suggested reviewers: maria-rcks, yash-singh1

Merge Risk: Minimal · up to ac0a1

This updates the child-thread approval card with a clearer heading and easier-to-find Approve and Decline buttons. The existing decision handling is unchanged, and the reported checks passed. No merge-blocking risk remains.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "fix(web): make child-thread approval actions easier to find" matches the main change: the child-thread approval card gets a clearer heading, icon, and filled/outlined buttons so actions are…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description follows the repository template closely. It has Problem, Change, Scope, and Verification sections, and it links the invited follow-up on #29549. It gives a clear problem statement, exp…
Full details: Title check

Explanation

The title "fix(web): make child-thread approval actions easier to find" matches the main change: the child-thread approval card gets a clearer heading, icon, and filled/outlined buttons so actions are easier to find. It follows the conventional commit format and is specific to the changed component.

Full details: Description check

Explanation

The description follows the repository template closely. It has Problem, Change, Scope, and Verification sections, and it links the invited follow-up on #29549. It gives a clear problem statement, explains the card presentation change, and reports detailed verification with before/after evidence, a recording, and stated limits. The template's conventional commit title is not visible in the provided description, and it does not include the required model/harness line in the template's exact position, though it does name the model and harness (GPT-6.1 Sol via Codex). The description is mostly complete, so it passes.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 60261cf and ac0a15c.

Files selected for processing: 12

  • apps/web/src/components/chat/ChildThreadApprovals.tsx
  • apps/web/src/components/chat/ComposerPendingApprovalActions.tsx
  • apps/web/src/i18n/translations/de.json
  • apps/web/src/i18n/translations/en.json
  • apps/web/src/i18n/translations/es.json
  • apps/web/src/i18n/translations/fr.json
  • apps/web/src/i18n/translations/ja.json
  • apps/web/src/i18n/translations/ko.json
  • apps/web/src/i18n/translations/pt-BR.json
  • apps/web/src/i18n/translations/ru.json
  • apps/web/src/i18n/translations/sv.json
  • apps/web/src/i18n/translations/zh.json
Files skipped from review as they are similar to previous changes: 1

  • apps/web/src/components/chat/ChildThreadApprovals.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@07rjain

07rjain commented Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

Hi @juliusmarminge, following your suggestion on #29549, this is the smaller PR focused on the child-thread approval card. Could you take a look when you have a chance?

It adds a clearer heading and prominent Approve/Decline buttons, with wrapping for long labels. The PR includes matching before/after screenshots, a short interaction recording, narrow-layout and light-theme captures, and a verification transcript. The required local checks passed, and all four approval decisions were exercised through the parent card using Replay. Fixture details and verification limits are documented in the description.

Thanks for the direction on keeping this focused!

@binjamshid binjamshid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new card presentation is scoped to the child-thread approval card, the response handler and More menu are unchanged, and the description has before/after captures plus narrow and long-label checks. Nothing else uses the old "Approval needed from" text, so no tests depend on it.

  1. low, apps/web/src/components/chat/ComposerPendingApprovalActions.tsx:90: Approve/Decline move to sm-multiline (min-h-8, sm:min-h-7) in card mode, but the More trigger still falls into the non-inline branch with size="icon-xs" (size-7, sm:size-6). On desktop widths the ellipsis button is 4px shorter than the buttons beside it. Using icon-sm for the trigger when presentation === "card" would keep the row even.
  2. low: the three-way presentation ternary for the label class is getting hard to read; a small lookup object ({ inline: ..., card: ..., composer: ... }) would make adding a fourth mode less error-prone. Optional.

@maria-rcks

maria-rcks commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

Note

Written by gpt-6.1-sol on behalf of Maria

verified takeover head ac0a15c69bccd3807242be81c2c75ac54dfec53b.

merged current main without rebasing and resolved the two conflicts, keeping the card layout and main's translation handling. translated the new heading in every web locale. addressed the action-height finding by using icon-sm for the card's more-options button. left the optional lookup refactor out to keep this small.

vp run check:changed github/main and vp run i18n:check passed through blacksmith: format, lint, both knip passes, affected typechecks, existing child-approval failure/retry browser test, and react compiler checks. two independent read-only reviews found no blockers on this head.

verified in the real web app with playwright and system chrome against isolated development state. live codex gpt-6-luna parent turns delegated supervised children. approve executed the requested file write and dismissed the card. decline dismissed a separate request and prevented its write. the more menu retained cancel and session approval. checked 390px dark and light layouts. no fixtures, mock approvals, or database writes were used.

matching real pending request, command, title, and viewport; captures focus on the card and composer:

before on current main: inline child approval actions

after on takeover head: clear heading and matched action heights

real codex child approval: more menu, approve, and card dismissal

390px dark layout

390px light layout

unverified this pass: packaged electron, native mobile, other providers, linked environments, relay/tunnel, custom long provider labels, and execution of cancel/session approval. their handlers remain unchanged.

@github-actions github-actions Bot added size:L 100-499 changed lines (additions + deletions). and removed size:S 10-29 changed lines (additions + deletions). labels Nov 18, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:unvouched Author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants