Repository navigation
Conversation
ApprovabilityVerdict: Would Approve Macroscope's review found this PR approvable — Child-thread approval cards gain clearer headings and more visible, wrapping action buttons. Approval choices, authorization checks, and submission behavior remain unchanged, keeping the change limited to presentation. Needs human approval because:
Notes:
You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Hi @juliusmarminge, following your suggestion on #29549, this is the smaller PR focused on the child-thread approval card. Could you take a look when you have a chance? It adds a clearer heading and prominent Approve/Decline buttons, with wrapping for long labels. The PR includes matching before/after screenshots, a short interaction recording, narrow-layout and light-theme captures, and a verification transcript. The required local checks passed, and all four approval decisions were exercised through the parent card using Replay. Fixture details and verification limits are documented in the description. Thanks for the direction on keeping this focused! |
binjamshid
left a comment
There was a problem hiding this comment.
The new card presentation is scoped to the child-thread approval card, the response handler and More menu are unchanged, and the description has before/after captures plus narrow and long-label checks. Nothing else uses the old "Approval needed from" text, so no tests depend on it.
- low,
apps/web/src/components/chat/ComposerPendingApprovalActions.tsx:90: Approve/Decline move tosm-multiline(min-h-8,sm:min-h-7) in card mode, but the More trigger still falls into the non-inline branch withsize="icon-xs"(size-7,sm:size-6). On desktop widths the ellipsis button is 4px shorter than the buttons beside it. Usingicon-smfor the trigger whenpresentation === "card"would keep the row even. - low: the three-way
presentationternary for the label class is getting hard to read; a small lookup object ({ inline: ..., card: ..., composer: ... }) would make adding a fourth mode less error-prone. Optional.
|
Note Written by verified takeover head merged current main without rebasing and resolved the two conflicts, keeping the card layout and main's translation handling. translated the new heading in every web locale. addressed the action-height finding by using
verified in the real web app with playwright and system chrome against isolated development state. live codex matching real pending request, command, title, and viewport; captures focus on the card and composer: unverified this pass: packaged electron, native mobile, other providers, linked environments, relay/tunnel, custom long provider labels, and execution of cancel/session approval. their handlers remain unchanged. |





Problem
When a child thread needs permission, its approval card above the parent thread's composer uses small inline Decline/Approve/More links. The action to unblock the child is easy to overlook, and the request heading runs together with the child thread's title.
Change
Give that card a clear approval heading and shield icon, put the requesting thread title on its own wrapping line, and use filled Approve / outlined Decline buttons. A card presentation in the existing action component uses the standard multiline button size so long provider labels remain readable. The existing response handler and More menu handle all decisions.
Only the child-thread card selects this presentation. This follow-up contains two UI files plus the web translation catalogs and does not include the timeline changes from #29549 or #31562.
Scope and approval
This is the focused child-thread follow-up Julius invited in his closing comment on #29549: “The child-thread approval card changes are separate from that PR; if those still matter, a smaller PR focused on that card would be welcome.”
Verification
8ee7183e6c8a.accept,decline,cancel, oracceptForSession, and the card disappeared. Approve/session approval allowed the free Replay turn to finish; Decline/Cancel ended the replay request without its approved continuation.vp run check:changed --concurrency 1passed: format, lint, both knip passes, typechecks for 2 affected packages, the existing child-approval failure/retry browser test, and React Compiler checks for both changed components. No new static-markup test was added for this presentation change.Before:
After:
15-second recording: More menu and approval submitted from the parent card
Additional layout evidence:
Verification transcript, persisted decisions, and check results
GPT-6.1 Sol via the Codex harness in T3 Code.
takeover verification
Note
Written by
gpt-6.1-solon behalf of Mariaverified takeover head
ac0a15c69bccd3807242be81c2c75ac54dfec53b.merged current main without rebasing and resolved the two conflicts, keeping the card layout and main's translation handling. translated the new heading in every web locale. addressed the action-height finding by using
icon-smfor the card's more-options button. left the optional lookup refactor out to keep this small.vp run check:changed github/mainandvp run i18n:checkpassed through blacksmith: format, lint, both knip passes, affected typechecks, existing child-approval failure/retry browser test, and react compiler checks. two independent read-only reviews found no blockers on this head.verified in the real web app with playwright and system chrome against isolated development state. live codex
gpt-6-lunaparent turns delegated supervised children. approve executed the requested file write and dismissed the card. decline dismissed a separate request and prevented its write. the more menu retained cancel and session approval. checked 390px dark and light layouts. no fixtures, mock approvals, or database writes were used.matching real pending request, command, title, and viewport; captures focus on the card and composer:
unverified this pass: packaged electron, native mobile, other providers, linked environments, relay/tunnel, custom long provider labels, and execution of cancel/session approval. their handlers remain unchanged.