Repository navigation
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Retains previously reported GitHub Actions job failures across polling fluctuations and rewatching, reducing duplicate agent wakes while distinguishing new jobs. The change is confined to watch bookkeeping and preserves reporting behavior for checks without immutable job URLs. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
This PR conflicts with See the conflict window. |
|
Note Written by merged main without rebasing and preserved its watch baseline and pending-check behavior. added the missing the two existing recovery test cases failed before that comparison and passed afterward, including a pending-to-failure transition without another notification. blacksmith verified head |
|
Note Written by Verified in a real dev environmentverified head used this pr's context-budget workflow to create real cancelled attempts with the same check name. main consumed job the pr consumed job restored the workflow normally: job before: main misses the newer same-name job. after: the pr delivers the new job through the server and codex path. command transcript and persisted-state observations Not verifiedcould not induce github's exact failed-job → pending/missing-row → same failed-job read fluctuation or decorated-url replay without mocking host reads. focused policy tests cover those cases; the live proof covers same-name new attempts, persistence, baseline suppression, rewatch suppression and provider delivery. a fast rerun that ends in the same state can leave the existing aggregate watch fingerprint unchanged. stop/rewatch or server restart forced fresh reads here. passive polling latency for that case remains unverified. native desktop/mobile clients, remote/tunnel connections and new-head transitions were not exercised on this linux vm. |


A watch can announce an already consumed GitHub Actions job failure again after a pending/read fluctuation, while missing a newer job with the same check name. It remembers only the current failed names.
Retain consumed immutable failure keys in the existing watch state and carry them across rewatching. The watch's PR/repository context, observed head, run/job URL and terminal outcome identify the result; GitHub allocates a new job ID for each attempt. URL query/fragment decoration does not create another result. Hosts without immutable job URLs retain the existing transition-based behavior. Existing queued stale-head/merge guards and completion delivery remain their current owners.
Verification:
pullRequestWatch.test.ts: the consumed-job replay fails on main, then passes with the fix. It also verifies same-name new jobs/runs, a late old-job replay, and URL decoration. The complete policy file passes, 23 tests.vp test run apps/server/src/orchestration-v2/runtimeLayer.test.ts -t 'starts, records, and stops a pull request watch|watching a dismissed stack layer again'passes, 2 cases.vp test run apps/server/src/orchestration-v2/DelegatedCompletionDelivery.test.ts -t 'does not re-offer when wake-policy upgrades'.vp run check:changed origin/mainpasses format, lint, both knip checks, GraphQL, typechecks for 37 affected packages, and 211 tests in 7 files. Rebased on371963ce0b4cfe8bac3911efd57ae3af90750b41and reran the check on the final source.runtimeLayer.test.ts -t 'pull request|watch'hits six existing pagination-cache assertions on both untouched main and this patch; the pagination owner/test is unchanged across the rebase. The changed persistence cases pass in isolation. Full CI remains authoritative for the complete runtime suite.This is a server-state bug fix with no UI or user configuration change. No running T3 installation or live database was modified. History and original notifications remain available; new attempts/jobs and current-head news remain deliverable. Related to #26987's repeated wake observations; this change addresses consumed immutable check failures only.
Model: GPT-6.1 Sol, reasoningEffort=max, serviceTier=priority. Harness: Codex in T3 Code.