You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(opencode): Full access subagents start without approval prompts - #35401
OpenCode 1.19.5's task tool builds a child session's permission from only the parent's deny and external_directory rules (agent/subagent-permissions.ts), and a running child reads its session once, so T3's post-creation session.update never reached the child. In Full access the parent's only rule was * * allow, so the child fell back to the agent default external_directory: ask and prompted. openCodePermissionRules now returns * * allow plus an explicit external_directory * allow for Full access. OpenCode copies that rule into the child at creation, before its first tool call. Parent behaviour is unchanged, and openCodeChildPermissionRules already treats the copied rule as inherited, so the follow-up rewrite does not duplicate it. Verified against a real opencode serve 1.19.5 with the hub's gpt-6-luna: with the old rules the @general child was created with [task deny] and asked external_directory for /tmp/.../outside/*. With the new rules the child was created with [external_directory allow, task deny] and completed cat on the outside file with no permission request. No new regex or parser.
Commit fd8e386 (origin/main). Ran T3CODE_DEV_SEED=0 vp run dev in a fresh worktree, paired the web client in the preview browser, added a scratch git repo as a project, added the OpenCode provider in Settings > Providers (detected v1.19.5, authenticated) and picked OpenCode GPT-6 Luna, with the thread in the default Full access mode. (Claude models through OpenCode failed with a provider tool-schema error, unrelated.) Prompt: 'Use the task tool to launch a @general subagent ... run cat /tmp/<scratch>/outside/notes.txt and git -C <project> log --oneline'. OpenCode's log: parent session created with [{* * allow}]; child created with only [{task * deny}]; 4 s later evaluated permission=external_directory pattern=/tmp/<scratch>/outside/* action.action=ask and asking id=per_... permission=external_directory. OpenCode's database then held [{task deny},{* * allow},{task deny}] for the child (written by T3's session.update), but the running child never used it. In the T3 UI the subagent item 'Run requested shell commands' showed 'Waiting for approval · Decline · Approve' on the outside path, and the thread showed 'Approval' in the sidebar, although the thread was in Full access. In the OpenCode 1.19.5 source, SessionPrompt.run reads the session once before its step loop (session/prompt.ts:1085), and the task tool (tool/task.ts + agent/subagent-permissions.ts) copies only the parent's deny and external_directory rules into the child.
Evidence
Configured OpenCode 1.19.5 in two fresh web-app environments. With Full access selected, submitted the same prompt asking a task-tool @general subagent to read a synthetic file outside the project and run git log. No approval was granted.
Environment: Linux, Chromium preview browser, light theme, 1280×800 CSS pixels; separate fresh databases with development seeding disabled. Captures were inspected before upload. Private provider metadata is masked and the machine panel is cropped out; stills also mask changing elapsed counters. Eight seconds of initial loading were trimmed equally from both recordings.
AI-assisted; verified with the tests and tools listed above.
Not shown:
The @explore variant was not exercised; both comparisons used the reported @general reproduction.
Desktop, mobile, and other OpenCode versions were not exercised; this proof covers the web client with OpenCode 1.19.5.
Tests
vp test run src/server/adapter.test.ts in packages/provider-opencode: 54 passed. The new assertion in 'maps runtime modes to safe OpenCode permission rules' fails with the fix stashed (expected undefined to equal 'allow'). vp run check:changed: format, lint, knip, typecheck (10 packages) and tests (2 files) all pass. Manual run against a real opencode serve 1.19.5 (scratch driver, not committed): the bug reproduced with the old rules and was gone with the new ones.
Not in this change
The post-creation session.update of child rules in adapter.ts (~1406) still cannot affect an already-running child. It remains useful for later runs and policy changes, so I left it.
In supervised modes children still inherit only the deny rules plus OpenCode's agent defaults until the update lands. That is the existing behaviour and is not part of this report.
AI-assisted; verified with the tests and tools listed above.
OpenCode's task tool copies only a parent's deny and external_directory
rules into a new child session, and a running child never rereads its
session, so T3's later session.update came too late. Full access now also
grants external_directory explicitly, which OpenCode copies into the child
before its first tool call.
Fixes#35246
AI-assisted; verified with the tests and tools listed above.
Macroscope's review found this PR requires human approval — Subagents will inherit outside-directory access immediately rather than prompting in Full access sessions. This changes their effective default permission behavior, requiring human confirmation even though it aligns with the parent policy.
You can add or adjust custom eligibility rules. Learn more.
When approvals are disabled in the full-access path, OpenCode permission rules now include an explicit external_directory allow rule alongside the wildcard allow rule. A test checks that external directories remain allowed.
The no-approval full-access path adds an external_directory allow rule for every pattern. The test checks that filtering the rules still leaves external_directory allowed.
pingdotgg/t3code#26302: Changes child permission-rule derivation and updates child sessions when their computed rules change.
Suggested reviewers:macroscopeapp, saphid
Merge Risk: Minimal · up to f4816
Full access subagents on the targeted OpenCode version should no longer prompt for outside-directory access, and the parent's behavior is unchanged. Older OpenCode versions may still prompt, but that behavior is not made worse by this change. The change looks safe to merge.
Pre-merge checks: 3 · 1
Failed checks: 1 inconclusive
Check name
Status
Explanation
Resolution
Linked Issues check
Issue #35246 requires that OpenCode 1.x subagents in Full access stop prompting for approval, including external_directory. The change adds external_directory * allow to openCodePermissionRules …
Provide evidence that a Full access @general or @explore child run on OpenCode 1.19.x does not prompt for shell commands such as grep, sed, or git diff after this change. A reproduction run with the new rules, or an explicit scope…
Passed checks: 3 passed
Check name
Status
Explanation
Title check
The title names the OpenCode Full access fix and the symptom it removes, which matches the main change: adding an explicit external_directory allow rule so subagents do not prompt. It is specific and …
Out of Scope Changes check
The change touches openCodePermissionRules in packages/provider-opencode/src/server/adapter.ts and its test in adapter.test.ts. It applies only when approvals are disabled and the sandbox is `ex…
Description check
The description covers the template sections. Problem: OpenCode 1.19.5 child sessions created by the task tool miss parent allow rules, so Full access subagents prompt for external_directory approval.…
Full details: Title check
Explanation
The title names the OpenCode Full access fix and the symptom it removes, which matches the main change: adding an explicit external_directory allow rule so subagents do not prompt. It is specific and conventional-commit formatted. The wording is slightly long at 67 characters, but it is accurate.
Full details: Out of Scope Changes check
Explanation
The change touches openCodePermissionRules in packages/provider-opencode/src/server/adapter.ts and its test in adapter.test.ts. It applies only when approvals are disabled and the sandbox is externalSandbox, dangerFullAccess, or implicit full access. Supervised modes keep their existing rules. The PR description states that parent behavior is otherwise unchanged. The test change and the rule change both serve #35246. No unrelated changes were identified in the summary.
Full details: Description check
Explanation
The description covers the template sections. Problem: OpenCode 1.19.5 child sessions created by the task tool miss parent allow rules, so Full access subagents prompt for external_directory approval. Change: openCodePermissionRules adds an explicit external_directory allow rule in Full access, so the child copies it at creation. Scope: it links issue #35246 as the bug report and states the change is a bug fix with no feature added. Verification: it gives a reproduction on main, before/after evidence with screenshots and recordings, a real opencode serve 1.19.5 run, and test results (54 passed, new assertion fails with the fix stashed). It also lists what was not exercised (@explore, desktop, mobile, other OpenCode versions) and what is out of scope. It ends with the AI-assisted note, but the template asks for the model and harness used; the description says 'AI-assisted' without naming the model or harness, so that line is only partly complete. Overall the description is mostly complete.
Full details: Linked Issues check
Explanation
Issue #35246 requires that OpenCode 1.x subagents in Full access stop prompting for approval, including external_directory. The change adds external_directory * allow to openCodePermissionRules for Full access, so the child copies that rule at creation. The author reports a manual run against opencode serve 1.19.5. With the new rules, the @general child ran cat on an outside path with no permission request. The unit assertion in maps runtime modes to safe OpenCode permission rules fails when the fix is stashed. This covers the external_directory requirement. The issue also lists prompts for shell commands (grep, sed, git diff) in subagents. The PR does not show whether those prompts still occur after the change. The copy logic in agent/subagent-permissions.ts copies only deny and external_directory rules. The PR does not verify non-external_directory child prompts, so that part of the requirement is not established. The post-creation session.update also remains unable to affect a running child, as the PR states.
Resolution
Provide evidence that a Full access @general or @explore child run on OpenCode 1.19.x does not prompt for shell commands such as grep, sed, or git diff after this change. A reproduction run with the new rules, or an explicit scope decision that limits #35246 to external_directory, would resolve this.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
617-620: Major · Functional Correctness · Heavy lift
Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.
Handle task children on supported older OpenCode versions.
OpenCodeRuntime.MINIMUM_OPENCODE_VERSION is 1.14.19, but OpenCode 1.14.19 creates task children without copying the parent’s permission rules. Its default subagent policy asks for external-directory access, so the first tool call can still prompt before the child update. (raw.githubusercontent.com)
Provide a fallback for versions without inheritance, or require a version that supports it. Cover the supported version boundary.
* Fixpingdotgg#29433: Restore Codex MCP apps after thread unload (pingdotgg#29498)
Co-authored-by: amr sarhan <amr@amrs-MacBook-Air.local>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): regenerate an empty persisted secret instead of failing startup (pingdotgg#32053)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(server): Gemini Spark can register its six MCP OAuth redirect URIs (pingdotgg#31319)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(cli): the already-running error names the t3 pair command that connects (pingdotgg#31543)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(server): read_pull_request_guide reads no-checkout hosts through the caller's project (pingdotgg#35913)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(server): Codex calls delegate_task directly instead of from Code Mode (pingdotgg#30019)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(forgejo): review guides work for checkouts whose SSH remote is not the web host (pingdotgg#29784)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(effect-acp): reject elicitation modes the client did not advertise (pingdotgg#35839)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(server): MCP refuses disallowed browser origins with 403 before auth and CORS (pingdotgg#35810)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(mcp): explain cross-thread permission rejections (pingdotgg#36934)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(web): Add Environment drops the old tab's error when switching mode (pingdotgg#32157)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): malformed MCP client registration returns an RFC 7591 error body (pingdotgg#35809)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(server): pairing codes typed in hyphen- or space-separated groups are accepted (pingdotgg#35069)
* fix(shared): use HTTP for schemeless loopback previews (pingdotgg#29710)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(opencode): Full access subagents start without approval prompts (pingdotgg#35401)
* fix(desktop): saving keeps a connection catalog this build cannot read (pingdotgg#34944)
* fix(pi): model list loads when the server's folder has a project MCP config (pingdotgg#28557)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(server): Git LFS images in pull request descriptions load the object, not its pointer (pingdotgg#35466)
* fix(server): desktop preview uploads accept files over 50 MB (pingdotgg#30299)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(usage): keep default-home history after the default account moves (pingdotgg#36727)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(provider-acp): approving a Devin plan never picks its bypass-permissions option (pingdotgg#34474)
* fix(server): guests of a forked thread can expand the commands it inherited (pingdotgg#29764)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* docs(user): Tailscale HTTPS lists what the tailnet needs (pingdotgg#23759)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(client-runtime): MCP app results with images reach the app instead of waiting forever (pingdotgg#31338)
* fix(gitlab): a pasted repository URL is looked up by its project path on its host (pingdotgg#35209)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): skip user hooks in Codex text generation (pingdotgg#35203)
Co-authored-by: Nathan Wong <20381195+thelogicmatrix@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(server): worktrees of git-annex repositories can be removed (pingdotgg#34065)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): Codex model changes no longer restart a shared session from another worktree (pingdotgg#34129)
* fix(cursor): an aborted Cursor SDK stall no longer stops the server (pingdotgg#23354)
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(forgejo): prefer the deepest-mounted login when a root login also matches (pingdotgg#35916)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(opencode): Go-key-only instances keep OpenCode Go usage on OpenCode 2 (pingdotgg#36519)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(client-runtime): opening an old search result keeps messages in order (pingdotgg#29711)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(server): MCP OAuth rejects a resource with an empty fragment (pingdotgg#35808)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(provider-core): branch-name generation no longer starts the user's task (pingdotgg#36222)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(web): desktop window recovers when its backend restarts during a renderer reload (pingdotgg#26612)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(server): an explicit Tailscale IPv6 bind is advertised as a tailnet route (pingdotgg#34742)
* fix(server): agent slice memory limits follow live memory changes (pingdotgg#30581)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(grok): background text generation no longer inherits Grok always-approve (pingdotgg#29692)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): preview port discovery stops polling while no client is in the foreground (pingdotgg#29782)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(web): right-panel shortcuts work on a new, unsent thread (pingdotgg#35189)
* fix(desktop): a backend busy right after startup no longer ends in a fatal HTTP 500 screen (pingdotgg#34918)
* fix(onepassword): a failed batch read no longer outlasts the 45-second bound (pingdotgg#35937)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(server): agents get no device tools or instructions while the Device hub is off (pingdotgg#32542)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(server): clients paired over Tailscale Serve keep their own address (pingdotgg#35559)
* fix(server): HTML previews load relative video and audio files (pingdotgg#36199)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(server): a linked launch above the link's access names the link, not the parent mode (pingdotgg#27334)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(server): Claude append launch text may start with two hyphens (pingdotgg#35598)
* fix(cursor): text generation retries without the sandbox when send rejects it (pingdotgg#34844)
* fix(server): resolve Claude WinGet launchers on Windows (pingdotgg#32138)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): Claude knows decline feedback is the user's message (pingdotgg#27871)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(acp): permission answers send the agent's option id unchanged (pingdotgg#35837)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(server): forwarded calls to a linked environment no longer wait out a silent first address (pingdotgg#35546)
* fix(server): Claude sessions no longer log a canUseTool shadowing warning (pingdotgg#31548)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): Claude text generation honors --settings launch args (pingdotgg#34874)
* docs: align delegation guide with current MCP contract (pingdotgg#31045)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): fx threads load the user's profile MCP servers (pingdotgg#29538)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(acp-registry): executables named like ..agent count as inside their install folder (pingdotgg#35840)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(server): usage mapped onto a Pi, Cursor or Antigravity model prices at that model's rate (pingdotgg#32219)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): resuming a queue no longer bypasses failed worktree setup (pingdotgg#36616)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: GPT 6.1 Sol <codex@openai.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): agents can no longer delete the built-in No project through MCP (pingdotgg#33773)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(web): load a too-large PR file's diff on demand (pingdotgg#37007)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(cli): t3 up and t3 status hints keep --base-dir (pingdotgg#31878)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): forks of forks keep their deleted source's files (pingdotgg#32255)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): stashed prompt previews no longer end in a broken character (pingdotgg#32404)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web, mobile): a failed terminal resize is sent again (pingdotgg#32047)
* fix(gitcafe): recognize ssh:// remotes that name no user (pingdotgg#32363)
Co-authored-by: azhar <azhar.amir@amartha.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): EPUB text extraction skips the chapter head (pingdotgg#32370)
Co-authored-by: azhar <azhar.amir@amartha.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(mobile): queued messages show mentions and files by name, not as raw links (pingdotgg#32224)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): [NIT] SF Pro label no longer renders in a serif in the font picker (pingdotgg#24082)
Co-authored-by: maria-rcks <maria@kuuro.net>
* fix(web): quieter Ready and Merge buttons on PR rows (pingdotgg#25346)
Co-authored-by: maria-rcks <maria@kuuro.net>
* fix(prs): include Storybook files in the test filter and counts (pingdotgg#29083)
* fix(web): settings section headers no longer overlap their actions on narrow screens (pingdotgg#29503)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): theme import no longer says a file just under 1 MB is "1024 KB" (pingdotgg#30330)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(web): use available space for project breadcrumbs (pingdotgg#30503)
Co-authored-by: bentbrain <28818884+bentbrain@users.noreply.github.com>
* docs: include required Bitbucket workspace read scope (pingdotgg#30593)
* fix(web): subagent status dots no longer jump between corners (pingdotgg#30753)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
* fix(web): resource monitor no longer claims to sample every 0 ms (pingdotgg#29749)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): the minimap keeps the current turn lit while reading a long reply (pingdotgg#30084)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(desktop): voice input recovers after Linux audio restarts (pingdotgg#32376)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* perf(pr): actions, title edits and labels show the moment you click, on every host (pingdotgg#32774)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: GPT-6.1 Sol <noreply@openai.com>
Co-authored-by: Shivam Sharma <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(provider-core): background work notices no longer say every task failed when one did (pingdotgg#32407)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): restarts no longer drop prompts the provider never accepted (pingdotgg#32413)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* perf(web): typing no longer re-renders the composer's footer controls (pingdotgg#32323)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): task_status no longer reports a restart-continued task as cancelled (pingdotgg#32414)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): sidebar edge uses the same resize cursor as side panels (pingdotgg#33083)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): attach command palette threads outside the sidebar (pingdotgg#37054)
* fix(server): status reports no branch while a clone has not checked out HEAD (pingdotgg#37041)
* perf(scripts): check:changed on Windows no longer spends minutes walking node_modules (2,500 s → 5.0 s) (pingdotgg#32023)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* perf(web): answering a question no longer re-renders the whole chat view (pingdotgg#32324)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* perf(server): command palette status rows skip the Changes totals they never show (pingdotgg#32351)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): PR file order follows alias imports of dotted modules (pingdotgg#32364)
Co-authored-by: azhar <azhar.amir@amartha.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(acp): a failed MCP-over-ACP disconnect can be retried (pingdotgg#33069)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): settle check lines up with row timestamps (pingdotgg#33053)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(provider-core): handoff work reserve fits small context windows (pingdotgg#32598)
Co-authored-by: Zuri <zurih@rtx.internal>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(mobile): video previews survive re-signed URLs and a late-attached player item (pingdotgg#32196)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(mobile): honor Android clock format in message timestamps (pingdotgg#33078)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(shared): .localdomain hosts no longer leak to the favicon service (pingdotgg#32657)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): collapsing Electron main no longer hides the backend server (pingdotgg#32619)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* test: remove duplicate client call-site coverage (pingdotgg#36776)
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(github): pull request activity reports a rate-limited review-thread read instead of hiding its threads (pingdotgg#32620)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): stacked composer banners no longer show dark seam bands (pingdotgg#32683)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): draft images keep their order after a reload (pingdotgg#32709)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): open PDF links in the file viewer (pingdotgg#37064)
* fix(server): a selected-file commit keeps other files' merge conflicts (pingdotgg#33115)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): a file opened from a diff in a project folder inside a repository opens that file (pingdotgg#32684)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* test(web): ACP project picker test waits for the popup to take focus (pingdotgg#33061)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): stop held dictation when shortcut modifiers are released (pingdotgg#32648)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* perf(web): resting on a PR row also reads its activity, so the timeline shows on click (pingdotgg#32842)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: GPT-6.1 Sol <noreply@openai.com>
Co-authored-by: Shivam Sharma <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(server): agents can see whether a thread is pinned (pingdotgg#32727)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): a pushed commit no longer reports failure when the final git status read fails (pingdotgg#32705)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* test(web): the streaming render scenario gives the timeline stable props (pingdotgg#32792)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): HTML file previews use the current canvas color (pingdotgg#37072)
* fix(web): an image-only send that fails behind a new draft now says so (pingdotgg#32732)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(assets): align app icons and retain a folder placeholder while loading (pingdotgg#37067)
* fix(github): pull request activity says when its comments were cut (pingdotgg#32707)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* test(github): activity mock sets the new truncated flag (pingdotgg#37078)
* fix(server): a branch's own pull request shows past a hundred same-named fork pull requests (pingdotgg#32796)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): an effect this build can't read no longer blocks its thread's later work (pingdotgg#32746)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(acp-registry): a failed agent install no longer floods provider status with its whole log (pingdotgg#32800)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): terminal reports focus changes to programs that request them (pingdotgg#37066)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): remove redundant subagent action from background row (pingdotgg#37079)
* fix(web): a side chat's subagent opens its parent as a side chat tab, not a bare page (pingdotgg#32907)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(shared): inline code paths like `docker/Dockerfile` become file chips (pingdotgg#32402)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): Esc in Clerk's account modal no longer closes Settings (pingdotgg#32859)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(mobile): show thread sync status in the header, not above the composer (pingdotgg#37076)
* fix(mobile): undo toast lines up with the folded Duo's tab bar (pingdotgg#37081)
* fix(desktop): Stable switch no longer tells policy-blocked nightly apps to reinstall by hand (pingdotgg#32609)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): live dictation transcript keeps the newest words in view (pingdotgg#32960)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): preserve shell paths containing spaces and dashes (pingdotgg#37069)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* perf(server): batch terminal output that arrives within 2 ms (pingdotgg#37060)
* perf(desktop): WSL preflight starts the staged runtime once instead of twice (pingdotgg#37052)
* fix(mobile): worktree setup shows in the chat from the first moment (pingdotgg#37084)
* fix(server): an MCP pin lands at the top of the Pinned section (pingdotgg#33978)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(mobile): keep Diagnostics and Client Storage content above floating tabs (pingdotgg#32821)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(acp-registry): observe delayed model discovery and avoid stale cache lock (pingdotgg#33170)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* test(web): Settings Esc test waits for the modal's initial focus (pingdotgg#37089)
* fix(claude): keep monitor threads waiting between updates (pingdotgg#37085)
* fix(mobile): the iPhone Duo's sidebar list ends above its tab bar in portrait (pingdotgg#37091)
* fix(web): switching providers no longer drops the thread's stored effort (pingdotgg#33090)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(mobile): PR activity filter remembers bot and resolved visibility (pingdotgg#37096)
* fix(web): terminal links open bare compiler filenames (pingdotgg#37071)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(acp): optional text questions can be left blank (pingdotgg#36997)
Co-authored-by: Claude Haiku 5.5 <noreply@anthropic.com>
* fix(shared): MCP apps that fall back to a blob: frame no longer render blank (pingdotgg#32129)
* fix(shared): keep coalescing workers alive when processors throw (pingdotgg#32178)
* fix(server): an empty Antigravity MCP config still allows text generation (pingdotgg#36496)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* perf(server): active thread reads filter on the archived_at column (pingdotgg#28992)
* perf(resource-monitor): look up external process identities by PID (pingdotgg#31202)
* fix(server): accept ASCII whitespace in base64 image payloads (pingdotgg#31798)
* perf(server): Codex skills for four workspaces load in a median 138 ms instead of 1,657 ms (12x) (pingdotgg#33972)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): recover expired composer uploads before sending (pingdotgg#32910)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): content search recovers after a slow first index (pingdotgg#33138)
Co-authored-by: ItsThierry <274141289+ItsThierry@users.noreply.github.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(terminal): show shell startup failures across attachments (pingdotgg#37088)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* perf(server): long threads open about 2.5x faster (pingdotgg#34014)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* perf(server): long threads open about 2.5x faster (pingdotgg#34014)
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(mobile): inline markdown images page through their message's images (pingdotgg#37117)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(mobile): /model suggestion opens the model picker (pingdotgg#37109)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(desktop): release cancelled Codex callback listeners during browser launch (pingdotgg#29734)
Co-authored-by: maria-rcks <maria@kuuro.net>
* perf(server): skip compression for the desktop's local connection (pingdotgg#30832)
Co-authored-by: maria-rcks <maria@kuuro.net>
* fix(server): outside MCP clients stop being offered thread-bound tools (pingdotgg#32764)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(ssh): preserve literal home paths in Include expansion (pingdotgg#33288)
Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
* fix(server): finish closed terminal kills before shutdown (pingdotgg#37113)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): keep distinct images with matching attachment metadata (pingdotgg#37116)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): large terminal pastes reach the program intact (pingdotgg#37103)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): settling a thread keeps exec and foreground Bash terminals open (pingdotgg#37125)
* fix(codex): keep browser access prompts available in full access (pingdotgg#37104)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(web): open terminal file links naming the server hostname (pingdotgg#37133)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(mobile): recheck the current branch before selecting it (pingdotgg#37121)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(acp): wait for session/load to reply before prompting (pingdotgg#37139)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): terminal mouse reports hit the drawn cell (pingdotgg#37148)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): run_scheduled_task_now returns why a started run failed (pingdotgg#37149)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(azure-devops): pull request titles like `@notes.txt` are saved as typed (pingdotgg#37110)
* fix(web): Sharing & access can select a desktop-local WSL backend (pingdotgg#37151)
* fix(mobile): pasted GIFs on iOS keep their animation (pingdotgg#37143)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(acp): Copilot's reply after a background agent wakes it opens a continuation run (pingdotgg#37159)
* fix(shared): ß no longer splits words in generated folder and branch names (pingdotgg#37152)
Co-authored-by: lowlyleon <183293296+lowlyleon@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): name the missing project when a change request's repository has none (pingdotgg#37161)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): an oversized provider request reads as too large, not raw 413 HTML (pingdotgg#37156)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(provider-acp): Grok early task completion no longer replaces the child's answer (pingdotgg#37162)
* fix(web): keypad navigation works with NumLock off (pingdotgg#37175)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): keep thread mentions when editing sent messages (pingdotgg#37183)
* fix(server): skills linked by a SessionStart hook appear in the $ picker in the same session (pingdotgg#37165)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): Windows spawn workers no longer leak a short child's output pipe to a sibling (pingdotgg#37180)
* fix(web): repaint terminal when programs change default colors (pingdotgg#37193)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): composer suggestions stay reachable in short windows (pingdotgg#37179)
Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): Claude session name follows thread renames without waiting for the next turn (pingdotgg#37185)
* fix(web): Enter sends when a panel-conditioned shortcut is inactive (pingdotgg#37198)
Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): project search starts working once a slow content index finishes building (pingdotgg#37138)
* fix(web): terminal file links preserve numeric filename suffixes (pingdotgg#37201)
Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(mobile): cutting text in the iOS composer can be undone (pingdotgg#37158)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): modified F3 reaches ncurses terminal bindings (pingdotgg#37211)
* fix(mobile): iOS video previews keep their contain fit instead of sometimes cropping (pingdotgg#37186)
* fix(server): delegate_task names the CLI version that hides a model (pingdotgg#37214)
* fix(web): switching a draft’s machine keeps its selected models (pingdotgg#37208)
Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): concealed terminal text stays hidden under the cursor (pingdotgg#37141)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): legacy mouse reports reach the PTY byte for byte (pingdotgg#37223)
* fix(web): editing a queued message into /btw no longer saves it to the main thread (pingdotgg#37228)
* fix(web): usage chart and share-bar figures reach screen readers (pingdotgg#37238)
* fix(web): screen readers announce each Usage figure with its label (pingdotgg#37241)
* fix(desktop): a renderer that keeps crashing is reloaded with a backoff instead of left blank (pingdotgg#37240)
* fix(web,mobile): @ picker finds older settled threads on linked machines (pingdotgg#37243)
Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(terminal): one web viewer answers shared PTY queries (pingdotgg#37233)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(acp): recognize sessions already owned by a thread (pingdotgg#37244)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(acp): show local agent reported version (pingdotgg#37229)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): imported Claude sessions are titled after the prompt inside a wake envelope (pingdotgg#37257)
* fix(server): theme set help names which clients apply the theme (pingdotgg#37259)
* test(desktop): two-account callback test uses two distinct ports (pingdotgg#37271)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(mobile): Duo scroll indicator sits past the vertical bar, at the screen edge (pingdotgg#37265)
* fix(mobile): sending a message no longer shifts the feed before it settles (pingdotgg#37267)
* fix(web): copied code blocks drop the fence's trailing newline (pingdotgg#37284)
* fix(web): close Usage without reloading (pingdotgg#37272)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): Codex prompt suggestions no longer imitate delegated task notices (pingdotgg#37292)
* fix(mobile): tasks in unconnected linked environments no longer show the OpenAI logo (pingdotgg#37289)
* fix(mobile): fully typed /model keeps its suggestion (pingdotgg#37280)
Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): schedule_task uses the project's effective default model (pingdotgg#37299)
* fix(mobile): swipe actions no longer clip in short thread rows (pingdotgg#37285)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): a background OpenCode subagent's question survives its parent's turn end (pingdotgg#37300)
* fix(server): PowerShell process scans keep non-ASCII names on Windows (pingdotgg#37264)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(mobile): iOS multi-item text paste folds into an attachment (pingdotgg#37301)
* feat(mobile): open iOS images in a native viewer modelled on Messages (pingdotgg#37100)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(mobile): iPhone New chat stays beside the tabs after a Settings page (pingdotgg#37021)
Co-authored-by: Christopher Wilkus <309776208+cwilkus1-bit@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(server): dismissing a background OpenCode subagent's question lets it carry on (pingdotgg#37319)
* fix(mobile): environment filter leaves out switched-off environments (pingdotgg#32946)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): work a dead provider process was running no longer stays Running (pingdotgg#37325)
* fix(server): remote tasks report their actual model (pingdotgg#37332)
* fix(provider-grok): steer queued messages into a running Grok turn (pingdotgg#37335)
* fix(web): terminal decorations stay visible under the block cursor (pingdotgg#37206)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: GPT 6.1 Sol <codex@openai.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(clients): command palette skips tasks shown under their parent (pingdotgg#37315)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(mobile): inline audio keeps playing when its row scrolls out of view (pingdotgg#37340)
Co-authored-by: cmcgrabby-hue <267390149+cmcgrabby-hue@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): clear title markers stuck on old subagent and fork threads (pingdotgg#37364)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): nested Claude subagent summaries no longer show Claude Code's hand-back frame (pingdotgg#37355)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(web): file tabs keep their scroll position when you switch back (pingdotgg#37361)
* fix(server): Windows PowerShell terminal reads native UTF-8 output correctly (pingdotgg#37376)
* fix(web): No project threads in New worktree mode send without a base branch (pingdotgg#37392)
* fix(mobile): Stop stays reachable while a question card is expanded (pingdotgg#37398)
* fix(server): an ACP agent's open tool call ends when its process dies mid-turn (pingdotgg#37377)
* fix(web): a disabled Merge back button shows why it is disabled (pingdotgg#37395)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* fix(server): a delegated child's turn end re-offers only its own parent run's wake (pingdotgg#37399)
* fix(server): service protect and status say when the kernel has no memory controller (pingdotgg#37410)
* fix(server): a wake stuck on one thread's parent lock no longer holds up other threads' wakes (pingdotgg#37416)
* fix(mobile): first visit to an iOS tab no longer flashes black (pingdotgg#37083)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(server): one busy thread's lock no longer stalls other threads' queued runs (pingdotgg#37417)
* fix(mobile): a tab's bar buttons no longer fade in on its first visit (pingdotgg#37302)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fix(server): the first file search after a big folder lands no longer freezes the server (pingdotgg#37451)
* fix(mobile): thread context menu offers Mark unread (pingdotgg#37426)
* fix(server): a timed-out branch totals diff is not rerun until HEAD or its base moves (pingdotgg#37455)
* fix(cli): t3 pair --tailscale names the operator fix when Tailscale denies Serve (pingdotgg#37466)
* fix(server): fx and Muse refreshes drop models they no longer list (pingdotgg#37457)
* fix(pi): image reads show a preview in the work log (pingdotgg#37471)
* fix(pi): resume the session file an extension switched the thread to (pingdotgg#37472)
---------
Co-authored-by: amr sarhan <167830562+amr807@users.noreply.github.com>
Co-authored-by: amr sarhan <amr@amrs-MacBook-Air.local>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Rishabh Bothra <37180068+07rjain@users.noreply.github.com>
Co-authored-by: Jiri Kvapil <53862157+kvapca@users.noreply.github.com>
Co-authored-by: Dias <87440198+JoaoMarcos44@users.noreply.github.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Prem Chaitanya Prathi <chaitanyaprem@gmail.com>
Co-authored-by: Alex Southwell <saphid@gmail.com>
Co-authored-by: Wesley Smits <wesleysmits@icloud.com>
Co-authored-by: Dhairya <127371606+Dkm0315@users.noreply.github.com>
Co-authored-by: Nathan Wong <thelogicmatrix@gmail.com>
Co-authored-by: Nathan Wong <20381195+thelogicmatrix@users.noreply.github.com>
Co-authored-by: Nei Cardoso de Oliveira Neto <nei.neto@hotmail.com>
Co-authored-by: Gourav Kumar Dhiman <gkrdhiman@gmail.com>
Co-authored-by: Omar Espinosa <77650361+OmarAlex24@users.noreply.github.com>
Co-authored-by: Sudharsan <126713117+Sidreyas@users.noreply.github.com>
Co-authored-by: Mahir Taha Özdin <mahirozdin@bubiapps.com>
Co-authored-by: jacobcorbett <dev@jacobcorbett.com>
Co-authored-by: MarcoDotIO <Marcus.Arnett10@gmail.com>
Co-authored-by: Wout Stiens <71498452+StiensWout@users.noreply.github.com>
Co-authored-by: GPT 6.1 Sol <codex@openai.com>
Co-authored-by: Yash Singh <saiansh2525@gmail.com>
Co-authored-by: spoukyii <61633921+spoukyii@users.noreply.github.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Felix Laga <felix.laga@yahoo.com>
Co-authored-by: azhar <azhar.amirr@gmail.com>
Co-authored-by: azhar <azhar.amir@amartha.com>
Co-authored-by: Yuvraj M. <63858962+plusk-dev@users.noreply.github.com>
Co-authored-by: oliver <97427849+flamboh@users.noreply.github.com>
Co-authored-by: Amine Ilidrissi <38422328+aminevg@users.noreply.github.com>
Co-authored-by: Mokhles elheni <144564734+M0xoo@users.noreply.github.com>
Co-authored-by: Liam Cullen <liamtc@icloud.com>
Co-authored-by: bentbrain <28818884+bentbrain@users.noreply.github.com>
Co-authored-by: Chung Wei Leong <15154097+chungweileong94@users.noreply.github.com>
Co-authored-by: mark <89562141+markjoshwel@users.noreply.github.com>
Co-authored-by: Andrei <108398860+Yuruzuu@users.noreply.github.com>
Co-authored-by: Lakshmi Tanmay <lakshmi@voltcrash.com>
Co-authored-by: Bilal Bakr <62337003+Bil0000@users.noreply.github.com>
Co-authored-by: GPT-6.1 Sol <noreply@openai.com>
Co-authored-by: Jolymmiles <75259437+Jolymmiles@users.noreply.github.com>
Co-authored-by: Tenyoru <mail@tenyoru.me>
Co-authored-by: Pyseph <45090858+Pyseph@users.noreply.github.com>
Co-authored-by: Zenco <64717583+notzenco@users.noreply.github.com>
Co-authored-by: sergiiopm <120517513+sergiiopm@users.noreply.github.com>
Co-authored-by: Mia's AI Lab <83042094+MiaAI-Lab@users.noreply.github.com>
Co-authored-by: Zuri <zurih@rtx.internal>
Co-authored-by: Bartłomiej Błoniarz <bartlomiej.bloniarz@gmail.com>
Co-authored-by: Kolja <razzeee@gmail.com>
Co-authored-by: lufe <269537355+mrlufepines@users.noreply.github.com>
Co-authored-by: Pradip Chaudhary <88336529+thepradipvc@users.noreply.github.com>
Co-authored-by: t3-code-bot[bot] <269035359+t3-code-bot[bot]@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: Victor <satsdev@only21mil.xyz>
Co-authored-by: Pulsar Programmer <programingcoder101@gmail.com>
Co-authored-by: Entrpi <133157614+Entrpi@users.noreply.github.com>
Co-authored-by: seancarnahan <sean.carnahan5@gmail.com>
Co-authored-by: shadi <87688860+shadizx@users.noreply.github.com>
Co-authored-by: Sharoon Rafeek <sharoonrafeek@gmail.com>
Co-authored-by: Xiao Wei Chen <xiaowei.work@gmail.com>
Co-authored-by: J. Gae. <j.gaertig@gmx.net>
Co-authored-by: Sadman Habib <81114762+hxbib@users.noreply.github.com>
Co-authored-by: Jason Lernerman <43508353+u9g@users.noreply.github.com>
Co-authored-by: luke <97411838+luke2x@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Hieu Le <78847613+hieu-lee@users.noreply.github.com>
Co-authored-by: Darsh Mahadevia <160497999+darshmahadevia@users.noreply.github.com>
Co-authored-by: Adamulek123 <adam.bogucki2018@gmail.com>
Co-authored-by: Boban Kostadinoski <hello@itsthierry.com>
Co-authored-by: ItsThierry <274141289+ItsThierry@users.noreply.github.com>
Co-authored-by: Valtrizt Khalifah Warri <108137942+valuin@users.noreply.github.com>
Co-authored-by: Romil <romilbij@gmail.com>
Co-authored-by: RVZO6 <66844656+RVZO6@users.noreply.github.com>
Co-authored-by: Simone <lucenz@proton.me>
Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com>
Co-authored-by: Fuksss <fuxik12345@gmail.com>
Co-authored-by: Leon <leon@dreamslice.studio>
Co-authored-by: lowlyleon <183293296+lowlyleon@users.noreply.github.com>
Co-authored-by: Katya <caiton@pm.me>
Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: DrStrangerUJN <343873859@qq.com>
Co-authored-by: Theo Browne <me@t3.gg>
Co-authored-by: Dustin Loring <dustinwloring1988@gmail.com>
Co-authored-by: Fattah 💻 <203197396+abdfattahz@users.noreply.github.com>
Co-authored-by: cwilkus1-bit <cwilkus1@gmail.com>
Co-authored-by: Christopher Wilkus <309776208+cwilkus1-bit@users.noreply.github.com>
Co-authored-by: Tom Moses <tom@tmoses.uk>
Co-authored-by: Yaz Caleb <yaz@plaw.io>
Co-authored-by: Onkar Pradip Jadhav <118719336+Onkarj012@users.noreply.github.com>
Co-authored-by: cmcgrabby-hue <pencilspinner86@gmail.com>
Co-authored-by: cmcgrabby-hue <267390149+cmcgrabby-hue@users.noreply.github.com>
Co-authored-by: Alex Hatzenbuhler <hatz@hey.com>
Co-authored-by: Jackson Miller <jackson@jackson.codes>
Co-authored-by: Sharad Patel <96814788+Sharad-Patel1@users.noreply.github.com>
Co-authored-by: soap-agentops[bot] <310870250+soap-agentops[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:XS0-9 changed lines (additions + deletions).vouch:trustedAuthor is trusted by repo permissions or the VOUCHED list.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenCode 1.19.5's task tool builds a child session's permission from only the parent's deny and external_directory rules (agent/subagent-permissions.ts), and a running child reads its session once, so T3's post-creation session.update never reached the child. In Full access the parent's only rule was
* * allow, so the child fell back to the agent defaultexternal_directory: askand prompted. openCodePermissionRules now returns* * allowplus an explicitexternal_directory * allowfor Full access. OpenCode copies that rule into the child at creation, before its first tool call. Parent behaviour is unchanged, and openCodeChildPermissionRules already treats the copied rule as inherited, so the follow-up rewrite does not duplicate it. Verified against a realopencode serve1.19.5 with the hub's gpt-6-luna: with the old rules the @general child was created with [task deny] and asked external_directory for /tmp/.../outside/*. With the new rules the child was created with [external_directory allow, task deny] and completedcaton the outside file with no permission request. No new regex or parser.Fixes #35246
Reproduction on main
Commit fd8e386 (origin/main). Ran
T3CODE_DEV_SEED=0 vp run devin a fresh worktree, paired the web client in the preview browser, added a scratch git repo as a project, added the OpenCode provider in Settings > Providers (detected v1.19.5, authenticated) and picked OpenCode GPT-6 Luna, with the thread in the default Full access mode. (Claude models through OpenCode failed with a provider tool-schema error, unrelated.) Prompt: 'Use the task tool to launch a @general subagent ... runcat /tmp/<scratch>/outside/notes.txtandgit -C <project> log --oneline'. OpenCode's log: parent session created with [{* * allow}]; child created with only [{task * deny}]; 4 s laterevaluated permission=external_directory pattern=/tmp/<scratch>/outside/* action.action=askandasking id=per_... permission=external_directory. OpenCode's database then held [{task deny},{* * allow},{task deny}] for the child (written by T3's session.update), but the running child never used it. In the T3 UI the subagent item 'Run requested shell commands' showed 'Waiting for approval · Decline · Approve' on the outside path, and the thread showed 'Approval' in the sidebar, although the thread was in Full access. In the OpenCode 1.19.5 source, SessionPrompt.run reads the session once before its step loop (session/prompt.ts:1085), and the task tool (tool/task.ts + agent/subagent-permissions.ts) copies only the parent's deny and external_directory rules into the child.Evidence
Configured OpenCode 1.19.5 in two fresh web-app environments. With Full access selected, submitted the same prompt asking a task-tool @general subagent to read a synthetic file outside the project and run git log. No approval was granted.
Environment: Linux, Chromium preview browser, light theme, 1280×800 CSS pixels; separate fresh databases with development seeding disabled. Captures were inspected before upload. Private provider metadata is masked and the machine panel is cropped out; stills also mask changing elapsed counters. Eight seconds of initial loading were trimmed equally from both recordings.
Reproduction driver · Seed script · Capture notes · Runtime summary · Provider permission evidence
AI-assisted; verified with the tests and tools listed above.
Not shown:
Tests
vp test run src/server/adapter.test.ts in packages/provider-opencode: 54 passed. The new assertion in 'maps runtime modes to safe OpenCode permission rules' fails with the fix stashed (expected undefined to equal 'allow'). vp run check:changed: format, lint, knip, typecheck (10 packages) and tests (2 files) all pass. Manual run against a real opencode serve 1.19.5 (scratch driver, not committed): the bug reproduced with the old rules and was gone with the new ones.
Not in this change
AI-assisted; verified with the tests and tools listed above.