Skip to content

fix(server): let Antigravity validate newly discovered models - #36804

Open
Kirat0201 wants to merge 5 commits into
pingdotgg:mainfrom
Kirat0201:codex/issue-35693-current
Open

Kirat0201 wants to merge 5 commits into
pingdotgg:mainfrom
Kirat0201:codex/issue-35693-current

Conversation

@Kirat0201

Copy link
Copy Markdown
Contributor

Problem

An existing Antigravity session rejects newly available models before asking the provider. Its cached choices can be older than the catalog refreshed in a separate session. Fixes #35693.

Change

For an explicit model absent from cached choices, send the existing setConfigOption("model", value, { allowUnlistedValue: true }) request. Let the provider accept or reject it, preserving errors through the existing mapper. Advertised choices, defaults, and legacy aliases retain their existing paths.

Scope

A small validation fix in one provider helper, covered by CONTRIBUTING.md's small obvious bug-fix exception. The session remains in place and provider rejection propagates without a fallback.

Related #28433 fixes catalog discovery and #32167 isolates catalog refresh failures. This fix handles explicit selection in an already-open session whose cached choices are stale.

Verification

On base 121f0cf014, four regression cases fail: an unlisted explicit model is rejected locally, and three provider-rejection cases receive the local error instead of the provider's mapped error. With this change, the acceptance case returns the selected model after exactly one unlisted-model request; the rejection cases preserve the provider error and issue no fallback request.

  • vp test run --project t3 apps/server/src/provider/acp/AntigravityAcpSupport.test.ts apps/server/src/orchestration-v2/Adapters/AntigravityAdapterV2.test.ts apps/server/src/textGeneration/AntigravityTextGeneration.test.ts: 101 tests passed, including defaults, advertised/grouped choices, legacy aliases, and caller behavior.
  • node scripts/check-changed.ts --concurrency 2: formatting, lint, both unused-code passes, GraphQL validation, three package type checks, and 54 selected tests passed. Test selection excluded browser and renders projects for the CLI-only workflow. Commit hooks passed.
  • macOS arm64, Node 26.12.1, isolated TMPDIR and T3CODE_HOME, frozen dependencies. No live T3 data was used.

This proves deterministic server selection and error propagation. A live account rollout and UI model switch were not verified. Current main has no additional changes to the two files in this fix.

Model and harness: GPT-6 via Codex desktop.

@github-actions github-actions Bot added vouch:unvouched Author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Nov 14, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 495a503

Macroscope's review found this PR approvable — Explicitly selected, unlisted Antigravity models are now validated by the agent instead of rejected locally. Default selection behavior and agent error propagation remain unchanged.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Explicit model IDs absent from cached Antigravity options are now sent to the provider with allowUnlistedValue: true. The function returns the matching legacy model family when available, or the resolved value otherwise. Tests cover provider acceptance and mapped rejection.

Changes: Antigravity model selection

Layer / File(s) Summary
Set explicit unlisted models
apps/server/src/provider/acp/AntigravityAcpSupport.ts, apps/server/src/provider/acp/AntigravityAcpSupport.test.ts
Explicit unlisted model IDs are sent with allowUnlistedValue: true and returned when accepted. Listed models continue to use setModel. Tests verify provider rejection is propagated through mapError.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Possibly related PRs

  • pingdotgg/t3code#25544: Changes model validation and selection through session/set_model in the same Antigravity selection path.
  • pingdotgg/t3code#20979: Changes concrete model selection and config updates for Antigravity ACP.

Suggested labels: bugfix

Suggested reviewers: t3dotgg, juliusmarminge, yash-singh1

Merge Risk: Minimal · up to fce71

Selecting a newly discovered Antigravity model in an existing session is now sent to the provider instead of being rejected locally. Provider rejections still surface as errors. No merge-blocking risk was identified.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: Antigravity now sends explicit models that are absent from the cached choices to the provider for validation, instead of rejecting them locally. It follows the convent…
Description check Passed The description follows the template sections: Problem, Change, Scope, and Verification. It explains the stale cached model choices and the provider-side validation fix. It links issue #35693 and cite…
Linked Issues check Passed [#35693] Requires that an explicit model discovered after an Antigravity ACP session started can be applied in that open session, or that the session is refreshed. At head, applyAntigravityAcpModelSel…
Out of Scope Changes check Passed The change set is limited to the selection branch of applyAntigravityAcpModelSelection in AntigravityAcpSupport.ts and its test file, per the raw summary. Each source change serves the objective of [#…
Full details: Title check

Explanation

The title names the main change: Antigravity now sends explicit models that are absent from the cached choices to the provider for validation, instead of rejecting them locally. It follows the conventional commit format and is 61 characters long.

Full details: Description check

Explanation

The description follows the template sections: Problem, Change, Scope, and Verification. It explains the stale cached model choices and the provider-side validation fix. It links issue #35693 and cites the base commit with reproduced regression results. It lists the commands run and the test counts, and it names the unverified areas: live account rollout and UI model switching. It also names the model and harness used. The Scope section gives the reason for skipping a linked issue for the obvious-bug case, which matches the template. The description is mostly complete and meets the template requirements.

Full details: Linked Issues check

Explanation

[#35693] Requires that an explicit model discovered after an Antigravity ACP session started can be applied in that open session, or that the session is refreshed. At head, applyAntigravityAcpModelSelection in apps/server/src/provider/acp/AntigravityAcpSupport.ts checks the advertised options. A listed value uses runtime.setModel. An explicit value absent from the cached choices now calls runtime.setConfigOption("model", resolved, { allowUnlistedValue: true }), with errors passed through input.mapError. The provider decides acceptance. The former local invalidParams rejection no longer exists in the function, so no explicit unlisted model fails locally. Legacy families still resolve through legacyAntigravityFamily and use the same setConfigOption request. The default path cannot yield an unlisted value: resolveAntigravityModel returns the default only when it is listed or a legacy family, and otherwise returns current. The raw summary reports tests for the acceptance case (one unlisted request) and for provider rejection (mapped error, no fallback). I did not read the test file at head, so those test claims rest on the summary. Live acceptance on an open session is not verified, as the PR description states. The code path matches the issue's expected behavior.

Full details: Out of Scope Changes check

Explanation

The change set is limited to the selection branch of applyAntigravityAcpModelSelection in AntigravityAcpSupport.ts and its test file, per the raw summary. Each source change serves the objective of [#35693]: unlisted explicit models go to the provider. The branch that returns the legacy family after setConfigOption is kept, so legacy aliases retain their path. The behavior change for explicit IDs that are neither advertised nor legacy, such as 'Gemini saved', is a direct consequence of removing the local rejection. The test changes cover the same path. No unrelated files were identified in the reviewed summary. The test file at head was not read directly.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 544276b and fce7194.

Files selected for processing: 1

  • apps/server/src/provider/acp/AntigravityAcpSupport.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@juliusmarminge juliusmarminge added the takeover:in-progress A takeover lead is working on this PR label Nov 14, 2026
@github-actions github-actions Bot added size:S 10-29 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Nov 14, 2026
@juliusmarminge

Copy link
Copy Markdown
Member

The automated pipeline stopped on this pull request and will not merge it:

the fix is written and reviewed, but proving it needs something no worker has:

  • Permanent blocker: Antigravity and a signed-in account are unavailable on all worker VMs. The reproduction requires a live session retained across discovery of a newly available model; replay cannot substitute for this provider-specific condition. Base rejection, head acceptance and turn startup, and propagation of the provider's mapped rejection error remain unverified.

It stays open for a person to finish or close.

@juliusmarminge juliusmarminge added takeover:blocked Takeover blocked; reason in the PR body and removed takeover:in-progress A takeover lead is working on this PR labels Nov 14, 2026
ryush00 pushed a commit to ryush00/t3code that referenced this pull request Nov 16, 2026
ryush00 pushed a commit to ryush00/t3code that referenced this pull request Nov 16, 2026
ryush00 pushed a commit to ryush00/t3code that referenced this pull request Nov 16, 2026
ryush00 pushed a commit to ryush00/t3code that referenced this pull request Nov 16, 2026
ryush00 pushed a commit to ryush00/t3code that referenced this pull request Nov 17, 2026
ryush00 pushed a commit to ryush00/t3code that referenced this pull request Nov 17, 2026
ryush00 pushed a commit to ryush00/t3code that referenced this pull request Nov 18, 2026
ryush00 pushed a commit to ryush00/t3code that referenced this pull request Nov 19, 2026
ryush00 pushed a commit to ryush00/t3code that referenced this pull request Nov 19, 2026
@juliusmarminge juliusmarminge added takeover:in-progress A takeover lead is working on this PR and removed takeover:blocked Takeover blocked; reason in the PR body labels Nov 19, 2026
juliusmarminge and others added 2 commits November 19, 2026 04:39
Explicit unlisted models now go to the agent, and a non-explicit default is
only resolved when listed or a legacy family, so the local rejection could
no longer run.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@juliusmarminge juliusmarminge added takeover:blocked Takeover blocked; reason in the PR body and removed takeover:in-progress A takeover lead is working on this PR labels Nov 19, 2026
ryush00 pushed a commit to ryush00/t3code that referenced this pull request Nov 19, 2026
ryush00 pushed a commit to ryush00/t3code that referenced this pull request Nov 19, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). takeover:blocked Takeover blocked; reason in the PR body vouch:unvouched Author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Antigravity existing sessions reject newly discovered models due to stale cached configOptions

2 participants