Repository navigation
fix(web): keep Pi and ACP model selections during catalog gaps #37528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
juliusmarminge
merged 3 commits into
pingdotgg:main
from
StiensWout:t3/preserve-pi-acp-model-selection
Nov 16, 2026
+204
−93
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
a031ffe
fix(web): Pi and ACP keep a chosen model while their catalog is refre…
StiensWout ff633c2
fix(web): retain ACP default alias behavior during catalog discovery
StiensWout a93eaec
Merge remote-tracking branch 'origin/main' into t3/preserve-pi-acp-mo…
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolve catalog aliases before treating a model as missing.
The gate checks membership with
normalizeModelSlug, which expands only static aliases. A catalog alias such aslegacy-test-modelis therefore classified as missing when its catalog row has slugtest-model. The function then returns rawmodelOptionsand skips descriptor filtering. UsingresolveSelectableModelfor membership matches the resolution thatgetProviderModelCapabilitiesalready performs.TraitsPicker.tsx:125-126uses the same slug-only check and should use the same helper.Suggested fix
import { buildExplicitProviderOptionSelectionsFromDescriptors, getProviderOptionCurrentValue, getProviderOptionDescriptors, isClaudeUltrathinkPrompt, - normalizeModelSlug, + resolveSelectableModel, withImplicitFastModeDefault, } from "@t3tools/shared/model";if (keepsUnavailableModelOptions(provider, model)) { - const normalizedModel = normalizeModelSlug(model, provider); - const modelIsInCatalog = models.some((candidate) => candidate.slug === normalizedModel); + const modelIsInCatalog = resolveSelectableModel(provider, model, models) !== null; if (!modelIsInCatalog) {